From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D58FC367B6F for ; Mon, 6 Jul 2026 10:39:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783334379; cv=none; b=SFFOdd/YMy2lTBuhy3ZmMciIF8ww1rVoCCr//rvCAdKE7d6Nhh3yHUIzDHx51BcBRZTHQT4JCSfpTWMgIR6s2g2WtTdv9qddfB0F9YBrmU/BJPYKbdn0jWBCUbx3JIHM73UuZlw0rzdrgk8Ksk6BZ/vVfljbTpfT7QnnEs9I6s0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783334379; c=relaxed/simple; bh=3NqyvZK6r61fTF0y4rbK6dX7OLUGCMSqOwp3B7dW+hA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BvW24YVTO8pWfi0Vtemnb955e7y6mlWPLo71stQO/EQvnQ1IyU5+sjJ8JE5nZ6/5vEprEPNWdbf4Edga4fKjuRrTtif1X0LJUw1ldUg4Qr5DEqzfsmYnTlkjcaIwxMvMv3TGlEePTxOXtycg/13/EO3aeWRWLje/eOEGoDLzvzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Uj/8+dhn; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Uj/8+dhn" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso749947f8f.1 for ; Mon, 06 Jul 2026 03:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783334376; x=1783939176; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=Uj/8+dhn/CqFp4OTuS0xwacaZ9CMhXFrh+deNNENkMFTS9sg6d5lyDoGNzDx+Wlw/1 Eq+910u0ujuI9P9RwRqDAqFwsrGDmFqV7AR+oSyUa0yK6V1X4dGeloLPNPSSCVuR4rTY pOh1Dyw37ujBAuRs5AfT6os4aeWI+cLURbigcedOy9wr8yheMMD3ptiaiZmGfKEUad2U c6gVdg+q6AZT4gnkYZQp/Rj5t2++tMgROYAs1JA21ZrTDotyRLwIhL40VaZnmKOI9shW IVXseCjGdhqahX2ibAOO55v3odZyKZuzPCda33EzWsddNAsQEiT7h/MPlNoCS0BsFdP7 GJDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783334376; x=1783939176; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=LlF9t5ahnKw9yjFlsKKLddx7lpoRWq5PHmAEiTfQFjm7vcyHfd/dQ/PTHMM8BkO2F0 M9e50Z6kuao0MpYEWh29kxcbxvsr5UJLRqyNS9dGSgL5a+tLr5dv7APv7CbkVwO76USK JqbMkMOEacFqLZVHkiDhVljGoAuXYSDvajEVI9awg47MSSwM4fKCs15X/5XHTMR440bU yxGIoemMKfpvvCBcxBPyqKXIvtDg5NAFIbM4UsqRk88wjC9va0Tgz6MqlWmlM6Y9yqMn etVlE6L4Ms5K6fn+4DcKlPPaDp5Wad0zgaV85znbKtRQ8B70FaG9H7rd/0DD2cmtOAcW g0rw== X-Forwarded-Encrypted: i=1; AHgh+Ro38pebRt/XPV3soNw6F3Xedrc1ypr473pe2j8G/rMvXQzTS6/zXiSAgHMe70dgdLWECLc=@lists.linux.dev X-Gm-Message-State: AOJu0YzzNfZDChY6Em2BlFmwvvGTV8NatZ475ah6oKRZKnH5GrvTl2cm HW4jJXgNnztxG4xi89mu8c7LYjuU8tXiSAWgjm8uTbl6PrcYtv+dqjWi9BswWiJVadk= X-Gm-Gg: AfdE7ckfqcbMM21J9rg5u0pUXKqQgOmfDEIuoFeZJZEQwegFqoU0pw05rpdYlJoG2id CndiILRFiFOh81YG1nWKKqNcTL1EAG0DkUgIDt5Y2S1BOUkG2tub4wEQmI50NtZKeT5o/LXEsMG 3Y+VTsHtVIGemfLs07YpzUibnWAAh2wg+jM+6pifOhrh8GDzG1/E4pXLPZAvoIZKv/go8po+etN GcnoTqIBTpea00iCIsisID7v88MoNiLfHoF6TUqNis/oM4RFUUV00dt4nKGIkBZ6hXR14/dEzXm 6XVZlmWbKmd4wr1o0KSYwTPVJAx2WJd8MlOCyD+Bg27ACnMCJptZa0+XHrDn8152ono5XIg3H27 QHhi4Gf82wXtHyMdNfCZd0oIu5nSZxTNzo3mhbxAvzG5NCLiy4nXrfIE3Us8G3vGW7J5SVTL7DX LAcl3vzKMeYuW6r0HDGHhrjxVGTXBIx/7PeTgh7Kb2ACVgHSrGeYFoZ2QljgpOl9jFQ12Hp4nWx WeB X-Received: by 2002:a05:6000:4698:b0:475:36a:8c97 with SMTP id ffacd0b85a97d-47aab76f017mr8079359f8f.45.1783334376207; Mon, 06 Jul 2026 03:39:36 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47a9de1d8cdsm25702223f8f.1.2026.07.06.03.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 03:39:35 -0700 (PDT) Date: Mon, 6 Jul 2026 12:39:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Chen Wang , linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vyrf5kfcddz5uoeo" Content-Disposition: inline In-Reply-To: --vyrf5kfcddz5uoeo Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello, On Mon, Jul 06, 2026 at 10:28:16AM +0200, Philippe Mathieu-Daud=E9 wrote: > Hi Uwe, >=20 > On 6/7/26 09:19, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > Hello Chen, > >=20 > > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > > > On 7/5/2026 11:14 PM, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > > > - Use a single space in a of_device_id array terminator; A singl= e space > > > > after the opening { and before the closing } in non-empty > > > > initializers; > > > > - No comma after an array terminator; > > > > - Also no trailing comma after a named initializer iff the > > > iff -> if > >=20 > > This is actually intended. iff =3D "if and only if", see e.g. > > https://en.wikipedia.org/wiki/If_and_only_if . >=20 > I agree this scientific idiomatic expression is not well known > by non-native English speakers, and using the expanded form is > just simpler to review (thinking at non-native English speaker > reading your commit in the future). fine for me, I'll fixup to=20 - Also no trailing comma after a named initializer if (and only if) the closing } is on the same line; when applying. Best regards Uwe --vyrf5kfcddz5uoeo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLheQACgkQj4D7WH0S /k6DEQf+JKDZ+NcR412RMDPBxcWuk831SswOfJipQJVDxTsFWtpZIrZIbOu0ZlBp IEWpfB5nRfHwTSxF6Ceuf2jTc+wkwcRBKeH4MQsZFpGxBjGa4k7YEEfMSDU9S1vU 39G1FIVXnf0sDkUOUGf5zIomYewh4gdCoWRwDnCHsV4QnZKAaKCCEpX0U6QdW2OP diy3iqasYf6KZyXnUyj0HBQRGjBYY4jBvVutXt4KtCqAKW+AcCANOtubadJgydWD xXNkFLpscFQ9aVdyKZK19UP9yKdOwzkjR9pul+TqXDviO0c5UoAZEwMZYDbB1YPi AJloqZ9/3vBcnEjZo3eWYk8zkrQifQ== =vnC0 -----END PGP SIGNATURE----- --vyrf5kfcddz5uoeo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D89E3C43602 for ; Mon, 6 Jul 2026 10:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jteuzpFDphw1D8tCO7fBC50D8h4YGfz2nKMzfEBSWSQ=; b=4kjGUSPbeqna7GsZGFgbsC2sOu BbHVHCRTnuCwr3e5E6gUKhxJgYTtmLQcL62QG9xOwYiON2yaufXRABhM7pZsXXhyPA/DNC7+vS69s 9dFE0m6eJg6Yy6wVXq/UXZe2F5WTzb7YRz257RX8duG5aVP1wa/P/zn2PP2ZtAAKM+EJIFMaG9L3N TJ83d9nWuptx0VuHiXLha9/bX8RPq0Os/+T4jXzjnbv7imPBs9XU6NiqYm50IhNdkIpynJdyjGP0c ygLnMiPeDoHFDidkQeOyd7yPcf63tjBsBmrw09mnKqfLfCS4M6Swb7y70i8G+s2hG8kCpK7IPxWHK OjCJobhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wggjn-0000000CFEc-3SfJ; Mon, 06 Jul 2026 10:39:43 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wggji-0000000CFCF-29BG for linux-rockchip@lists.infradead.org; Mon, 06 Jul 2026 10:39:41 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-45fd464d51fso1436927f8f.3 for ; Mon, 06 Jul 2026 03:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783334376; x=1783939176; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=RAGY7VJrRuV6fomU8zjBRG6mSXW+ITJOA42RcGien+zcjd72UOaCfhD+c1nPOef46M ptSzfpkz/wlgqRQ1VvxsJXHDQnU+QIEqBuNI5MFsFhJ7LoiHXGogsBxDSIBDNjeeEoMu Ho+YXKf1lm+mH/08yKs4ClhXSPmuunx1DwxBG8WQwszuoEUeRRtxEuXjXK4d2ixvwYdY sjx7iS2my/sofW6IPS9e+yf9HKP5v0Ly/yk71fLyr3yVuHYyYOaYgE1SQ6+pvrbQpq3j y9eMDcQ393Bq3KFUpKqikoyve4zdR4EEFfHjslQpggFK0g8grvS7GA3ba8D/xFb7Hgux CX1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783334376; x=1783939176; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=Sn7aVhPbt06qCnJqPRz4Kf5+jT9dWSDWbjkkaREJ76/HSBxxNx+lOL/bpo86c8PREf 588T7huEI/ZflgNRv6ddUaVxciW90+bRx6Ruy/g1nrCy/Mz/6+/c3N4ulirLoXpKoJu6 VodBu4saBaAlemdg22/Wg4Fuo+GKoDvtdlUxX5dltIHfBLRyzCq9+B8QtIa0J45PxKj9 Tv4FJOtgWzirimD1EbWzujLY3qwl1VH97qBnDKWAiVP8s7lt8dAlo07XbcadOfjp24Lt 0ZUcDIj/X6g6bGt+PXhUN/+ZvYKtNPKwBa+e28pkpOkJJnLNxK/VMg81p7fZDvfT8kSa oQag== X-Forwarded-Encrypted: i=1; AHgh+Rr3X1gJop5yLCd1u8/i01IefKrdqRvnXpL/qJ8z/QoHh3uu3G+YpcajMuTtTJre7640QFKPUEkk++hP46j/tw==@lists.infradead.org X-Gm-Message-State: AOJu0Yx/sUQ9HGxkm23seJjfLerK7yTDLVU+hT89tGkvfhmyNaUO/Bvr EZlbbPCnnSL01dfaKmnO8rbtvBEj1NstBYQvnpi6KsIC4FbjivaNkyPM6nxaQkZ0rbI= X-Gm-Gg: AfdE7cl5zoRj8/xjf00xg9/UOj5bjSZXooEgFw7xjMWZGXggqVgLfL3UQHoQYfnuq27 JTkOHP0I12s+LjFATUcdlvriBF6CLTqUtZRSeOeHnMhhgharLKB0kZBAQePdE+dFH5zRBC/uWdr 1mvANhFj75faI+0xxZYQe7LQxz0CZtkYKr+covo3dmU+E59cBegpZRAskYEwTxH5I4ZITKsjskb FdwlwZxYMXL1ZEDjp5JBwnVETYCM/ywH1ZEvJj8ZPtsc1v/rFgN7M1su7EDL2xsUHN7BN6OHSW+ SFv98rNMo5z4t7TueogxY6IHDjV2lI7VG2FAzPNL9NjGj5mYC3rs6juGUjKF9Jr32VaJsZcH3X+ f7h5UZ3wbeWZpHSMB5dT2VXZ21fD9hSKu3Nc94R/kr8bRsvb7BO++Jly94W/NYikLwoqUKXhy+P /RE/R/VqAS1yPqdlzadZH7T33uGm7Zi3n3FlwAzexp+oOSPUSeOxraQPGAWD7vPJHDEW15tZX4E DLz X-Received: by 2002:a05:6000:4698:b0:475:36a:8c97 with SMTP id ffacd0b85a97d-47aab76f017mr8079359f8f.45.1783334376207; Mon, 06 Jul 2026 03:39:36 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47a9de1d8cdsm25702223f8f.1.2026.07.06.03.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 03:39:35 -0700 (PDT) Date: Mon, 6 Jul 2026 12:39:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Chen Wang , linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_033938_612760_237E2048 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8981986709266586182==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============8981986709266586182== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vyrf5kfcddz5uoeo" Content-Disposition: inline --vyrf5kfcddz5uoeo Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello, On Mon, Jul 06, 2026 at 10:28:16AM +0200, Philippe Mathieu-Daud=E9 wrote: > Hi Uwe, >=20 > On 6/7/26 09:19, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > Hello Chen, > >=20 > > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > > > On 7/5/2026 11:14 PM, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > > > - Use a single space in a of_device_id array terminator; A singl= e space > > > > after the opening { and before the closing } in non-empty > > > > initializers; > > > > - No comma after an array terminator; > > > > - Also no trailing comma after a named initializer iff the > > > iff -> if > >=20 > > This is actually intended. iff =3D "if and only if", see e.g. > > https://en.wikipedia.org/wiki/If_and_only_if . >=20 > I agree this scientific idiomatic expression is not well known > by non-native English speakers, and using the expanded form is > just simpler to review (thinking at non-native English speaker > reading your commit in the future). fine for me, I'll fixup to=20 - Also no trailing comma after a named initializer if (and only if) the closing } is on the same line; when applying. Best regards Uwe --vyrf5kfcddz5uoeo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLheQACgkQj4D7WH0S /k6DEQf+JKDZ+NcR412RMDPBxcWuk831SswOfJipQJVDxTsFWtpZIrZIbOu0ZlBp IEWpfB5nRfHwTSxF6Ceuf2jTc+wkwcRBKeH4MQsZFpGxBjGa4k7YEEfMSDU9S1vU 39G1FIVXnf0sDkUOUGf5zIomYewh4gdCoWRwDnCHsV4QnZKAaKCCEpX0U6QdW2OP diy3iqasYf6KZyXnUyj0HBQRGjBYY4jBvVutXt4KtCqAKW+AcCANOtubadJgydWD xXNkFLpscFQ9aVdyKZK19UP9yKdOwzkjR9pul+TqXDviO0c5UoAZEwMZYDbB1YPi AJloqZ9/3vBcnEjZo3eWYk8zkrQifQ== =vnC0 -----END PGP SIGNATURE----- --vyrf5kfcddz5uoeo-- --===============8981986709266586182== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============8981986709266586182==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7D9BC43458 for ; Mon, 6 Jul 2026 10:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3PBRqpkwsW1YD1KCA7yog2l4RIGDHE4DjK43m0Lq5fI=; b=Axfbv632FBvd3ClOm2PQ8HFQc2 gM97l8cKH3PQXHgG0tIfYyN5JYFZvSzOXfQbgzrlQBXJilxTfg0a3LyK4blondlt8dN2XW0RCFmVD phffS+iYlibpIGAwOnckdmH0u4L9KyQCGKqeHxOrhzfFqkXHBM1jgVFQP/EZhmjbQBmEyD8CVmqqf N2n3JorI6/Fitf9ns5qy+WuwwWcFkuVg5Z8vlItmms69CSiWz7EaBUW7oTlZtg2dkLyEeavmoPD2o ys17/TVu2gbiLgSdE2ZWcGEOMDVMcdM0svXwb4Wo5VU8RvHQmVoCVQs2Turmkq9Ii53OxWrldUFoC AmBPjjTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wggjm-0000000CFE9-2TUu; Mon, 06 Jul 2026 10:39:42 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wggji-0000000CFCD-2AbQ for linux-amlogic@lists.infradead.org; Mon, 06 Jul 2026 10:39:40 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso749946f8f.1 for ; Mon, 06 Jul 2026 03:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783334376; x=1783939176; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=RAGY7VJrRuV6fomU8zjBRG6mSXW+ITJOA42RcGien+zcjd72UOaCfhD+c1nPOef46M ptSzfpkz/wlgqRQ1VvxsJXHDQnU+QIEqBuNI5MFsFhJ7LoiHXGogsBxDSIBDNjeeEoMu Ho+YXKf1lm+mH/08yKs4ClhXSPmuunx1DwxBG8WQwszuoEUeRRtxEuXjXK4d2ixvwYdY sjx7iS2my/sofW6IPS9e+yf9HKP5v0Ly/yk71fLyr3yVuHYyYOaYgE1SQ6+pvrbQpq3j y9eMDcQ393Bq3KFUpKqikoyve4zdR4EEFfHjslQpggFK0g8grvS7GA3ba8D/xFb7Hgux CX1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783334376; x=1783939176; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=qIfKzUTZ1Qu+CvgEG6B5C72WlxalRdROU+FGSzEWDaK89hCmTepf2UcSBkTGA5CKFV 2Af9aaJyz0G6Tf2GMFfv7rU0CYvqhVSTRmw77nRZJGxwahXRDe86Xy6tOKuk2D8ueImQ iZ695w5XuUTrtiNCjJGK0q0/jdzDxGfcScMVIUYGtLfHLGwBjIwkd3KU/WVTD7R0lDWL tRaGODuBnjf4ssHft+vKBMH9Y9iu19gGcRhho2MgNGM3wjKvx6aGHpAuxV/n0JiP34eu vzaRiNRnbhiC1XHQ8U9EOIhqG0dS6dl6rKRNBupDvHfkXM2CYQDJprlID/mnmVuYwDyl jOyw== X-Forwarded-Encrypted: i=1; AHgh+Rqewa/cqb6mnkQVsTxPw+mScvnGvmUL4XKJmNd91DcBpkaED6iYIi8k86M5wKfcW/dkUveov2XrTrslx/MW@lists.infradead.org X-Gm-Message-State: AOJu0YwzDGLOGna2SPaeYZFQBC0y6m3sAMYVGTKb3Pe4l3kohGweNbzG akR9QTvxER7i20N8s091wFtmMDP7iSurEQg8E30O67yfA7ncb6Y8FF7+sDPG2Z6baQc= X-Gm-Gg: AfdE7clDH7L4IXaDkwXS+EKCKGx1P0GQ3se6g77HuFyL70MvkXPgAF42ETNWt3WWFK4 ivhPBK+EjkQh27Y/7oJNlK/k7YPxnN8+rzqnJ3qDMhExvSwZI8m8BTTnYQATSFBXw1CIxiHCQhX /ficMR0y4OhLdAvjAbbkjcTr8fDT9klOL12Jy//uJLbdy+6DjUn6CZbRQwpASqB+5itF1VFIsJJ y0GwboX0PpnYLM3s4phepkXwtLa3tYPeSNOBd1o7yycKa5caE0zznU+0Ax7i7vuz9RvcZepeUC5 p5lndj0dcCrOZzobqgBiLn6oGGhypirQKLbKWoN03fI6UQUSYUUxplQH8cXnuCVaG6mgQ9Of4Jr ZMPKrezEN2sDlSsZjlSbkSE1UT9oiZtfSTxZttoFOi84cTb0EGQrhDXHf6nSnE5CKtw5aOQgs34 wZruZ3c4arwjsxc/pZLu2+GIhd+N321Gxiswqj1o/5T8SUJbySCRMg0B7z3b8WdPOXmpMKpi6nM K4e X-Received: by 2002:a05:6000:4698:b0:475:36a:8c97 with SMTP id ffacd0b85a97d-47aab76f017mr8079359f8f.45.1783334376207; Mon, 06 Jul 2026 03:39:36 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47a9de1d8cdsm25702223f8f.1.2026.07.06.03.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 03:39:35 -0700 (PDT) Date: Mon, 6 Jul 2026 12:39:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Chen Wang , linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_033938_584178_B068D3DF X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0149405548097131261==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============0149405548097131261== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vyrf5kfcddz5uoeo" Content-Disposition: inline --vyrf5kfcddz5uoeo Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello, On Mon, Jul 06, 2026 at 10:28:16AM +0200, Philippe Mathieu-Daud=E9 wrote: > Hi Uwe, >=20 > On 6/7/26 09:19, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > Hello Chen, > >=20 > > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > > > On 7/5/2026 11:14 PM, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > > > - Use a single space in a of_device_id array terminator; A singl= e space > > > > after the opening { and before the closing } in non-empty > > > > initializers; > > > > - No comma after an array terminator; > > > > - Also no trailing comma after a named initializer iff the > > > iff -> if > >=20 > > This is actually intended. iff =3D "if and only if", see e.g. > > https://en.wikipedia.org/wiki/If_and_only_if . >=20 > I agree this scientific idiomatic expression is not well known > by non-native English speakers, and using the expanded form is > just simpler to review (thinking at non-native English speaker > reading your commit in the future). fine for me, I'll fixup to=20 - Also no trailing comma after a named initializer if (and only if) the closing } is on the same line; when applying. Best regards Uwe --vyrf5kfcddz5uoeo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLheQACgkQj4D7WH0S /k6DEQf+JKDZ+NcR412RMDPBxcWuk831SswOfJipQJVDxTsFWtpZIrZIbOu0ZlBp IEWpfB5nRfHwTSxF6Ceuf2jTc+wkwcRBKeH4MQsZFpGxBjGa4k7YEEfMSDU9S1vU 39G1FIVXnf0sDkUOUGf5zIomYewh4gdCoWRwDnCHsV4QnZKAaKCCEpX0U6QdW2OP diy3iqasYf6KZyXnUyj0HBQRGjBYY4jBvVutXt4KtCqAKW+AcCANOtubadJgydWD xXNkFLpscFQ9aVdyKZK19UP9yKdOwzkjR9pul+TqXDviO0c5UoAZEwMZYDbB1YPi AJloqZ9/3vBcnEjZo3eWYk8zkrQifQ== =vnC0 -----END PGP SIGNATURE----- --vyrf5kfcddz5uoeo-- --===============0149405548097131261== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============0149405548097131261==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3CABC43458 for ; Mon, 6 Jul 2026 10:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JnxOCkAm6299xRxd7XElmaO8BTMlALqhwafTUv+Ka0k=; b=PTjpqKV7kfjlGHp50dyYuZD3c/ +6GpzmWDzCiddgxq/zxWbInr0dvKYMraSwzH1BQ7T4CWV86hYElxxhprOLkN0Rd2BTng/137qoWt5 dYyfXSZyakPMEDWmZjaeVSMpkBaOS22rAQ14JrJFttrWdU34mtYHErFo8DPj4K0Tw5i/AV65khPi+ aXXbXR7OsZ9LYfQZ/RLwKoa/ZAF4fkSutE21xZbOew+L3YPqZf6KhPMLQEi2UKNSvjoslsRXblQBC BAmKFl7jb0z2vYYjn0gySdvUebapPwqMKsf9hisMbMoxbQaRzwGqvdjTbLqpaXdPWSFoi/PrBfioG JeVQ6LHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wggjn-0000000CFEY-36WU; Mon, 06 Jul 2026 10:39:43 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wggji-0000000CFCE-2Ipd for linux-riscv@lists.infradead.org; Mon, 06 Jul 2026 10:39:41 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-47d70879764so791072f8f.2 for ; Mon, 06 Jul 2026 03:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783334376; x=1783939176; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=RAGY7VJrRuV6fomU8zjBRG6mSXW+ITJOA42RcGien+zcjd72UOaCfhD+c1nPOef46M ptSzfpkz/wlgqRQ1VvxsJXHDQnU+QIEqBuNI5MFsFhJ7LoiHXGogsBxDSIBDNjeeEoMu Ho+YXKf1lm+mH/08yKs4ClhXSPmuunx1DwxBG8WQwszuoEUeRRtxEuXjXK4d2ixvwYdY sjx7iS2my/sofW6IPS9e+yf9HKP5v0Ly/yk71fLyr3yVuHYyYOaYgE1SQ6+pvrbQpq3j y9eMDcQ393Bq3KFUpKqikoyve4zdR4EEFfHjslQpggFK0g8grvS7GA3ba8D/xFb7Hgux CX1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783334376; x=1783939176; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=cj0sMXL86ad37fUCmUvp9FaN66g0P0CLQ+RtweVU8dYjZEuQ+T43ZHhGvHyxHURT3w 76THbeaK0mVVF9uAQ7qy88UuqrXmscfMYyjd3VrZEumbasRkTNuSLXZG6h1H6xHuXgvW KYfpeYaE+jyLGyNpoRTwgPvRRGany+9D1/SwNAIVojGvvVA0gEiokwgj0xJJn6g15Cb7 XAjy1XodsslytdWfeHs3N383rajynQKPJ8okh3Pp6EJ0iF9C5C447PrGCi5+q3thLW0h oENF/AuKWO6j6y6gI3qd4zG/wwFvwAvGVJkkFKBe2FYlQ/zm+g8cbAlgIl0rvdhCg/pV ys8w== X-Forwarded-Encrypted: i=1; AHgh+Rqi8cLUiFmshythrUZ4AJPVnsc01y9zNqZ59ScDq2dTaJgswRjJZwSjT54owhx2E9wWNGh1GEMbhGBW8g==@lists.infradead.org X-Gm-Message-State: AOJu0YwLmNgSZF96z8vDsNrxUG2ZQEUKPFTMydbxQTEXkAsXpl7Vh9zr rphnt48GY4CNcFtowsnv+TnXZkU0Y9bNSuzZWxK0EM8mhTo82eY4ZBNzmysPlzG6Cp4= X-Gm-Gg: AfdE7ckkoZ94oeOoD8W1jy78A/nXI78MajkJ1F81mK7oGc8Y/iUQNBtFOWQEzPKp1Pr ENs09quyI+q7S91vV3IAHZvs3h/dv7FMWLdmFtuDPZAFUVwBNPVZys/SuISaueebM113X9dvnHl zkeMFjBnsrB1lBWflxi65TouIrhQ0+nSGcSEZsBRgEoFzddUGp+HCpQhJ9MimKKOGaz5wObLvj4 YKSGhjz1HYYh9da6UVflqq5EcyNy2crISZ8av2crnej+HnhY03D9AnIfqKHvPuJPDtsGb6zG4p6 0KqpSBmtwCTeS+oGVOeceZCXuETs9pob44ZbWez/qhhFGUvdQp0MsTsRJqcfikQQ/aPRjYiPR28 KKv0KabO0lcpgKXvCrqjwX56fnpSTd+7cOvJKicKfNBb5uOr7edbRDrzdQyom8DqB1hr1Ty+MSZ /mHGqNgjBFADq6jDJhLNBub40/SQRZs0pkutiJsEgqh56llubfJBIG+lqZiSht+Vl/2KUynnhan CCR X-Received: by 2002:a05:6000:4698:b0:475:36a:8c97 with SMTP id ffacd0b85a97d-47aab76f017mr8079359f8f.45.1783334376207; Mon, 06 Jul 2026 03:39:36 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47a9de1d8cdsm25702223f8f.1.2026.07.06.03.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 03:39:35 -0700 (PDT) Date: Mon, 6 Jul 2026 12:39:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Chen Wang , linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_033938_621070_3B75E78C X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3026975913438270007==" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org --===============3026975913438270007== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vyrf5kfcddz5uoeo" Content-Disposition: inline --vyrf5kfcddz5uoeo Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello, On Mon, Jul 06, 2026 at 10:28:16AM +0200, Philippe Mathieu-Daud=E9 wrote: > Hi Uwe, >=20 > On 6/7/26 09:19, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > Hello Chen, > >=20 > > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > > > On 7/5/2026 11:14 PM, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > > > - Use a single space in a of_device_id array terminator; A singl= e space > > > > after the opening { and before the closing } in non-empty > > > > initializers; > > > > - No comma after an array terminator; > > > > - Also no trailing comma after a named initializer iff the > > > iff -> if > >=20 > > This is actually intended. iff =3D "if and only if", see e.g. > > https://en.wikipedia.org/wiki/If_and_only_if . >=20 > I agree this scientific idiomatic expression is not well known > by non-native English speakers, and using the expanded form is > just simpler to review (thinking at non-native English speaker > reading your commit in the future). fine for me, I'll fixup to=20 - Also no trailing comma after a named initializer if (and only if) the closing } is on the same line; when applying. Best regards Uwe --vyrf5kfcddz5uoeo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLheQACgkQj4D7WH0S /k6DEQf+JKDZ+NcR412RMDPBxcWuk831SswOfJipQJVDxTsFWtpZIrZIbOu0ZlBp IEWpfB5nRfHwTSxF6Ceuf2jTc+wkwcRBKeH4MQsZFpGxBjGa4k7YEEfMSDU9S1vU 39G1FIVXnf0sDkUOUGf5zIomYewh4gdCoWRwDnCHsV4QnZKAaKCCEpX0U6QdW2OP diy3iqasYf6KZyXnUyj0HBQRGjBYY4jBvVutXt4KtCqAKW+AcCANOtubadJgydWD xXNkFLpscFQ9aVdyKZK19UP9yKdOwzkjR9pul+TqXDviO0c5UoAZEwMZYDbB1YPi AJloqZ9/3vBcnEjZo3eWYk8zkrQifQ== =vnC0 -----END PGP SIGNATURE----- --vyrf5kfcddz5uoeo-- --===============3026975913438270007== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============3026975913438270007==--