From: Matthew Wilcox <willy@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, andriy.shevchenko@linux.intel.com,
usama.arif@linux.dev, hughd@google.com,
"David Hildenbrand (Arm)" <david@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Standardize printing for pgtable entries
Date: Tue, 7 Jul 2026 05:53:45 +0100 [thread overview]
Message-ID: <akyGWZCRbasIX_wY@casper.infradead.org> (raw)
In-Reply-To: <20260707041703.658021-1-anshuman.khandual@arm.com>
On Tue, Jul 07, 2026 at 09:47:03AM +0530, Anshuman Khandual wrote:
> if (!pgd_present(*pgdp) || pgd_leaf(*pgdp)) {
> - pr_alert("pgd:%08llx\n", pgdv);
> + pr_alert("pgd: %s\n", pgd_str);
I don't like the extra space being introduced after the colon.
It's normal practice to not do that.
But in general, this looks a lot better.
next prev parent reply other threads:[~2026-07-07 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 4:17 [PATCH] mm: Standardize printing for pgtable entries Anshuman Khandual
2026-07-07 4:53 ` Matthew Wilcox [this message]
2026-07-07 4:57 ` Anshuman Khandual
2026-07-07 7:08 ` David Hildenbrand (Arm)
2026-07-07 8:58 ` Anshuman Khandual
2026-07-07 9:28 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akyGWZCRbasIX_wY@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=usama.arif@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.