All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Carlos Llamas <cmllamas@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Benno Lossin" <lossin@kernel.org>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Ingo Molnar" <mingo@redhat.com>, "Lyude Paul" <lyude@redhat.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Waiman Long" <longman@redhat.com>,
	"Will Deacon" <will@kernel.org>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 4/5] rust_binder: consolidate transaction failure prints
Date: Tue, 7 Jul 2026 13:18:29 +0000	[thread overview]
Message-ID: <akz8pQ6Ga0J9AmvX@google.com> (raw)
In-Reply-To: <aj8LInp1enuylpRg@google.com>

On Fri, Jun 26, 2026 at 11:28:34PM +0000, Carlos Llamas wrote:
> On Tue, Jun 23, 2026 at 03:38:07PM +0000, Alice Ryhl wrote:
> > +        // We don't yet know the real message size because it depends on the secctx size, so for
> > +        // now write an estimate. When the real value is computed, this estimate is replaced.
> > +        // Writing an estimate here ensures that the approx message size can still be printed if
> > +        // the transaction fails before it is computed exactly.
> > +        info.debug_total_size = info
> > +            .data_size
> > +            .saturating_add(info.offsets_size)
> > +            .saturating_add(info.buffers_size);
> 
> hmm, I'm not so sure about this "estimation". I can see how it might be
> confusing against the "final" size, after secctx and alignment, bla bla.
> I wonder if it would be best to leave this as zero (until this is known)
> or maybe have the "raw" individual values from userspace?

I will print the raw individual values.

Alice

  reply	other threads:[~2026-07-07 13:18 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 15:38 [PATCH 0/5] Rate limited printing for Rust Alice Ryhl
2026-06-23 15:38 ` [PATCH 1/5] rust: sync: move lockdep types to rust/kernel/sync/lockdep.rs Alice Ryhl
2026-06-26 20:26   ` Carlos Llamas
2026-06-30  3:20   ` Boqun Feng
2026-07-01 16:10   ` Gary Guo
2026-06-23 15:38 ` [PATCH 2/5] rust: sync: add const constructor for raw_spinlock_t Alice Ryhl
2026-06-26 20:52   ` Carlos Llamas
2026-07-07 13:12     ` Alice Ryhl
2026-06-30  3:44   ` Boqun Feng
2026-07-07 13:13     ` Alice Ryhl
2026-07-01 16:15   ` Gary Guo
2026-07-07 13:17     ` Alice Ryhl
2026-07-07 13:33       ` Gary Guo
2026-07-07 13:52         ` Alice Ryhl
2026-06-23 15:38 ` [PATCH 3/5] rust: add pr_*_ratelimit! macros for printing Alice Ryhl
2026-06-23 15:55   ` Gary Guo
2026-06-23 19:11     ` Alice Ryhl
2026-06-23 19:53     ` Miguel Ojeda
2026-06-23 20:06       ` Gary Guo
2026-06-23 19:31   ` Miguel Ojeda
2026-06-23 20:05     ` Alice Ryhl
2026-06-26 23:12   ` Carlos Llamas
2026-07-01 16:20   ` Gary Guo
2026-07-01 17:02     ` Alice Ryhl
2026-07-01 17:14       ` Gary Guo
2026-07-02  7:50         ` Alice Ryhl
2026-07-02  6:15   ` Alvin Sun
2026-07-07 13:13     ` Alice Ryhl
2026-06-23 15:38 ` [PATCH 4/5] rust_binder: consolidate transaction failure prints Alice Ryhl
2026-06-26 23:28   ` Carlos Llamas
2026-07-07 13:18     ` Alice Ryhl [this message]
2026-06-23 15:38 ` [PATCH 5/5] rust_binder: use pr_*_ratelimited! for printing Alice Ryhl
2026-06-26 23:34   ` Carlos Llamas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akz8pQ6Ga0J9AmvX@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=cmllamas@google.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=mingo@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=will@kernel.org \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.