From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8EF7284B37 for ; Tue, 7 Jul 2026 09:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783415916; cv=none; b=EV5722ARqtKRheTrADmQjyBF6O8flKxpBqBqf6ppKrKIuyXleRVgwZuFJxf7u5Ta9CqDiuGejoMnpbwgRaX4vVkFYiplitL+LmT2S/ZsmYUXobHDcKDRiYuUAiH84sth/QhcblwFtzlWzdJr3fABsevBB7hBC2Ba67hHyDbtjhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783415916; c=relaxed/simple; bh=rZbkdDIoUWWY0h/BWthTu6t5ezEpvgtoXeGsLDdbfI4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lVijyrnayOXSwiqVnOBWpWCzVS9yuwwnnHv5ZNv+trZKsowjEvN+1zaaAkG8BVZxzDm78COSpBoDhKpPQzMf4Ch0qA8G1+essZXQQcat1rlzEQjz02nsJPTQvOaJhZM8THAqyrkLWaE8X0Auadh2JGr2O6nx+HFAHtfwQ31CB5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=P08mSxJe; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="P08mSxJe" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4728c12ba97so2257030f8f.0 for ; Tue, 07 Jul 2026 02:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783415913; x=1784020713; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dYNl2cbxynAGPyrdG+RJhxlH3SdkwslFx6HQBcedupc=; b=P08mSxJerazOdrtXzY/NfhfOEsa5k/fSzQeWk6vvCeKR2xSa4x2LMFHRvk3StnSzTc m/+/HRuVxBu77qmXpde/CPm/fhvn9s3lDy9PITGbisHia3JwI12/C5e5oNZvlY0pEObg reSV9jENVyLW4tih3UCP7GrBhN1EjqJzOr1vh03H0M2BG4nGMNmr/kyebVVOmnW+G/Mz Tc7vxj81HBHs6rciwN6twJd/uwXP/bJAE+SEtxXfXHoH924Mg1GucjX1w7YfPP2O8nJl BLUfjbwpS1p6sfzo5OjbiqqU9KhVigjK5dOt8rqQ9rJwsVOLlDPcrOiWD8F4PeofE4Tj 4QHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783415913; x=1784020713; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dYNl2cbxynAGPyrdG+RJhxlH3SdkwslFx6HQBcedupc=; b=D2yoMzN5wsKeN3cYl/uNcAVun3vEr/WDiZ9HQvxnzFxoN1qUuZWUWURulmpT5C2GS5 9IkOZZmRgE8MV7Vq8aApgJlfc8dzSAtuOWix98dooXbCdczjWcyUySpkAGNIHk6N7FJC urfkdFCQbhjTfrRTKa+N/EgxHg5sBdfi7M0GYLzx5CRPAHDHON0rbGab6IApMnq8gPOY zBgDOO9PhxXm1Si6kib1fkZCIVNjt5jbOOJco5wGo3XbuCxFNpPnOQ1H2jAUL08Hdtsk aw8T+Vkjq2BrJnzXeavcASMSRVy/ShYIgArDh/HgMnzdvzH7qTOE/TEGC8KvsfQDa15I JH3A== X-Forwarded-Encrypted: i=1; AHgh+Rr1VMR8hGuHmZGV0kcWkqgtknv+kIY4DLGhwUlaEn/zvDxZVxbv7gHnwh2dKgT/61lI3CRML6y/uvNzY3E=@vger.kernel.org X-Gm-Message-State: AOJu0YwyYvWK8KO2rGqdxVwBMaXCioGpABvCdfUPKe6FCzI3ap8zgIBC n9UZB/mHfwp5kP9F0QA2UdrLor2AfjsHYxBzY9Ap8M7+jwm98F5OVIMK2iGXGKRkfVY= X-Gm-Gg: AfdE7cnZu5poOs09vCjormuwsQ4aIECVzyy6vg/XS6/z50T2VVB/pOmFNHnEQWO5xLE CYysuIKugnbduyOiE4VQbNik7v288i4TnYx5mKCQ1ac9zhR9VMCdolQfLmdoWt6ivtgraj9gW1n 8/SvbeHYD5GGR5PotdVts6uBItrtjxTTm+tl6PAlzRWLnk3Nytl/+VLpMvrWtCHIZde6rTNRx/z U9NYjnGP2zM4Ejb4Hwe6l0BzgEgc0x8YjMvmBLAg6BCtNJeyeZBjyQzfOnf0TzAo382XkxgP2/m deucFOimL73xLem6vAA52TOLFWHAcJM0aTmUzzgBaLuIopG9LC9RvWTYsAqiC/fD/n+GzrNjZuM l2j01+5uOdZj1OeNFmaJwgTkMXGPtob4T4fGZFjCjAAt/Xwr21s44rZEeEEosb1KBnpPPlP8sWb AR2D1EBgbrXiCEaQ8= X-Received: by 2002:a05:6000:46d9:b0:47d:ecaa:3f60 with SMTP id ffacd0b85a97d-47decaa4537mr656142f8f.46.1783415913179; Tue, 07 Jul 2026 02:18:33 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d8cdsm34816965f8f.1.2026.07.07.02.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 02:18:32 -0700 (PDT) Date: Tue, 7 Jul 2026 11:18:30 +0200 From: Petr Mladek To: Bradley Morgan Cc: Andrew Morton , Feng Tang , Jinchao Wang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] panic: fix va_list reuse in panic_try_force_cpu() Message-ID: References: <20260705164123.18746-1-include@grrlz.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260705164123.18746-1-include@grrlz.net> On Sun 2026-07-05 16:41:23, Bradley Morgan wrote: > vsnprintf() consumes the caller's va_list. When the redirect fails, > vpanic() reuses it for the panic message, which is undefined > behavior. Use va_copy(). > > Signed-off-by: Bradley Morgan Great catch! The patch looks good to me: Reviewed-by: Petr Mladek Best Regards, Petr