From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E96F6C43458 for ; Tue, 7 Jul 2026 10:17:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gvcbm38Xnz2xm3; Tue, 07 Jul 2026 20:17:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1783419444; cv=none; b=EHWOaYv0wbvawDvNMBSH4kD9Y865M+SYPCvk/e2KTDvqCdcRi6M+XmwfMWYu11NcBYjs/Os36UuE0jsWEgg9ZBkgfOQonwnk4thBa8ncwNFlwzxejc8lTZd7pY8nK/FXh8Ow0nwuh8QJx3ndudjPZKwJwmqraGQXLtWtGDkNfDAEC+vcDrsrZmCUob2ZNxrIDE6uj8ZpIPmZLEGpn2Xmejc6CHVGpyeNK55D4M3J33xfZJI5dp+ncODCQtunU6J5w867ez3Tif4Uu4cCXlTRbKcY/XRHrdlCAscr9GrVPbnK/XA3yj63mBpSbpssgArBwjnZAbtKFeLSh1NFUrGLQg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1783419444; c=relaxed/relaxed; bh=mnyEnVNjUbkl63yjftBd6ZAUslZHuhLMLE5i1q1dbiA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ofp1bxTPTXFwA7FNLpAzflAHTV5LRhgEfW+qV9tyBGhoDTEBEFYUWJAOs+rm4IPiqLoVuVRQ+c9+EI9d1Zr6nb+d3sHqaQ5GPkSGzu3YGeblb824QjVf+wgNP7j5nkivZSQu20mgc2C4W40gyvzLPG5fa1tjd84O6V0jVaNiSEgxCmJtqK30/lDkx31IEvVoheeberLvL7HnDk5/fqKF+/RyQEIoaWa4AvlzXD5GULerSqXXBC3L8JmT9S2jVGSNbMA9dNmubNTjhghdE2Pg9y2ZgllW8kwMuIEIURw/7t5vY0wmFZdExEkJmvLcVhIZFutihhTILaXOkKb/UbmOVg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cGH+4V3q; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cGH+4V3q; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gvcbl4kTrz2xdb for ; Tue, 07 Jul 2026 20:17:23 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 86145419A0; Tue, 7 Jul 2026 10:17:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 122461F000E9; Tue, 7 Jul 2026 10:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783419441; bh=mnyEnVNjUbkl63yjftBd6ZAUslZHuhLMLE5i1q1dbiA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=cGH+4V3qnWn/h2ntR4JOMP1MeFASTJyb/ukIFIKga6vmMPs4hWnZeyozgnP8o9zcj 4aOepXlE5yG0XgvATIbejO38So9984JOSQXxfemV7MrbXTQdbQqJryZ7by0rmLtk6g KbyecrBlOO6RxZhZHoEJHQvN3lfQ+IRVIfllVkFrcFe5jzAzy0lAaGw02N38CG8Xem bIuNc24pIIBeQZLitf75XKOixE/v2BoAd9XaTV+y7NflJFaBKiVOSfh8s3qL1kjbV3 QtnOkHzUZcffKxdXoostqrwbOmOdDgDEYFoMQefdIk5SYi6OuZQQ8BSF6bkbad2igD ZZ2I4X8hc6i0g== Date: Tue, 7 Jul 2026 11:16:56 +0100 From: Lorenzo Stoakes To: Zi Yan Cc: Andrew Morton , Thomas Bogendoerfer , Madhavan Srinivasan , Michael Ellerman , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Lucas Stach , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Peter Griffin , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Clark , Dmitry Baryshkov , Lyude Paul , Danilo Krummrich , Tomi Valkeinen , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Gerd Hoffmann , Dmitry Osipenko , Zack Rusin , Matthew Brost , Thomas Hellstrom , Oleksandr Andrushchenko , Helge Deller , Benjamin LaHaise , Alexander Viro , Christian Brauner , Muchun Song , Oscar Salvador , David Hildenbrand , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , Kees Cook , Jaroslav Kysela , Takashi Iwai , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 03/13] mm: convert __get_unmapped_area() to use vma_flags_t Message-ID: References: X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 06, 2026 at 10:28:24PM -0400, Zi Yan wrote: > On Mon Jun 29, 2026 at 3:25 PM EDT, Lorenzo Stoakes wrote: > > Update __get_unmapped_area() to be parameterised by vma_flags_t rather than > > vm_flags_t as part of the effort to move VMA flags from a system word to a > > bitmap. > > > > We cascade the changes up to arch_get_unmapped_area_topdown() and > > arch_get_unmapped_area(), where, for now, we use vma_flags_to_legacy() in > > order to propagate the VMA flags. > > > > No functional change intended. > > > > Signed-off-by: Lorenzo Stoakes > > --- > > fs/hugetlbfs/inode.c | 3 ++- > > include/linux/huge_mm.h | 10 +++++----- > > include/linux/mm.h | 6 ++++-- > > include/linux/sched/mm.h | 12 ++++++------ > > mm/huge_memory.c | 21 ++++++++++++--------- > > mm/mmap.c | 27 ++++++++++++++------------- > > 6 files changed, 43 insertions(+), 36 deletions(-) > > > > > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > > index 95d0040df584..b301ec90740a 100644 > > --- a/include/linux/sched/mm.h > > +++ b/include/linux/sched/mm.h > > @@ -193,12 +193,12 @@ unsigned long mm_get_unmapped_area(struct file *filp, unsigned long addr, > > unsigned long len, unsigned long pgoff, > > unsigned long flags); > > > > -unsigned long mm_get_unmapped_area_vmflags(struct file *filp, > > - unsigned long addr, > > - unsigned long len, > > - unsigned long pgoff, > > - unsigned long flags, > > - vm_flags_t vm_flags); > > +unsigned long mm_get_unmapped_area_vmaflags(struct file *filp, > > + unsigned long addr, > > + unsigned long len, > > + unsigned long pgoff, > > + unsigned long flags, > > + vma_flags_t vma_flags); > > Want to use two-tab indentation while at it? Yeah sure will fix on respin! > > > > > @@ -812,19 +811,20 @@ arch_get_unmapped_area_topdown(struct file *filp, unsigned long addr, > > } > > #endif > > > > -unsigned long mm_get_unmapped_area_vmflags(struct file *filp, unsigned long addr, > > - unsigned long len, unsigned long pgoff, > > - unsigned long flags, vm_flags_t vm_flags) > > +unsigned long mm_get_unmapped_area_vmaflags(struct file *filp, unsigned long addr, > > + unsigned long len, unsigned long pgoff, > > + unsigned long flags, vma_flags_t vma_flags) > > Ditto. Ack will fix! > > LGTM. > > Reviewed-by: Zi Yan Thanks! > > > -- > Best Regards, > Yan, Zi > Cheers, Lorenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDF60C44502 for ; Tue, 7 Jul 2026 10:17:26 +0000 (UTC) Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60D4410EC57; Tue, 7 Jul 2026 10:17:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="cGH+4V3q"; dkim-atps=neutral Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 05CC646F1A; Tue, 7 Jul 2026 10:02:28 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1783418547; b=NdE7QWG2YYitWNa7eYXkhAv4DEGHWFOA2Zi0Iwx/8l7gUhX4Mwswj/n7jpTzIKZN6wRvJ iIafNv/UghMT8mm3zizKK4r/h9X959L7zkViOlS8xg5k+OdpDWRYWU09v39mv7K7wsYXva1 hXdS3pmkjEiOONxec/kfAImP5wfnGF5tAIVASWH1wEHQw9/LyIV9Gn4aj+1L08e7u9TNsac ci9sIRonOLagaIuUXwVphXxoInjqiVxkmepsZmJqgzxZvCZ9BzoToHbzEdiBCPpaze3OIpG 8RvKN+deKzaGZHfsqBEQEct1Y54kXG23m/tSwYaDyNOE7cP/USxB8xPb0wOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1783418547; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=mnyEnVNjUbkl63yjftBd6ZAUslZHuhLMLE5i1q1dbiA=; b=RQpYn0vEkfHvfoj72fqfrHtduPe8Gpzk6BL0g8z67TvPxwgfQQ1zEKWMiKk9h2YtY+/NY HRSOq5zKzzmrC3OP3atNXwKAyk420jdWdMp0B25Z1stjGUpHnHrvfrfFPehS2H//j4cEanK OBqGfdFPWNNnxiLNRTomao3J9+pcxg/x/9lfX/xcp6GisRC5aj+KzFXtpb6WGRPEPKxH/Ip uqsna6J6DT+lhw24RKjE/Y8bjkhozqWfzRXjlsRyISTbqjVO1M2JIKKPp+QJe5bGtOvaz+j QpFqfqkgwExfdV8PjVc+JO+UDT7ntFfO4n4NgUah4pG2HIECBXv4JVV6u6CQ== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Authentication-Results: mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id 9548F44CA0 for ; Tue, 7 Jul 2026 10:02:24 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE7DF10E479; Tue, 7 Jul 2026 10:17:21 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 86145419A0; Tue, 7 Jul 2026 10:17:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 122461F000E9; Tue, 7 Jul 2026 10:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783419441; bh=mnyEnVNjUbkl63yjftBd6ZAUslZHuhLMLE5i1q1dbiA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=cGH+4V3qnWn/h2ntR4JOMP1MeFASTJyb/ukIFIKga6vmMPs4hWnZeyozgnP8o9zcj 4aOepXlE5yG0XgvATIbejO38So9984JOSQXxfemV7MrbXTQdbQqJryZ7by0rmLtk6g KbyecrBlOO6RxZhZHoEJHQvN3lfQ+IRVIfllVkFrcFe5jzAzy0lAaGw02N38CG8Xem bIuNc24pIIBeQZLitf75XKOixE/v2BoAd9XaTV+y7NflJFaBKiVOSfh8s3qL1kjbV3 QtnOkHzUZcffKxdXoostqrwbOmOdDgDEYFoMQefdIk5SYi6OuZQQ8BSF6bkbad2igD ZZ2I4X8hc6i0g== Date: Tue, 7 Jul 2026 11:16:56 +0100 From: Lorenzo Stoakes To: Zi Yan Subject: Re: [PATCH 03/13] mm: convert __get_unmapped_area() to use vma_flags_t Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Message-ID-Hash: I4AH3S3Q2BMENQXMCHFNW7XMYWG6LSWP X-Message-ID-Hash: I4AH3S3Q2BMENQXMCHFNW7XMYWG6LSWP X-MailFrom: ljs@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Andrew Morton , Thomas Bogendoerfer , Madhavan Srinivasan , Michael Ellerman , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Lucas Stach , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Peter Griffin , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Clark , Dmitry Baryshkov , Danilo Krummrich , Tomi Valkeinen , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Thierry Reding , Mikko Perttunen , Gerd Hoffmann , Dmitry Osipenko , Zack Rusin , Matthew Brost , Thomas Hellstrom , Oleksandr Andrushchenko , Helge Deller , Benjamin LaHaise , Alexander Viro , Christian Brauner , Muchun Song , Oscar Salvador , David Hildenbrand , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , Kees Cook , Jaroslav Kysela , Takashi Iwai , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jul 06, 2026 at 10:28:24PM -0400, Zi Yan wrote: > On Mon Jun 29, 2026 at 3:25 PM EDT, Lorenzo Stoakes wrote: > > Update __get_unmapped_area() to be parameterised by vma_flags_t rather than > > vm_flags_t as part of the effort to move VMA flags from a system word to a > > bitmap. > > > > We cascade the changes up to arch_get_unmapped_area_topdown() and > > arch_get_unmapped_area(), where, for now, we use vma_flags_to_legacy() in > > order to propagate the VMA flags. > > > > No functional change intended. > > > > Signed-off-by: Lorenzo Stoakes > > --- > > fs/hugetlbfs/inode.c | 3 ++- > > include/linux/huge_mm.h | 10 +++++----- > > include/linux/mm.h | 6 ++++-- > > include/linux/sched/mm.h | 12 ++++++------ > > mm/huge_memory.c | 21 ++++++++++++--------- > > mm/mmap.c | 27 ++++++++++++++------------- > > 6 files changed, 43 insertions(+), 36 deletions(-) > > > > > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > > index 95d0040df584..b301ec90740a 100644 > > --- a/include/linux/sched/mm.h > > +++ b/include/linux/sched/mm.h > > @@ -193,12 +193,12 @@ unsigned long mm_get_unmapped_area(struct file *filp, unsigned long addr, > > unsigned long len, unsigned long pgoff, > > unsigned long flags); > > > > -unsigned long mm_get_unmapped_area_vmflags(struct file *filp, > > - unsigned long addr, > > - unsigned long len, > > - unsigned long pgoff, > > - unsigned long flags, > > - vm_flags_t vm_flags); > > +unsigned long mm_get_unmapped_area_vmaflags(struct file *filp, > > + unsigned long addr, > > + unsigned long len, > > + unsigned long pgoff, > > + unsigned long flags, > > + vma_flags_t vma_flags); > > Want to use two-tab indentation while at it? Yeah sure will fix on respin! > > > > > @@ -812,19 +811,20 @@ arch_get_unmapped_area_topdown(struct file *filp, unsigned long addr, > > } > > #endif > > > > -unsigned long mm_get_unmapped_area_vmflags(struct file *filp, unsigned long addr, > > - unsigned long len, unsigned long pgoff, > > - unsigned long flags, vm_flags_t vm_flags) > > +unsigned long mm_get_unmapped_area_vmaflags(struct file *filp, unsigned long addr, > > + unsigned long len, unsigned long pgoff, > > + unsigned long flags, vma_flags_t vma_flags) > > Ditto. Ack will fix! > > LGTM. > > Reviewed-by: Zi Yan Thanks! > > > -- > Best Regards, > Yan, Zi > Cheers, Lorenzo