From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D0A9C43602 for ; Tue, 7 Jul 2026 10:42:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wh3GF-0005co-JL; Tue, 07 Jul 2026 06:42:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wh3GE-0005cg-MI for qemu-devel@nongnu.org; Tue, 07 Jul 2026 06:42:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wh3GD-0003zD-2F for qemu-devel@nongnu.org; Tue, 07 Jul 2026 06:42:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783420960; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r98YB4C2BeOGwKQQkZ9qGnLeHSZfYdwIzU8oi3ChF1E=; b=W6v9TJI2fNpoclDfmQdvM0TYbKJVrNYcrgcwdaJz2hf4r3AycGDftl0BsctPX+eXyE2vGd KHbXiEso4Nt1WpJ+nbSgsKAA6Cr5x0imYmWPPkZpDcaByzBv0hU8INbZdAiGTCYtpAnbWe v/ZabzCOKexa4/N8WiWC2ZwDNlW+2g4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-JQ9mdBl9PKqNBaevoXaivg-1; Tue, 07 Jul 2026 06:42:35 -0400 X-MC-Unique: JQ9mdBl9PKqNBaevoXaivg-1 X-Mimecast-MFC-AGG-ID: JQ9mdBl9PKqNBaevoXaivg_1783420953 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5FF591954B2B; Tue, 7 Jul 2026 10:42:33 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.142]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8494019560A3; Tue, 7 Jul 2026 10:42:29 +0000 (UTC) Date: Tue, 7 Jul 2026 11:42:26 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, Christian Brauner , devel@lists.libvirt.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Peter Krempa , "Dr. David Alan Gilbert" Subject: Re: [PATCH v7 05/35] monitor: minimal conversion of monitors to QOM Message-ID: References: <20260706135824.2623960-1-berrange@redhat.com> <20260706135824.2623960-6-berrange@redhat.com> <87tsqbjnrb.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87tsqbjnrb.fsf@pond.sub.org> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jul 07, 2026 at 08:51:36AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > This introduces abstract QOM type "monitor", with concrete subtypes > > "monitor-hmp" and "monitor-qmp". This is the bare minimum conversion > > of just the type declarations and replacing g_new/g_free with > > object_new/object_unref. > > > > Command line option "-monitor" now creates a "monitor-hmp" object > > "/objects/compat_monitorNNN" in addition to the character device > > "/chardevs/compat_monitorNNN". NNN counts up from zero. > > > > Exception: "-monitor chardev:ID" creates a "monitor-hmp" object > > "/objects/ID", and does not create a character device. > > > > "-qmp" and "-qmp-pretty" work the same, except they create a > > "monitor-qmp" object. > > > > "-mon" now creates either a "monitor-hmp" or "monitor-qmp" object > > "/objects/ID" if the option argument provides an ID, else > > "/objects/compat_monitorNNN". > > > > "-gdbstub" and "-serial mon:..." now create a "monitor-hmp" object > > "/objects/compat_monitorNNN". > > > > Note that the object's name in "/objects/" matches the QemuOpts ID when > > it exists. The only cases where it doesn't exist are "-mon" without ID, > > "-gdbstub" and "-serial mon:". > > > > A future patch will make "monitor-hmp" and "monitor-qmp" work with > > "-object" and "object-add". > > > > Note: there is a slight change in the NNN values assigned. The old > > code would increment the counter for every monitor added, regardless > > of whether it needed a "compat_monitorNNN" ID assignment. Now it is > > only incremented when an automatic ID assigned is needed, from any > > of -mon, -gdbstub or -serial. > > This isn't quite right. The old code increments the counter for every > monitor added with monitor_parse(), i.e. the monitors added with > -monitor, -qmp, -qmp-pretty, and most default monitors. -mon, -serial > mon:..., and -gdbstub don't use monitor_parse(). > > If we don't need a respin (which seems likely), I can amend this to > > Note: there is a slight change in the NNN values assigned. The old > code would increment the counter for every monitor added (except for > -mon, -serial mon:..., -gdbstub), regardless of whether it needed a > "compat_monitorNNN" ID assignment. Now it is only incremented when an > automatic ID assigned is needed (but even for -mon, -serial mon:..., > -gdbstub). Yep, that works for me. > > > Signed-off-by: Daniel P. Berrangé > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|