From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61D6330BF5C for ; Tue, 7 Jul 2026 11:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783423304; cv=none; b=Nn/A4ilUToeArCw5O2qzZGeRZEDujkS5AJmVpIE970JZxls2Qsna518h91ADrY79ssb75yGLD084y9lvHZ2/YOX2hqqhV4Dk9XQ14sHs5/NAFjzq7TiA/aA/R9pcln/qfx53OfrJkBx7eoYYIRmEbEfZNGt8um+VR8QzLF0RrIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783423304; c=relaxed/simple; bh=mDMxMZKNQyxwhs1DiwrmQuriySIu1AzXmWZTflMGqkE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=InZC1NK9aUk+TTwP2CpO9+2CblqCKhkJCBoZjE4zcu74rktrWD9XgqZB9qELC37r7vnqda8Sz6WjdN/dF9Bp2VP3yvW5QJpPV6OD9z98Rdv6KlOOErT3mEBWR7xEJhiw3TEMPxlruLux5e/xY3XWKImRLxQ3M1zfhQ5xuMwtmP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QoJWtZnR; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QoJWtZnR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783423302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tMn/hsB0mgCxJNe/0lxL8HOxGFEbu8GwWhd8M7FGHRI=; b=QoJWtZnRlNoGW5HO5vpCMVLbssx+GhYYDt25dlUEcZnMeF0FUD95l42Hr2tG7ixmoqd7MY Kn3cNLozHrBUkyEXIXWqPnYGX2r+fkhvSp6H10xAtlnxrJ7Qhk5uOP31yT2Rg+es/hlXuS UksswnCvhNbvohRKd3aaeMqWy2le+3s= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-PPwWFibXOdGaVWSaIlkngA-1; Tue, 07 Jul 2026 07:21:39 -0400 X-MC-Unique: PPwWFibXOdGaVWSaIlkngA-1 X-Mimecast-MFC-AGG-ID: PPwWFibXOdGaVWSaIlkngA_1783423297 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B02C6180AC57; Tue, 7 Jul 2026 11:21:36 +0000 (UTC) Received: from fedora (unknown [10.44.33.83]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 7105B1955F76; Tue, 7 Jul 2026 11:21:31 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 7 Jul 2026 13:21:36 +0200 (CEST) Date: Tue, 7 Jul 2026 13:21:30 +0200 From: Oleg Nesterov To: "Eric W. Biederman" Cc: Andrew Morton , Andy Lutomirski , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org, Linus Torvalds , Christian Brauner Subject: Re: [PATCH 01/14] signal: Generalize posixtimer_queue_sigqueue into enqueue_signal Message-ID: References: <87o6gx9rc4.fsf@email.froward.int.ebiederm.org> <877bnh7tnf.fsf@email.froward.int.ebiederm.org> <877bnb4uyw.fsf_-_@email.froward.int.ebiederm.org> <871pdj4uxa.fsf_-_@email.froward.int.ebiederm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871pdj4uxa.fsf_-_@email.froward.int.ebiederm.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 07/03, Eric W. Biederman wrote: > > +static void enqueue_signal(struct task_struct *t, enum pid_type type, > + int sig, struct sigqueue *q) > +{ > + struct signal_struct *signal = t->signal; > + struct sigpending *pending = (type != PIDTYPE_PID) ? > + &signal->shared_pending : &t->pending; > + > + signalfd_notify(t, sig); > + if (q) { > + list_add_tail(&q->list, &pending->list); > + } > + sigaddset(&pending->signal, sig); > + complete_signal(sig, t, type); > +} Hmm... __send_signal_locked() doesn't initialize the local "struct sigqueue *q", and if ((sig == SIGKILL) || (t->flags & PF_KTHREAD)) goto out_set; will pass it to enqueue_signal(). Oleg.