All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Helen Koike <koike@igalia.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-dev@igalia.com
Subject: Re: [PATCH] ext4: skip i_extra_isize expansion during inode eviction
Date: Tue, 21 Jul 2026 10:28:54 -0400	[thread overview]
Message-ID: <al-B7eVSy_jtDBgD@mit.edu> (raw)
In-Reply-To: <20260715175253.2171303-1-koike@igalia.com>

On Wed, Jul 15, 2026 at 02:52:25PM -0500, Helen Koike wrote:
> __ext4_mark_inode_dirty may be called from the eviction/free path (via
> ext4_truncate ??? ext4_ext_truncate ??? mark_inode_dirty), which may call
> ext4_try_to_expand_extra_isize() that could create a new EA inode,
> wasting work that will be immediately discarded.
> 
> Skip the expansion when the inode is transitioning to freed.
> 
> Signed-off-by: Helen Koike <koike@igalia.com>

This issue has been addressed via the patch[1] "ext4: set
EXT4_STATE_NO_EXPAND in ext4_evict_inode".

[1] https://patch.msgid.link/20260623061903.2148767-2-yun.zhou@windriver.com

Thanks,

						- Ted

      parent reply	other threads:[~2026-07-21 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 17:52 [PATCH] ext4: skip i_extra_isize expansion during inode eviction Helen Koike
2026-07-16 19:59 ` Andreas Dilger
2026-07-21 14:28 ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=al-B7eVSy_jtDBgD@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=kernel-dev@igalia.com \
    --cc=koike@igalia.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.