All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: Zhao Liu <zhao1.liu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	 Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,  "H . Peter Anvin" <hpa@zytor.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Chao Gao <chao.gao@intel.com>,  Xudong Hao <xudong.hao@intel.com>
Subject: Re: [PATCH 2/4] KVM: x86: Advertise AMX CPUIDs in subleaf 0x1E.0x1 to userspace
Date: Tue, 21 Jul 2026 11:52:10 -0700	[thread overview]
Message-ID: <al-_2k1Zuw6N4cvj@google.com> (raw)
In-Reply-To: <CALMp9eRqaxhmADqOOWW9h4yctg5MxfU9AdL5C8MpFNzKJm-Big@mail.gmail.com>

On Wed, Jul 15, 2026, Jim Mattson wrote:
> On Sat, Jan 24, 2026 at 11:25 PM Zhao Liu <zhao1.liu@intel.com> wrote:
> >
> > > Unless someone feels *very* strongly about the "mirror" terminology, I'm going to
> > > use ALIAS instead of MIRROR when applying, to match KVM's existing terminology for
> > > the 8000_0001.EDX => 1.EDX aliases.
> > >
> > > /*
> > >  * Intel-defined sub-features, CPUID level 0x0000001E:1 (EAX).  Note, several
> > >  * of the bits are aliases to features of the same name that are enumerated via
> > >  * various CPUID.0x7 sub-leafs.
> > >  */
> > > #define X86_FEATURE_AMX_INT8_ALIAS    KVM_X86_FEATURE(CPUID_1E_1_EAX, 0)
> > > #define X86_FEATURE_AMX_BF16_ALIAS    KVM_X86_FEATURE(CPUID_1E_1_EAX, 1)
> > > #define X86_FEATURE_AMX_COMPLEX_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 2)
> > > #define X86_FEATURE_AMX_FP16_ALIAS    KVM_X86_FEATURE(CPUID_1E_1_EAX, 3)
> >
> > LGTM, yes, ALIAS sounds better than MIRROR.
> 
> Our friendly AI reviewer asks: given that these are aliases, shouldn't
> they be hidden from the guest if the features they alias to are hidden
> (e.g. clearcpuid=amx_int8).

Eh, clearcpuid taints the kernel and is quite firmly "experts only" functionality.
And practically speaking, clearing things like amx_int8 can't work because it won't
hide the feature from host userspace doing raw CPUID.

  reply	other threads:[~2026-07-21 18:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20  5:07 [PATCH 0/4] KVM: x86: Advertise new instruction CPUIDs for Intel Diamond Rapids Zhao Liu
2025-11-20  5:07 ` [PATCH 1/4] KVM: x86: Advertise MOVRS CPUID to userspace Zhao Liu
2026-01-23 18:03   ` Sean Christopherson
2025-11-20  5:07 ` [PATCH 2/4] KVM: x86: Advertise AMX CPUIDs in subleaf 0x1E.0x1 " Zhao Liu
2026-01-23  6:02   ` Xiaoyao Li
2026-01-23 17:53     ` Sean Christopherson
2026-01-23 17:55   ` Sean Christopherson
2026-01-25  7:51     ` Zhao Liu
2026-07-15 23:08       ` Jim Mattson
2026-07-21 18:52         ` Sean Christopherson [this message]
2026-01-23 18:06   ` Sean Christopherson
2026-01-25  7:54     ` Zhao Liu
2025-11-20  5:07 ` [PATCH 3/4] KVM: x86: Advertise AVX10.2 CPUID " Zhao Liu
2025-11-20  5:07 ` [PATCH 4/4] KVM: x86: Advertise AVX10_VNNI_INT " Zhao Liu
2025-12-18 17:54 ` [PATCH 0/4] KVM: x86: Advertise new instruction CPUIDs for Intel Diamond Rapids Paolo Bonzini
2026-01-21  1:40   ` Zhao Liu
2026-01-23  6:03 ` Xiaoyao Li
2026-02-04  0:10 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=al-_2k1Zuw6N4cvj@google.com \
    --to=seanjc@google.com \
    --cc=bp@alien8.de \
    --cc=chao.gao@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xudong.hao@intel.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.