From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DFAD403EB9 for ; Tue, 21 Jul 2026 17:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784655151; cv=none; b=MBLab4h7/F/cUM1j1ammodRe9RxP6nafQBmSXL8XZNURNrn8N0wr+Eh8tAvbh0dI32uEGkfH3evgN6SISrpypgNBCT4XcI3UQhRJN959G74ym2uQWkSotA7A3RTK/ajx0i42FF1aE+SyqPWq70cB482Q2A1NisIHsR0GFoQalYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784655151; c=relaxed/simple; bh=aVpiG3/6AQU4J4sz7TfW/VXq0s4/oapZ8+o8qIk6dmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cMYRVhYm6VAChJzXGWCwO/h5MYGRde+Z/E90e7Zv57jusQPBXqYE/lFl1UwbJBdRk3CotoWLr8vNPWJgi3G7NkyowZ/GMCE1RO4RwwcJtoTsgnXuhv8ZrUJj6MIrTd4In7ZwmHPkfmVGrSLHRrt8oCyJ69V73HXcxXUFzbzpy7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O8issR7L; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O8issR7L" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49555a0e68bso16136405e9.2 for ; Tue, 21 Jul 2026 10:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784655148; x=1785259948; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=oarivZVG6jdDaREUGN57J4bwMGePVEaf7kTu1kPSfvQ=; b=O8issR7LzP9WwU7mZ8/PXQENTFSgmaiB4VsXIelsOFjB+nVWh++/wwEoPWnMH/G2hI J/fMha0j4fU2q/2p4uChCdr3j4LHX5Cw9aq3A/X8xi0+sPAnoPaT95rpjwaCTtUB1grP fEoys24lK4YiWrgScJBl0RmUJvqcqUl8/QB4zOTtkP428sHOB+aVj3w5JATgioBc8dUL LZo2JWpAW6XPMJCcWodWFlcWCKZGHOWOc1sqgzdbQVCM68UFCLsUiiaHYo7F75Lps5xM /sv7VO6Sh0XWiYSXO2Ro0MEIcO3ctfCTOivzoiTqZUv6iJJj4j8RmAn0U3693m/dkNpz b6Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784655148; x=1785259948; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oarivZVG6jdDaREUGN57J4bwMGePVEaf7kTu1kPSfvQ=; b=U2OSeBqYnJfMVrrp8q3qGFWO9aT2ngU1NIb2Q0TQgD6LQwmAmFKbbSgCCY5yHctTB2 xkWYp0eOiCakk1KPT2M3f3ZNgLQqBoyx6HSW58WDf2UcCawLhsilAwFD03oJTGf++Ofp kGbmp/suGe4Z3285t6ZnW7HVja/3C+SyL4kI70jtjAig9o4lhENjW8utVjUGlBm9VoEf KURVKtx6GdXhjyj9FUF4CXvOf3uIodlv//YB2e71OeSwvVskvO6mGMeS4D5ulv1jGGOw TPeN6X2PY5y5krn0SlkRTmHXXa7pi/shEf8Ohn0E6W+CACCCdPZmq+82KxXTx0fufrGz 7Feg== X-Forwarded-Encrypted: i=1; AHgh+Rofj65tDj0vl6prRY75Gn5nS/ShQ1997Mdasl9FB3dyDvTMAUQB2t0LKz5pIrIaYaoyZR7BNWthhtGyvbg=@vger.kernel.org X-Gm-Message-State: AOJu0YyoQRqc9+Szbx4025CM72ylMVZTHjLRY1cu1VOtSHOj7L4c8x4o owJgWqkPghd5jXkIWRjMTTWm3uUqYyN2shXYWxPbqzFSCiM4sK1zqFjub7BoYg== X-Gm-Gg: AfdE7cmJoMz9gEEt9TnYCXQKSk0tbk7JpfuoHm2N5HfW0XuDWl2lhSOdKuBThUlHN6r F2XXmm2HQMjx+xk6cEF/FjL2QClHa6ZgNNYYvoq/IM+IVW6174BBIaczUXKULp024NvBsFHmvI0 caARHAN8DnHKpu30aFVzGw5ocHpcCzHeAoY66henS/O3y2PV9BX1moXdBqVPVIuAQLvgIS/+z9Q 97czlvHKdhugKkq610fXjHF2kBRh48LT5eC7usYUy9kkkinBALeEGj6DyqZ5ocxe6zcS04Pgp7m j2PQomsRjDhY6xwAEHMnbLC8Rrqy5Nopby3q+QebnVaoLQ7kqi8Q2p889+4mkG/5xDJibBI56wN OC9rvs2PwsPDp3l+VGF3XkecN4gTPVZ5jmLnzX9pEj49oVkyXNGTU0JS4oKPnyEM8jDO0vo3k2r NC2FYvZAhc9cc/JxMLzp4osz/c+euHYGFQ5veA8w== X-Received: by 2002:a05:600c:49aa:b0:495:5943:b76c with SMTP id 5b1f17b1804b1-4955943b9dfmr94309475e9.34.1784655148196; Tue, 21 Jul 2026 10:32:28 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956ab41a15sm2475905e9.3.2026.07.21.10.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 10:32:27 -0700 (PDT) Date: Tue, 21 Jul 2026 20:32:26 +0300 From: Michail Tatas To: Doug Anderson Cc: michael@amarulasolutions.com, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] drm/panel: ilitek-ili9805: Use dsi_multi in init Message-ID: References: <20260719190358.438699-1-michail.tatas@gmail.com> <20260719190358.438699-3-michail.tatas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello, Thanks a lot for the review Neil and Doug, I appreciate the feedback > > +static void gpm1780a0_init(struct mipi_dsi_multi_context *ctx) > > +{ > > + mipi_dsi_dcs_write_seq_multi(ctx, ILI9805_EXTCMD_CMD_SET_ENABLE_REG, ILI9805_SETEXTC_PARAMETER1, > > + ILI9805_SETEXTC_PARAMETER2, ILI9805_SETEXTC_PARAMETER3); > > nit: the indentation of the 2nd line of your two-line > mipi_dsi_dcs_write_seq_multi() seems off. checkpatch.sh --strict > yells: > > CHECK: Alignment should match open parenthesis > > Strict mode also yells about a few lines that are over 100 characters. > I'm not quite as picky about that, but it would be nic eto fix too... > > > + mipi_dsi_msleep(ctx, 100); > > + mipi_dsi_dcs_write_seq_multi(ctx, 0xFD, 0x0F, 0x10, 0x44, 0x00); > > + mipi_dsi_msleep(ctx, 100); > > + mipi_dsi_dcs_write_seq_multi(ctx, 0xf8, 0x18, 0x02, 0x02, 0x18, 0x02, 0x02, 0x30, 0x00, > > + 0x00, 0x30, 0x00, 0x00, 0x30, 0x00, 0x00); > > Since you're touching these lines anyway, can you also fix these > functions to consistently use lower case hex instead of (mostly) > uppercase hex? AKA 0xfd rather than 0xFD. > > > Other than above nits, this looks great to me. I have sent a new version with these changes Regards, Michail