From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C6939A058 for ; Mon, 20 Jul 2026 10:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543499; cv=none; b=uOMPBiFMKdi1hve806+DkRpggkjUIEGMFPvoyIVRMaUz1Euqvrtbyjs59UtTTGnxKc6NdNrGsMd89lqGLrM6peeXVQNZH5leqAAuLj30Zq1MTq+FKrLHyJupyZ7GRnVl6tckv2KDqMiy+Auie7QVn4aGdkUc+/Nx9/03W8zpK6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543499; c=relaxed/simple; bh=46GnOF9F7vwDTg+XTnRNtlrnkTCbaGp+EJ46x5F+NZw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ryb46l4EHaIitR8KZDe/JyUKG42rYbnhEo+6Q+pzFA1IwCz7jAkf704bBt8GG+A3gGj/yq6btiSeC2Iln46wNd1MbenIsKgtgV6AXO4p3gs+PzDyCo+Owxzjde0jeA3EYRXMnp/SWinhMw88lihm/UyWdRT80zxIlT0h59FrnWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=io2yY9hv; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="io2yY9hv" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493f75f7172so77992695e9.1 for ; Mon, 20 Jul 2026 03:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784543494; x=1785148294; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9uvOwHXcOnUd6y6AJIJqeUq1M3Za1gq6UKyse48eUhM=; b=io2yY9hvECPme4dZbULWWe4zZszs4OIRDWbAZAfQFtHwty6WUSjsitsB5hfuBNn77q 5s0z2wDY+bAFGhVkXeOW55TUuK7Pfsdk4/ShK5IzW1L/t++PZohu66xeE6wooEoJ0O+R rzVy1zfkzgCHgacJRk04P2GNn6Ra8xMeifqNjiXTWeaZTCUcJicWVo1DeKA9uMa5kVg1 7LWYMDtRpFHaxY65amuoFg8Rdp8r5zOriXHOADlHrVo0uNpPxU7grkJ3w/kRZQ7ox8pL 81pWvPk11mLyN3izZiZRfPJez7vm8GObFi9UH6B+Ysu+PwCokv+ztP8hYl0ukx1yphwe jFeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784543494; x=1785148294; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9uvOwHXcOnUd6y6AJIJqeUq1M3Za1gq6UKyse48eUhM=; b=ChaHUjQKtYbe9vlJR1bGAMXEZl26CwxsuBoVC8og2tk76MElJzyNaA4meNxiVay2hF 1Bp4PRcB/hB+vOR1t2wF5WXmb6JUSq33b+eyi3VYQmbNNwRxLe9zSiRx8M9w/EeCHe53 x981IFMc75ISf4cXGFNoCTbvNc47yzhIdFqZebXKDgp4hG0ZYhMUfJcosPKxebIiqHtr xNCvuGXMgCIE5CW1qnqIK22l041kbnuw5FkuvfryRz23kqFGzooOjjOzJW6fiY/OpOvy sPOOQigdwv51/ZCjnQozSBjeIksUBPPr9gRs3/aOhije323tyxksLfU9yLiaEGIFdkUn KUXg== X-Gm-Message-State: AOJu0YxpRCoEkgY6e9ixR6qKn+/9taEYXoB5N25uLn7bwuoeLuiVsF4D 6fc8Jg6OJ3SH+yaP/v0HOlzEIxUWgCOdWGrXcxmJ1Y/GDPIY/2FWrOenQpG7TDWuMBY= X-Gm-Gg: AfdE7cmsY8UNOPYh/DFF35ertrwCtnsY848fo73Jt8oMOF4sHHTvwc6+FhGsJrmoeVL hQ24FJ+az0ick1VuMSO75NMHnZnGZvo9jG4Kw9jKqEBr/HoPmyRyPKZi5BPxKqKvSV+rOshTZuR zzsb6STRsnybAXcndYJhUqR3p17sEFcADaHDjyCYgHab9+4zV2Go4euzAvRLDiOn7g6H859X6ic coh5pcsnWyXhOSBfr85tRuI5uhJwGtIaVnWykVrPYzXGRmf/3cn8whXqFZQmJsnROU3w3JigxVP IMQzlGFfw4Xtmv7BwWhsBzcmQJOHlGHEGXMW0G69y40Rg9BevKqlq6E9wUI85b2wwtlkiVcUGrz 8tQCm9Tmf/H+vb0z/SSrbMGQEpQWdJOZXmbXoskCcYYyR9vv0PycwR/pYFf1RS+5JwDRW7N5kT/ ztq4Ujlqx6cWqtUG19eJu4uPyvJR0K5m1pNnw7ZcDBSxCcB3+qJyChRqA8Xn8mDVdG+5DWziVg6 7BO X-Received: by 2002:a05:600c:c84:b0:495:4811:d71c with SMTP id 5b1f17b1804b1-4954a3ed4bamr143137025e9.13.1784543494185; Mon, 20 Jul 2026 03:31:34 -0700 (PDT) Received: from localhost (p200300f65f47db048587886ecb5b26b2.dip0.t-ipconnect.de. [2003:f6:5f47:db04:8587:886e:cb5b:26b2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f63e65644sm27485955f8f.16.2026.07.20.03.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 03:31:33 -0700 (PDT) Date: Mon, 20 Jul 2026 12:31:31 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Hugo Villeneuve Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port() Message-ID: References: <20260720080812.1223096-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mrc3nztluxg2ig5y" Content-Disposition: inline In-Reply-To: <20260720080812.1223096-2-u.kleine-koenig@baylibre.com> --mrc3nztluxg2ig5y Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port() MIME-Version: 1.0 On Mon, Jul 20, 2026 at 10:08:12AM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > With CONFIG_SERIAL_8250_HUB6 configured as module > (CONFIG_SERIAL_8250_HUB6=3Dm) the cpp symbol CONFIG_SERIAL_8250_HUB6 isn't > defined (only CONFIG_SERIAL_8250_HUB6_MODULE is). In this case > hub6_match_port() is defined in drivers/tty/serial/8250/8250.h as static > inline and in drivers/tty/serial/8250/8250_hub6.c as normal function. >=20 > Use IS_ENABLED() to also handle the modular case correctly. >=20 > Fixes: 3d406299d882 ("serial: 8250_hub6: add hub6_match_port()") > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > --- > drivers/tty/serial/8250/8250.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/825= 0.h > index 9d1068d0489d..fb9a7117d145 100644 > --- a/drivers/tty/serial/8250/8250.h > +++ b/drivers/tty/serial/8250/8250.h > @@ -334,7 +334,7 @@ int fintek_8250_probe(struct uart_8250_port *uart); > static inline int fintek_8250_probe(struct uart_8250_port *uart) { retur= n 0; } > #endif > =20 > -#ifdef CONFIG_SERIAL_8250_HUB6 > +#if IS_ENABLED(CONFIG_SERIAL_8250_HUB6) > bool hub6_match_port(const struct uart_port *port1, const struct uart_po= rt *port2); > #else > static inline bool hub6_match_port(const struct uart_port *port1, const = struct uart_port *port2) >=20 > base-commit: 0718283ab28bc3907e10b61a6b4be6fefa1cbb2f There is an earlier fix already at https://lore.kernel.org/linux-serial/20260715153707.4181828-1-hugo@hugovil.= com/ It's a bit different, but essentially equivalent. So please stick to that older patch. Best regards Uwe --mrc3nztluxg2ig5y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpd+QAACgkQj4D7WH0S /k4ZnAgAoOlWWhpOIbmErmLUuhDTeuEjNUEUy553tY37nqI+JkPsiM9OfhvElr8x coEF6TwEs3+SEu9q967xCDBlC7TA080BptprdLHTbm1mMMMrJHElyjg+AF8X0abX Xt0JMW6YFV6bNe7KIjaqsapQS7k/4ubpoVb/2dtlDIhNpu4CUwYZLZ5yk+/5ypau 5BIsSLvhjy49f2iFB7vjGWE6Q0VhTnm1uiU84pIZYqFTY8NbO4AzeoNx6qsUqgEe hZ6VvPszFIDvueCGBmE9TZzNd66kupXxz2s91tZF97VVP0AW4XH5iziCPSDfSZ9v y+1CogkN+7g5jnlycXoPvuVYsUbKlA== =Nw1k -----END PGP SIGNATURE----- --mrc3nztluxg2ig5y--