From: Luis Henriques <luis@igalia.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Amir Goldstein <amir73il@gmail.com>,
fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
Matt Harvey <mharvey@jumptrading.com>,
kernel-dev@igalia.com, Seth Forshee <sforshee@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH] fuse: cache POSIX ACLs when setting them
Date: Mon, 20 Jul 2026 09:16:35 +0100 [thread overview]
Message-ID: <al3ZY2TYw9C6WwB7@igalia.com> (raw)
In-Reply-To: <CAJfpegtdZhWLpc12z3khfKyfRK0kAEu1u3j2QtD+_JL4qaRO0A@mail.gmail.com>
On Fri, Jul 17, 2026 at 04:51:47PM +0200, Miklos Szeredi wrote:
> On Fri, 17 Jul 2026 at 16:43, Amir Goldstein <amir73il@gmail.com> wrote:
>
> > unlikely to matter if we do cache on setacl or unlikely to matter
> > if we don't cache?
>
> Unlikely to matter that we don't cache setacl, because it should be a
> rare operation, so an additional roundtrip just shouldn't make any
> difference to performance.
>
> Changing this does carry a small risk of regressions.
Right, I've tried to document this behaviour already [1], as I wasn't sure
this patch would be OK -- I understand why it makes sense to have this extra
hop into user-space and it makes sense to drop this patch.
[1] https://lore.kernel.org/all/20260708131122.2917-2-luis@igalia.com
Cheers,
--
Luis
prev parent reply other threads:[~2026-07-20 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 11:00 [PATCH] fuse: cache POSIX ACLs when setting them Luis Henriques
2026-07-01 11:39 ` Horst Birthelmer
2026-07-01 11:41 ` Amir Goldstein
2026-07-01 11:47 ` Horst Birthelmer
2026-07-01 12:24 ` Luis Henriques
2026-07-01 22:58 ` Amir Goldstein
2026-07-02 8:56 ` Luis Henriques
2026-07-17 13:57 ` Miklos Szeredi
2026-07-17 14:43 ` Amir Goldstein
2026-07-17 14:51 ` Miklos Szeredi
2026-07-20 8:16 ` Luis Henriques [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al3ZY2TYw9C6WwB7@igalia.com \
--to=luis@igalia.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=fuse-devel@lists.linux.dev \
--cc=jlayton@kernel.org \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mharvey@jumptrading.com \
--cc=miklos@szeredi.hu \
--cc=sforshee@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.