From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65583C44520 for ; Mon, 20 Jul 2026 11:34:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C523E10E18C; Mon, 20 Jul 2026 11:34:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=baylibre.com header.i=@baylibre.com header.b="EWaeLO3n"; dkim-atps=neutral Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13CDD10E191 for ; Mon, 20 Jul 2026 11:34:56 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47f703a9d05so802841f8f.0 for ; Mon, 20 Jul 2026 04:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784547294; x=1785152094; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=5MEo8NUpZhRQI5j1rCBJtgFOMjhyLVipMDpM+l3a/38=; b=EWaeLO3nna+D5L9LsREjPOugThtVZrVwIVsTZHuzSzanTo/rVtcW7kKjN66rWnRPar 1cBbd7YZoaicbQfmAx21upRLBlXJv4qZmCLzWGASDqSmC79kTB3HQcSrDaplkWdPmmBN gDFoPfL87yic6lBBNMzN1Kh3/esxrqv1Vw8dcCNZBYH6PHgPhVRGuX8/+273IoR2Nr73 IoRkjvf/h+1r9Cki+UReG1eW0BjEXkK0x24zA9a0rYScZ5G64p9WGGdObLnBZTfyGS9T AEVWkHKgXifTYu4lEa86EhlFwWJuygzWWHr0IFcpvf2zxrdTFRaw2KB53cqYCR9FI+DD /h5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784547294; x=1785152094; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5MEo8NUpZhRQI5j1rCBJtgFOMjhyLVipMDpM+l3a/38=; b=RdsWXKUGiXWAJfbSEzTwCFu3Neh0J0cCfdc/FBHoqWzULO35PzLzospANRQt+Kiri5 Tx2qMptmTXYYDYIgFQbL75dpPbXEn/Y2Ed1dOCNz9hj5BG6kwenxRn0OZ2BwX8eKYbva /+LfUdmKexzyyOw59DFkeDBTrkHldk/vBVoMXRriRm7ybXf9bqFtNyfVV1tDt9UJH9rd wThEYfa3gOYQ1nDbqgTbZm2HRe9drjhSijAYXGHRw0uUk4TI5GIcUIKR7HXdEpAtlDdK AtBdoIuOqTFTIRVZbBXW9u508XwHzjaWxpWh8IwH5MhMd+M/HzvqnpEGMIAig+z+5uoU yY0A== X-Forwarded-Encrypted: i=1; AHgh+RqosOPPDbnajnrTBagVVfrevll39oK0H5cjVPo62onBCzC5Asy5HSlWIqVy4guDsMvVIyGseC6MgBE=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yy1SyHhGcZ9WtPaiDiJs1CPEpaEBm5yIOf1rVMtv8KfRRFujlbd XOzuMzjwW7ZKJtv838JCPpkR3peSqFQiGAm7/PNXQ5hxJ4EyyFKkrYrg1+scSh1IPzE= X-Gm-Gg: AR+sD11hQrP7SmC/HTSddaRDdWU4vDdZOoqm+AkT1z3h1plmottzGL2SS7hLOkTALQ+ NJl5pR1ipjJMWJeZUuiKqUXoKPzURYWWBh+NFSoLwDS/4A7/Bv5ONiHrg1MhpK+z0O2rdpopS0S RMoQHy3nhl8F9/THX1HNygWkc2MxYV4uuCcwBDYkpVoQ6dbt+rwyoAgl7V5zcz8SDY3ZD50XW4T DCK6865xvsgZcreN9bBwi/5i07RTD82shxij7URpqHu9zJ3BzPdZcDLC65t4UcGVZBefNfvongl oaxLtDtBoDlLlqon14MkHlDA8bznav13IY1hKkZK5miG5cZH1YnkumSVByHUQvdLHfU6Iq8lJoG lLZ2bFqVLB3dF/6tb1bE2IaL39DPNeqecXFBi4gcHEaEqvRRBoH2b1QKklhWJCUL70P0Zsa9jNv xez8oEAmXUcZUacYoaIdaHY8usPSZakneeW2Susu3J8meTxhBp6CWGEff65vXlIp0RWQ== X-Received: by 2002:a05:6000:4b14:b0:47e:aa3f:f822 with SMTP id ffacd0b85a97d-47f6233be35mr16319068f8f.53.1784547294401; Mon, 20 Jul 2026 04:34:54 -0700 (PDT) Received: from localhost (p200300f65f47db048587886ecb5b26b2.dip0.t-ipconnect.de. [2003:f6:5f47:db04:8587:886e:cb5b:26b2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f6fa848fcsm19241724f8f.0.2026.07.20.04.34.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 04:34:53 -0700 (PDT) Date: Mon, 20 Jul 2026 13:34:52 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Alex Deucher , Christian =?utf-8?B?S8O2bmln?= Cc: Markus Schneider-Pargmann , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/amdgpu: Consistently define pci_device_ids using named initializers Message-ID: References: <20260429171644.8406-2-u.kleine-koenig@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rjr5ydhtag5cemwi" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --rjr5ydhtag5cemwi Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm/amdgpu: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello, On Wed, Jun 10, 2026 at 06:55:09PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > On Wed, Apr 29, 2026 at 07:16:44PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > ... and PCI device helpers. > >=20 > > The struct pci_device_id array of supported device was initialized > > by list expressions. This isn't easily readable if you're not into PCI. > >=20 > > Use PCI_DEVICE* helper macros and named initializers which is more > > explicit and thus easier to parse. Also skip explicit assignments of 0 > > (which the compiler then takes care of). > >=20 > > The secret plan is to make struct pci_device_id::driver_data an > > anonymous union (similar to > > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylib= re.com/) > > and that requires named initializers. But it's also a nice cleanup on > > its own. > >=20 > > This change doesn't introduce changes to the compiled pci_device_id > > array. Tested on x86 and arm64. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) >=20 > Gentil ping! I'd like to work on changing pci_device_id, but that > requires that this patch hits mainline first ... Would it help to resend? Did I fail to Cc: someone to get this patch into some tracking? Best regards Uwe --rjr5ydhtag5cemwi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpeB9kACgkQj4D7WH0S /k5Z6Af9Gq2QxbDClvePDJgb1S0Btc3vPaIme+YCro+lTIwcbZZ1CHZKRKdrSSda ajvSbtUH6ZT2Dj/grtQNq0MAgwRXNJjpEtNUVhuKa/g/O9G6HseGT/JLZ6gpbE3V FvjvZLvFYE0cC5UBxPsfpJZWSZ4b6HHG2yaqgGbKG01UIuW0bu2ElQXzN8z9FLqW QjR8PEoBgfPQZA2TUqtRQ0tjbMFA+FEpFWkuPSmdDFVR4OPZUbAIltzKfYnCcmch cEnAnx/m12gfxUS1cBy7m120C/Ko+q4UszZPzbPrivbFGby8/E52ee+rVAuzdcCE TPAmP3ysP/Olxv7n3XJ9LHGrkhVHuQ== =E0ji -----END PGP SIGNATURE----- --rjr5ydhtag5cemwi--