From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF2BAC44515 for ; Mon, 20 Jul 2026 14:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=er4n0qDD/O1Me/HOLDhmUzlxp0aJRRyThcWku3QUVlo=; b=GQT0U8Qs/k6iQD 2L7hrqS1WyM+fikrIseomr9USwkrqepxskvk+EusBztmslVrqW/08sw55IaIIoTA1I27W7FESVUNs T3z45dwtRtC32qV0OGjnlsuT53CpsSdT6GCkFFXHvIEWF3oiiGU6HT7SOA/fdHZxx424n5X2QiU7D R0I6mLVuqR3isBSz+XjDBKHnOczUkwbg+5aQXOWfhrjyp40UziQZNmU/Gcd5O9n/7vKyskBmzO4E0 glgERvBYWxzDntcRTV4QOD//GBk5Llds1MNGiaMGch3oIlYEN2HtY3e18izMzgXYlLK4vP6rOHVCJ ZpU2fhU0HygEdopIL3jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlp1J-00000006yZ2-1fv9; Mon, 20 Jul 2026 14:31:01 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlp1G-00000006yX7-0Mk0 for linux-phy@lists.infradead.org; Mon, 20 Jul 2026 14:30:59 +0000 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDqMes2745293 for ; Mon, 20 Jul 2026 14:30:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=YBR264JovU6bj+n5 ZZIsKkJr0jbtad6tDlASI5VZ571TIzXlD18SdiUlw0eRlLgkNWo8wUq1ecZHt/SL roQqX1miRKH/kQF+RWnlswyXD4lyvsfT23CmbUMIn9a3+d5PuefpLWD3KxIGMKfj 1hxZ6o87eclAgutH21e5/jvkTChbdOzYYXJVg12KtlQxe6sClkeaDrcys2M1XMdY QCM8BxXtqpnI9KpoaEwgbUtymxkn1kY+bHGPfo9senkEYdjXOHIcpujDFG5Fdx72 CQ8mncISntyGT8YRZwKueoNmQ5TxrqeSNpYSvriJObMvfaKRgkjgtT598DiVsBks hXKOCA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhk2f8pnk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:30:56 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1b4d961dso73117791cf.1 for ; Mon, 20 Jul 2026 07:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784557856; x=1785162656; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=HsBT7G+RuA99gNHclVRZAb4FI8FZwQu2nM0Lxb2YqeeRdwkX0OUqfiH46+AFo2+clx K7rLRJ/uiob8vU10ZLrOajyBlzxrL90JPYd78H/pcrdZghAoy+bwbkSTPCn/JRgPbVA6 h1mU1/Q9seunge+UduEpqCi4vbYzRDa1WzxD/J1O60DZSIP/YRmcdek2vquq7iuvu2ZH k89ZIYJjB14R8dfx1xdyEyat0FyBF+ISywEfxwcPSfeuLk5vx83Ed6HJgfPDM/iFNZ8S N5vqaY+GjqIMroDO0AbnJ3RN94fVyizfYOeBaC6FmI6YghLm0/XxjAi0W77FqOfWzkD/ ObRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784557856; x=1785162656; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=N0WnMgvf6XbmQwl0LipKzzXuZy/X62cWVvS5P+jk3e6wcfGsbwiY8q77e4dv82erlb t0rDBxvJc14efjF2SXJWOcOVwJ1j8AyKczHlsISBbYgGS6lLkjvxact4R8gO6Zfw4ZNe iVtgBTRwMAGZjVpmaQo/asXj9mJdZaRIP60xDLk8KkoCpuFgu3xNlWInNFcN2G1pWsxl e7wTAM6f56dyW65uJMs/VRcVxWShpyHYbR6T5pEZVQh/wiukwprNlSoGBLYyKtESqojz pMOcISBXCcwHmbXek96uNZtVI7bb+RgT9SaVf4eMGa6OLH7MvSPkndEYmiHbkA9TUYV1 Y9ow== X-Forwarded-Encrypted: i=1; AHgh+RqaUSUwf5GK6Mw5PyMyG4K4haw5YUq1FpRYv/hrovGGXygIW4xrrZGOUwyIQ8WXnv7i3o4o0o4bWBg=@lists.infradead.org X-Gm-Message-State: AOJu0YwicP6sstpAuquEgqag9iQVhKMFoQecXy8w+6EIXFsapkx6hL4r 0SKr0TM60F0QWtgGxPlfJxpEVqfUd2ND0M59JLNu3SEmDVDmhMKmscbrASGR12gPQRjy1wxf6QV pewCSesG3W1M+eFJwadVf3RV0dpVyC001a6/y1zZuLVaBRo+1InBskLJgosZKYmMBVLnp X-Gm-Gg: AfdE7clCmMw6Fk1W38FC8s2NiUKvUakRrP17n5ZwAx4DvWBKWLtEnrQ/hfh4htLMJYi RTSsRRkuku2YUtjVmy0Eaf8otil98I3J4D6RyRl4QKFEonpSOXmHdMhhPoYG4wxiOpU5aKAMyMT cvvCHgCpshpAi6yLTJN1KtN88DoUallgNladWNgsEkORN113P/oFhv4uf/QF9rWfZHS1vBa1fu4 oq/Yr2IlsW0N71ob0OGbk0MEF2zkX+CwQ9KhLY0BvwAJjIilurZXy2eUFTXKP1zaAqd6NwftGz4 y6dhsrkQ0w+FhM82b3fz9u9PWjc0JlHKstLpFesheUHbDiKf+9dT1pco5mEGNtjG5Hegvr05vNs S3ozTEI1BJsmkVGBnX0Hi7PlDNjY7KC/Ahs9VTtZzfFwaH8m6rI1NeBvg+BUBTjCigC9l3BxiGY LlhgLeMmBF1iZvRA== X-Received: by 2002:a05:622a:1b23:b0:516:d83d:b28 with SMTP id d75a77b69052e-51fbf8ba886mr173938101cf.17.1784557856142; Mon, 20 Jul 2026 07:30:56 -0700 (PDT) X-Received: by 2002:a05:622a:1b23:b0:516:d83d:b28 with SMTP id d75a77b69052e-51fbf8ba886mr173936141cf.17.1784557853828; Mon, 20 Jul 2026 07:30:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291d98301sm2365292e87.25.2026.07.20.07.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:30:51 -0700 (PDT) Date: Mon, 20 Jul 2026 17:30:48 +0300 From: Dmitry Baryshkov To: Cristian Ciocaltea Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Niederpr=FCm?= , Simon Wright Subject: Re: [PATCH v4 7/8] phy: rockchip: samsung-hdptx: Simplify GRF access with FIELD_PREP_WM16() Message-ID: References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-7-ce5e1d456cda@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260612-hdptx-clk-fixes-v4-7-ce5e1d456cda@collabora.com> X-Proofpoint-ORIG-GUID: Ws2KVZ-KMG5g59RAeC7yrvP75_irJ8-4 X-Authority-Analysis: v=2.4 cv=X8xi7mTe c=1 sm=1 tr=0 ts=6a5e3120 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=EPngckNM3keSbOuRnKsA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=zZCYzV9kfG8A:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2MSBTYWx0ZWRfX1UzuYg8GkyEe nWBUK4fvJfvCxeptaJnNXFIaEObDTdwdHc2lOAkJcCovGazRu7qkIoCrFpSNW5sOkWzKkf3h2vC mgN3yffVi3sXW/YzRlMpaTEqR9jbB5o= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2MSBTYWx0ZWRfXyW2F3zlUv90p SZKk3smGPxbCsnM7zssejyEHj9rMFEZZHNrwm6s0j0TeWbUrZQ3PROFhoGQFy6jB4Yl+m5bYuT2 F151bp1r0Hz+napyZX99cfxU8GTMfSoyfRveFFjZ3ESwpDGWhfHWPyia7fIxMadMxkvbXfQQ5h+ q7bGLIoBVUC/53qwkbp/ZApK+yB0emN3BvKWlnQoNBE8qZNLhwmZ7jhrIvpLJgpVcxVy/rJjJei okRNOzqdHqd1eUbiiwVRcXV+EWt7YG0ke+e0hba1EGKIgknHcIWKMbipNOCln0ILLvBQgGEx9Cn RLNRLsyUNPAKdHIN7nsMcD82ucp8cVbP/HZJvyVGJv7lhUilx7eyCn9/VETStP+4gV/Z7gRLBsv 2zQmnaLoNR+fgQnb9EYhx6s6h7o/WmTtI3lIWGWQbleu8jbJfOw3Nv3oQ3ZVnvXPqCQJhyhfZ6K 4eeBIIpnBkfxA+2fQXA== X-Proofpoint-GUID: Ws2KVZ-KMG5g59RAeC7yrvP75_irJ8-4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200161 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_073058_231276_13F856BF X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Jun 12, 2026 at 02:45:26AM +0300, Cristian Ciocaltea wrote: > The 16 most significant bits of the general-purpose register (GRF) are > used as a write-enable mask for the remaining 16 bits. > = > Make use of the recently introduced FIELD_PREP_WM16() macro to avoid > open-coding the bit shift operations and improve code readability. > = > Tested-by: Thomas Niederpr=FCm > Tested-by: Simon Wright > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 52 +++++++++++------= ------ > 1 file changed, 25 insertions(+), 27 deletions(-) > = Reviewed-by: Dmitry Baryshkov -- = With best wishes Dmitry -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 440F142A7AC for ; Mon, 20 Jul 2026 14:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557859; cv=none; b=Lc+WmwNOyIpIyIx+wXw+s+lEQUeHioCyDfVCid9cBKwn0lczju8KpgZ23ZHBOwukqhRIlsBtTnO7GgEd40pGnOssPLrnHMUJSb31LEDFjdutWt3Ioc0Z1PEWWarmP6PLFbLwjeAfeu4FXi+6kVMuNm5QsGgZ0XOyN57le0aouzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557859; c=relaxed/simple; bh=n5eX4JpYNdq6IMU/Pyy05xo11EDiVsQ0ctxPhKSdqI8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sgtS59y453LrBq3bTJsE0/ugvgnAyroJCfRedVFGw3MTZU/UPG7jDGyDpTldQxl/2QrbNA2fMf+Pd2IUDZQzTC6NHdOkDKutOZqNfkMPKPvGWFD0u4Xid0C7iO5rAaxDxMJ2j5mGKJ6YXDlzT2I4TVcyHA6Kow5/ggdVckaaOcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YBR264Jo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UuXPP3lK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YBR264Jo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UuXPP3lK" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDr5vg2965749 for ; Mon, 20 Jul 2026 14:30:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=YBR264JovU6bj+n5 ZZIsKkJr0jbtad6tDlASI5VZ571TIzXlD18SdiUlw0eRlLgkNWo8wUq1ecZHt/SL roQqX1miRKH/kQF+RWnlswyXD4lyvsfT23CmbUMIn9a3+d5PuefpLWD3KxIGMKfj 1hxZ6o87eclAgutH21e5/jvkTChbdOzYYXJVg12KtlQxe6sClkeaDrcys2M1XMdY QCM8BxXtqpnI9KpoaEwgbUtymxkn1kY+bHGPfo9senkEYdjXOHIcpujDFG5Fdx72 CQ8mncISntyGT8YRZwKueoNmQ5TxrqeSNpYSvriJObMvfaKRgkjgtT598DiVsBks hXKOCA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhfdchshb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:30:57 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c2af04aeeso7148141cf.0 for ; Mon, 20 Jul 2026 07:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784557856; x=1785162656; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=UuXPP3lKBMf8++h8t7WPVr2OHjQGROUFwsEXGzrjdx+LWzPQXpxJ5SaSxzWHSnDcUn io3McZFw1NCNsyIamdtTVhmpj+OlnBXZwzw8uLAd1O8UIGRcrCZLTidGfIjfwvmxjDjN y1v887Kmz+rejzw1kzJ3RynhXARyjaoqzNvLoGcnkXizaK1NQxPWnNjnbDp9vyDik7c8 4/nVdGBGrhn/YNhVVUVaaJRBUgCSEDXedk2EIPtVxO4If4ADhFuw4PjK/Gp6TvVzEVP8 cXwa+p76dBlfdpya3/06RvsukdalMeAtNC4xp40t+5zCkXqlfEoW6wkn+i2eEdm4qxeP sCZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784557856; x=1785162656; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=OY7oHZWaFjQ9FuLVCUQHRUVWAIZ7DUFiUAkloq9Yw0AEXvyYDdlTRF8/pthCouQPQW s69/MzAnwAGQmPxrkg8voOYRLbvOlH7MD8SSdi3QL6EyoEX9pXQB/6OPPlnd7weZilOI Mu0G1uc8C9LhS/KoYKpi9aagOM0kdsSnQnIHXza0/ZR7DJ2GL5K9cqvWbon9FOXJ35R2 ovvBNqfYh6pQ0+/nIopahyYOUA963kYGr4TlH5f+heglF8h4YMWC79U6N8jx0udYPCjH hT09eeFlvdnMZGHE7jfuQupDvL0c6+9+XAlq9sRq1pl73C1vU/18zkdYG0uHHiiz9Bb2 2zEA== X-Forwarded-Encrypted: i=1; AHgh+Ror4fbiiPH+t/xnYAglzSbOqSn3Uxf1qQBxPwpbZOCU7vrk2wvzlPMbSzYkw1lXFnRNDdFewMwxB0nT2ww=@vger.kernel.org X-Gm-Message-State: AOJu0YxfNzFgB6vR5HJLd/dkZHR6Yao27hLOZUbkK7z89UkzRqYQntiF meGMR0l9UNTioOTVlP2ZqVkp5xgUa6LoIrPzgOHza43TgKILD7iz1fxQiiKqFaY2xGFDpwL/1qI bF+o/ZToTPMQssbKpwsFtXqUbdEzltV/feyfnaiTinhHFdXzF6ZDldoAoJZoy9ljXe+U= X-Gm-Gg: AfdE7cm4MGvLUwEhHuAJz8lwbmozTiw5DdNFwcxUUES9Ez5xTjbYsRUT346f+HKYyoU B/TfHi9e1S6q1u4AtDkXU/vY40l+i7asUJwE+r2Nw8sgaRIFUdRZu5kX1iX9iDmSlQ1ghyHpU1S Y/L7q/ddE6c7VnETkq9q80Mzbt5Vd3jfDrVDmhDwDIJ3vCcamOqdPRURdjlhYGhBGbLvT/QjFY8 MnsKqLRiJtOJ9twpvaV9hx+JaWSgWSMRd0jYE7DNk7NvnDEUawFKZ5YeKrkwmOe5VdY9QA6OtAc rgdn0oGWC6PZ71RQUMSgpudFkDnOzKFV2rD1iV8k7TojyMxmDgvvK4EdCtH4gfoZMGEpOVGSMFg MneePNDb7nqhbnqhThRlSOeKM5ISt0o+xQrgpaVCwlx0hD0zteXFB5hmIOAQM9i7xbMHSYJXxck eySWzO/gdSR4up1Q== X-Received: by 2002:a05:622a:1b23:b0:516:d83d:b28 with SMTP id d75a77b69052e-51fbf8ba886mr173938131cf.17.1784557856150; Mon, 20 Jul 2026 07:30:56 -0700 (PDT) X-Received: by 2002:a05:622a:1b23:b0:516:d83d:b28 with SMTP id d75a77b69052e-51fbf8ba886mr173936141cf.17.1784557853828; Mon, 20 Jul 2026 07:30:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291d98301sm2365292e87.25.2026.07.20.07.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:30:51 -0700 (PDT) Date: Mon, 20 Jul 2026 17:30:48 +0300 From: Dmitry Baryshkov To: Cristian Ciocaltea Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Niederpr=FCm?= , Simon Wright Subject: Re: [PATCH v4 7/8] phy: rockchip: samsung-hdptx: Simplify GRF access with FIELD_PREP_WM16() Message-ID: References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-7-ce5e1d456cda@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260612-hdptx-clk-fixes-v4-7-ce5e1d456cda@collabora.com> X-Proofpoint-ORIG-GUID: gGEcZ2jCcK2uOkaH79NqSajynI3i7tdS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2MSBTYWx0ZWRfX+Ob70fuHP69I HT4BpbayKbDZpE7qSNSf0zphcgCF5xYgn3IZ7Z2yB+UjjzhKOVSrKM0GqvcP9FekB/J1Ibuuhss eSZ3R2rH+7cc5iK5Yr0Y18MCCjuiIcdsZggAqOkduDUq+3bFx692A9K6DqlzfBtFcGj/WpqrYO7 H58qSETcRpgcR+PBEP/byFCBzrXY0PhYmnZgNzbfOWdmciRSVsmQ7L0Vx+fPqJSM5e++xyUu+/k zN6/DilVLyiKDaMeQ+uzyOT5VGfhyY8t2C1yVbk9R/Z9JQsUKjVVhI9gIm8LcqkUFv0BLK9Xadd kSUrW0Vukn4tcYGF3MOLoXjvNuqGP5KTR9TIRmLKWgmDA8kA8jzpu2mBklafyrSQs6KgCjJ0iOV N9K3LWyQEOm2DtS9sB+Qe/8FCJteqoJGWLGalWfyEYzxnXgfCGBPP9FBpsdyBTTORAJqgQff/nS 3o9f0TcXN0TP6p9/sXg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2MSBTYWx0ZWRfX75SDB/uwR3NW eswESTs/2Wy4yt/v885wrEmmrGy8S8L3ap43nEhAu4svbXHwjuagNfNpOAODCCciFpuqFXAO7p+ qeXF9Lvvefwd8lhf4lFYrPrC6zsq82A= X-Proofpoint-GUID: gGEcZ2jCcK2uOkaH79NqSajynI3i7tdS X-Authority-Analysis: v=2.4 cv=bv58wkai c=1 sm=1 tr=0 ts=6a5e3121 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=EPngckNM3keSbOuRnKsA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=zZCYzV9kfG8A:10 a=kacYvNCVWA4VmyqE58fU:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200161 On Fri, Jun 12, 2026 at 02:45:26AM +0300, Cristian Ciocaltea wrote: > The 16 most significant bits of the general-purpose register (GRF) are > used as a write-enable mask for the remaining 16 bits. > > Make use of the recently introduced FIELD_PREP_WM16() macro to avoid > open-coding the bit shift operations and improve code readability. > > Tested-by: Thomas Niederprüm > Tested-by: Simon Wright > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 52 +++++++++++------------ > 1 file changed, 25 insertions(+), 27 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABC4AC4452A for ; Mon, 20 Jul 2026 14:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cC94N5ARlyL0KdJD82Rrhq6mQLtquolXmHUdzG2h59I=; b=U03IthubN7+b+A PAynYLIU/krawfnr1YYVTxf0x5tjgMMtSTx7VLQbzxHKYo5qPhS0YcC3ZQRO+tUrEoRWcSZc13Wrj rhGqkBhFVQRRCNwutiodH2wZyZOhIUPHrqsbol4+sUfTko93e21UkA5rGBZbJym4c808QF0CtCmD+ 1rpbtq32l9iVKpLW7LhjBsugidkWXaiBdfObABoPmVIsWmWdAfn4hG4RtbGj6MTUlLBCcaE8At1uw YDSth8oC+fMJ+W32Q3CU4czImmkH3Y8KvTUaqUqwbWa0QAtzVYiYHseDeDvM0j5b7WysIVBQ958vp RCnHX1m/JBZyb07MJhlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlp1I-00000006yYR-10nb; Mon, 20 Jul 2026 14:31:00 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlp1F-00000006yXB-3MkA for linux-rockchip@lists.infradead.org; Mon, 20 Jul 2026 14:30:58 +0000 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDr5vf2965749 for ; Mon, 20 Jul 2026 14:30:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=YBR264JovU6bj+n5 ZZIsKkJr0jbtad6tDlASI5VZ571TIzXlD18SdiUlw0eRlLgkNWo8wUq1ecZHt/SL roQqX1miRKH/kQF+RWnlswyXD4lyvsfT23CmbUMIn9a3+d5PuefpLWD3KxIGMKfj 1hxZ6o87eclAgutH21e5/jvkTChbdOzYYXJVg12KtlQxe6sClkeaDrcys2M1XMdY QCM8BxXtqpnI9KpoaEwgbUtymxkn1kY+bHGPfo9senkEYdjXOHIcpujDFG5Fdx72 CQ8mncISntyGT8YRZwKueoNmQ5TxrqeSNpYSvriJObMvfaKRgkjgtT598DiVsBks hXKOCA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhfdchsha-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:30:57 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c1b4d961dso73117781cf.1 for ; Mon, 20 Jul 2026 07:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784557856; x=1785162656; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=HsBT7G+RuA99gNHclVRZAb4FI8FZwQu2nM0Lxb2YqeeRdwkX0OUqfiH46+AFo2+clx K7rLRJ/uiob8vU10ZLrOajyBlzxrL90JPYd78H/pcrdZghAoy+bwbkSTPCn/JRgPbVA6 h1mU1/Q9seunge+UduEpqCi4vbYzRDa1WzxD/J1O60DZSIP/YRmcdek2vquq7iuvu2ZH k89ZIYJjB14R8dfx1xdyEyat0FyBF+ISywEfxwcPSfeuLk5vx83Ed6HJgfPDM/iFNZ8S N5vqaY+GjqIMroDO0AbnJ3RN94fVyizfYOeBaC6FmI6YghLm0/XxjAi0W77FqOfWzkD/ ObRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784557856; x=1785162656; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Wi8nWkpM4EPvZH/Ahz97hAxk1CRSJa/tutJQGZBgZsY=; b=SHq5yYD7QbCCrJrigBsLnMGv5+XqYaI50KhKxIoiptvazszPuhyFuoaDlm5WODeHeN mP8XSGuyf/jlzsvOooXv3b4ABiKP/qgQeGqVACAG3FY0i/IhaCqCllneYHQ1UH0Vwktx JpoXnOz0jhwd/IznBblglRvpyXAtx6xS17LYAAFiE13ClkSULl5wcSvR5eh/Es3Hk2I7 XUB1ADv3dp8gNgh4wJRoCrLFr29vnxnMnBmFALX/ojsZaROzWMpQe2MOUWCl8Ba9xYMk UZ2tGhye74GN4Ec6EAGczC3FnhRMX1JtZ2ncqK7sluxvKhgSSrBSAmM1LSheXUTbhMOt Zu4w== X-Forwarded-Encrypted: i=1; AHgh+Rol05lAS5qAL9jGDjWRUug3LNLUuFj23y7wSQax0zHWF/XCUg+EmDW4aioAV+9UlobzaymMXCsLX+y6NPVRpw==@lists.infradead.org X-Gm-Message-State: AOJu0YyeBqoFarfdtle0EMesMPQowMeMSAjbw45c9ydXJhCMaiIRep4r lUxfxFUtKiGSZVdw5cMHWRpJPPYmsPfC4uOs15pxDEhhmXiwK3BDPmHLgpeTCWoa9yAeZOZ2jAD PzZS0t90LnwkzwKbqIdAMXs3LhDLnaPEHTzXV+79WGZhhvM8I2aZaojEZx1p6YRA3nejOTMiRGR g= X-Gm-Gg: AfdE7cmsKBBNC2sI/bQdTmfNbuApRObBY69FacOsAvvII5VeJgNXGaQtKJm0hgvieLh IBceFkFuujekAea6AMiwH+mBNYJCcBQA12EGnsUJnGDPdTD7htEaq9QsAdTjkKE4lgQTAYSIyoL YF4oLmbY5kIENon0uzQjVCiQtltV3a2Psfg+eVtrTCebDmjnKW422BWQHZ9KXVsfCcbMqAijlLH UBDT06MRz/cA+2IenKRBv3biYNdvmPW0ey70JIQ4AGWa2Z4QAaL09G1ae6NlSbMknfsgGYTDpPJ buXZGIK+b07p+fTQguLOFFEYbcHEHyveE7aa3CxOyjUabzXqMYUPcB9qPZs5k/cLky22bOYUPkb rTT74+AF/rFIsqElcG5sU6ANJ/SUAx1+DvJxI3rSPBxmDLtt7kmIUUCKeuvNxSvCfUPHiD/51yX c++DeluaJotS1uQw== X-Received: by 2002:a05:622a:1b23:b0:516:d83d:b28 with SMTP id d75a77b69052e-51fbf8ba886mr173938171cf.17.1784557856154; Mon, 20 Jul 2026 07:30:56 -0700 (PDT) X-Received: by 2002:a05:622a:1b23:b0:516:d83d:b28 with SMTP id d75a77b69052e-51fbf8ba886mr173936141cf.17.1784557853828; Mon, 20 Jul 2026 07:30:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291d98301sm2365292e87.25.2026.07.20.07.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:30:51 -0700 (PDT) Date: Mon, 20 Jul 2026 17:30:48 +0300 From: Dmitry Baryshkov To: Cristian Ciocaltea Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Niederpr=FCm?= , Simon Wright Subject: Re: [PATCH v4 7/8] phy: rockchip: samsung-hdptx: Simplify GRF access with FIELD_PREP_WM16() Message-ID: References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-7-ce5e1d456cda@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260612-hdptx-clk-fixes-v4-7-ce5e1d456cda@collabora.com> X-Proofpoint-ORIG-GUID: qgbUiR7ee-nwQohoy5u6tqgxPRiYCC8a X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2MSBTYWx0ZWRfXzDXzG3GiKaP8 9ad22uA9emArustcNtGy7DCDTgjXe8Qalfzhn43zN/egUKXPKcI19e4rQapK+Hr2rJA5RBsM5Yp yFFrgkp7rO/GURC9VC7JIeZ1ZEK4JSxOkNO5nCIns8g8Ui6dKuG21nDWQ+6ceeoVi3XoD+dS8dm kZ/Cg1RCJDfR3rvCc2mDsny/q8/a9k+IDDFFz5YktXNSId8MjRIa9WB9cOXwQA/B+JvxAVSRkkm aqI8EHOujbP3BNH3aKLq5Pm0h182HA4yXzvqoTJDn12Pr08H1alN6m2/i1lElAOMWW0zBf3cicC 8KCv6uCs1EnChzeIch9VrDUoJ9XZg0lUlO5cI+v/a19FtCIQ3W8NIX/sRBHUmFGKz51NC4U2yD4 cBngZigkbTR8VHKZR/uIeYWB6cey/bHBKEgIvJB7f688wte+ZUgsw6BPqVsr8rF/u+r5I4jhJ9/ cAZfKMRUlUxfr83itqg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2MSBTYWx0ZWRfX9ru4n6pKuv+n bKNZyDp5BamSvjQxS21T2wTtiW/OJnTlyjsLMX8BAD9r4uWF9Ic1FyX7p5mkuwpnq4SPvUEYaNn lUa0KDwQETMyTprT8ZnKWL+Ft6+cRgw= X-Proofpoint-GUID: qgbUiR7ee-nwQohoy5u6tqgxPRiYCC8a X-Authority-Analysis: v=2.4 cv=bv58wkai c=1 sm=1 tr=0 ts=6a5e3121 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=EPngckNM3keSbOuRnKsA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=zZCYzV9kfG8A:10 a=a_PwQJl-kcHnX1M80qC6:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200161 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_073057_844619_E894FC8C X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Jun 12, 2026 at 02:45:26AM +0300, Cristian Ciocaltea wrote: > The 16 most significant bits of the general-purpose register (GRF) are > used as a write-enable mask for the remaining 16 bits. > = > Make use of the recently introduced FIELD_PREP_WM16() macro to avoid > open-coding the bit shift operations and improve code readability. > = > Tested-by: Thomas Niederpr=FCm > Tested-by: Simon Wright > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 52 +++++++++++------= ------ > 1 file changed, 25 insertions(+), 27 deletions(-) > = Reviewed-by: Dmitry Baryshkov -- = With best wishes Dmitry _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip