From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01B54C44515 for ; Mon, 20 Jul 2026 14:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0eLC7A3Js8ps8foQ/BEb6su9CynDkfaJDa8jQFswbTs=; b=rOzv42WdIITbnk h050D+rJulQ4YWu/NpExK/H5GEHjKiKrHP8r87fQae9XyRQmuqtpINvBT8TPCDkEyMDekkWA5/Gl8 AkD/V1PJmdLQleGCMo3qMRvnEaKDb33kPPjlMEyw96Mlyovvmy2uQxIQ7AaFN9DRyfsrxa+tvIt4q 5OG73APKiJbNDq8Y1hf/YMIEvxIUlkvdEnEkmTvjds6vGdXqvgIYr3AF+lwpEqYUjDtYG0Ie3mP+2 NIxOVOXKjeC9o5vV2jtZ9tQMYf/uBMjzaDcuCULEFwYaLOA7OELDudmC+BoXCogB2GsnqCdqU8gvj tiqfIz+gdvVjSo/XXmOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlp2D-00000006yms-2zNv; Mon, 20 Jul 2026 14:31:57 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlp2A-00000006ykW-2cxj for linux-phy@lists.infradead.org; Mon, 20 Jul 2026 14:31:56 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDqw5D2852834 for ; Mon, 20 Jul 2026 14:31:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=V6pIIHGM0seBO1ic X+CnzBsSRPjH6xnkOdQ8UYvGh7BixZbGKrh6OlPhq6FqhL+vnOb1c2lcrUgDPS9w zwatz+mM7TqLOSkr0toRwd2gav64hHxjynCDuNuDYBCFRk90zp18qayTF/rYCaG9 QbvQ8dcxtE14Hvtupigb90qF3O0+405yVAxoATSzvs4cUFol3N2SP4d6yQeHo0bI mEHk3fRH1vi7V3at+4H1UrTu10l5wZU1VCmiSHY8vJI6gGGCpnKWP3Wg03QW0d5v ZcDfOMlkGj5ioqm0BuTU/Zy4VA7zMZ6jqj1vsn9doC5yLBiE45u5DgP0Qj4Iyacd /5Bgbg== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhhgys4fk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:31:53 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-96966afe3d1so9686462241.1 for ; Mon, 20 Jul 2026 07:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784557913; x=1785162713; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=JUvITvhe7aL/PjPrS5A9ZNse5wEaMwnaOokTZSM8Dr/V8qIjTYPg+cuBRotaL8ESe3 3aP6f0251XnaB1w9j/xNWIrDo0Id0Tc/vwfXU5+neAbmkmHQ4NlgNHESTlO3VQ+mg/vd dBDEPxOxWayVC8B3tlhw2jz360OldbwCr4c5Beh5qsZYUOgN7VzppdjMGLaeehFoKQyZ pW2cNRmGP6qg/S5OVe/Z+k6OaQkBmXsXPaJEJA7TfmCm4IJVDqIFG3Wx8WR6zO7k0E3c B4bXusJMHUA2g4ydAxY6a10JOMRK6ZHmYsnuyi4hMu2SunhKE5C0AoxkE4q+ObwPw7ZF 7YzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784557913; x=1785162713; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=KU3eUNlRgY6ON3T/74BglrGwMm8byB1hLDxuk74GPz5sMcvUmP4LK84tRe/xeRZysD CNOOMFxBf3giIJZxqyMJRfKputbIjeHnGr0qbhWrOXefvTiWBrhTeXXhieCnHtHIQ+SR 0VavzoCwUVzlUgOxEhvPr2OodGbZK3NwQWk8/1Qrf+8OMFHq3b0CLzTaIScloRpQj3Pn vIdGBCeDL8iJlqKMW7bn7luWO7x8eCPQhzIbRJHrXcPKuwD9kQhlzMyVIpv2ZjOrZfOY afDXIl1egNZ8jFd/ZnOqIfyJzQjPvbBHKs7DEA5rpw8IOaaJVF6qg8qlL+m4JZIj2hJJ gu0g== X-Forwarded-Encrypted: i=1; AHgh+Ro08I19Gv+ogrMnOEa18PAnH7eFTmPQJ7HqsKTmhlgGIuOvrBUL5ih41S5cyvXIowpfMnp9K54ej8w=@lists.infradead.org X-Gm-Message-State: AOJu0YyYirWL88N2QMGEFAw6Oj/N7MrScKet08Xb7FVfJwI0f0fwIfZa 7/NCR5csR3xS5xqvuQEbyN8Yze2bBz+rWmM2ZkIwX+90naD0yVuemIFZOMVmYKpWEq2Ccuw4POv Z11uYXpEhl2LOmxctLTjvXiICheC5E6NxxL6roDA2hhy49K5N0HlMznYu+mhl9/7A/QtT X-Gm-Gg: AfdE7cn/l+1y1P/pu7DX+De1dMGNdCXEpWhDlhUr/sUsDLzQrBBH5Um/PxCaBCYVONa BGTGvJkWTqCtsXFW4u1te11jphCS039MNVNoj2nBIMmfHyQhG2wxozB6b4hw5oP8ZUmMztfTxxn bPV+H3k0In1znb0pCTjq7kvDWAZHNfrNM6EEsUNfHRbJp7is0GayPCIrDP6eA9fdMOaTGhRtrNt 66oQ0vAPRZunPI6xFOFHqiEU+YoweLbUyviHtX/Ccc5IM24kUELe90plnvrgGU33ObO+3qB6ARP fIcHRV3VO7CmsJNkgI1nKdl0aNJGgYWMNXBg53cNqRhlP3DaH/WITPRKQPNnvlp3ceCQNvMNi7u +qHF78o5qA7Pvrv6ym/VsXVij1GTDSHN7bya4u4YqdP0A/vD9itorqUu4meYPMOD9oM9DCR0Yux ar/N5THRjyDrc6HA== X-Received: by 2002:a05:6102:3e12:b0:744:cb59:d6e4 with SMTP id ada2fe7eead31-7475373fae7mr4340467137.22.1784557912694; Mon, 20 Jul 2026 07:31:52 -0700 (PDT) X-Received: by 2002:a05:6102:3e12:b0:744:cb59:d6e4 with SMTP id ada2fe7eead31-7475373fae7mr4340446137.22.1784557912168; Mon, 20 Jul 2026 07:31:52 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291e297ecsm2333411e87.82.2026.07.20.07.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:31:50 -0700 (PDT) Date: Mon, 20 Jul 2026 17:31:49 +0300 From: Dmitry Baryshkov To: Cristian Ciocaltea Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Niederpr=FCm?= , Simon Wright Subject: Re: [PATCH v4 8/8] phy: rockchip: samsung-hdptx: Consistently use bitfield macros Message-ID: References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2MiBTYWx0ZWRfX3qT/1JLM4whr GXvTI/R9dXPjME0IcitaspzbaxRdCiHZQNucdJ5vaxfa3buQ1Ht4iW3Bg6WCSPohP4X4TQoIjWq rsPT21i8Peh9vQnKyYcr6XzEadsphJE= X-Authority-Analysis: v=2.4 cv=LK9WhpW9 c=1 sm=1 tr=0 ts=6a5e3159 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=I81vlq0Cx9dIN7l1fGsA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=o1xkdb1NAhiiM49bd1HK:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-ORIG-GUID: xwKu9lVxfXdUTtOELJTUuIZ-8V2aepVP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2MiBTYWx0ZWRfXyjwlbsplJDUX d1HIshJ6e/0pAg+zriocQnjy/TKjJ+fFlz/Tbh0uTlxGqnlwezRi2jkPClzUiacJtBNIUPr91kq fLBZs/9uh9/NPQNVpk+wKFQDY2FMYqCCoFm8pHT5g8yRJH/U0Lyv1fDxvWSKt8rQziKl2vEPSKH cIPkvZ1aeh/VCyGTvUb3/ra4ihyob4zT9Z7x0E1/kqAbyvFBF0PI8JqHppzryu1HEYZ4J4iiToE Ved7TQNQc2ygRhC+3hVvfWCpJa7F4WN0mdHuLaAdRTPW1UmVouNvgC6EgowRc/FyV6WsAjXyGrW GJUc9D497EK/YEjCkBvXeu83SgrNSKjl6Kh8sj4nPeNiltr+4h4LYfcB5wriIED6LskRL0RyrII zIL4dJU/s/CuX7L4TNUJA2zKQNQUQVFcibpWJJ5JogN+9TbYa/nFK6yRCYZW4mm/nVtNdvZThp2 rxnrWvSyhQuDKD6eZvw== X-Proofpoint-GUID: xwKu9lVxfXdUTtOELJTUuIZ-8V2aepVP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200162 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_073154_792427_A964EE68 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Jun 12, 2026 at 02:45:27AM +0300, Cristian Ciocaltea wrote: > Make the code more robust and improve readability by using the available > bitfield macros (e.g. FIELD_PREP, FIELD_GET) whenever possible, instead > of open coding the related bit operations. > = > Tested-by: Thomas Niederpr=FCm > Tested-by: Simon Wright > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 30 +++++++++++++++--= ------ > 1 file changed, 20 insertions(+), 10 deletions(-) > = Reviewed-by: Dmitry Baryshkov -- = With best wishes Dmitry -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B79429824 for ; Mon, 20 Jul 2026 14:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557916; cv=none; b=ZPNL9lLWbALBB/9Z7BtrqI5XqWpVyhARKHFyrKttY3nc87/t4F0SvTMKo8K7DNaxGt2paUHWc7uOF3sLkWLFXPhyh+b55N/mFm/VTOuDQGR07yUIHUfNbSpes40b7tQ3yl0joLoETXpTGf6IbRU4qG0XXPWwJvoRcbDACvfh+iA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557916; c=relaxed/simple; bh=XRakefmrMcFbupw4EVBDwSukHxL7jXcDLHS4D/x7yuM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JbTODEsbFE+FcE5QHn13X+wVSsjljNACeI+fpT0R8trq6itVbcWZTMgj26lBYdG5DDX7zOQDMXLNjJFo26wJ1RRVdVF/gewAPHowp1fMOiNZJm9YFv2hbPBDGHQXv0P3lywI2NutzqSo0Og4EUAy09D/mzQeTtoJ/g1bFtqYb4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V6pIIHGM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EmFKw+j2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V6pIIHGM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EmFKw+j2" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDrOCO2328988 for ; Mon, 20 Jul 2026 14:31:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=V6pIIHGM0seBO1ic X+CnzBsSRPjH6xnkOdQ8UYvGh7BixZbGKrh6OlPhq6FqhL+vnOb1c2lcrUgDPS9w zwatz+mM7TqLOSkr0toRwd2gav64hHxjynCDuNuDYBCFRk90zp18qayTF/rYCaG9 QbvQ8dcxtE14Hvtupigb90qF3O0+405yVAxoATSzvs4cUFol3N2SP4d6yQeHo0bI mEHk3fRH1vi7V3at+4H1UrTu10l5wZU1VCmiSHY8vJI6gGGCpnKWP3Wg03QW0d5v ZcDfOMlkGj5ioqm0BuTU/Zy4VA7zMZ6jqj1vsn9doC5yLBiE45u5DgP0Qj4Iyacd /5Bgbg== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhgs51bjf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:31:53 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5c113ce8f7dso7542772e0c.0 for ; Mon, 20 Jul 2026 07:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784557913; x=1785162713; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=EmFKw+j2YufMteOUiLXkntzu1fxiVxZ+sKNU9gvH5rwoyzlp9dOKECfHiY30z7gdfs TKvw4BI+j9wA5e7J63jjqRURxYRLEOIKNrDQ3+qCNWUYKPKxCnraLmvTsB0Ar+4crMeg i4Z9ypeszzFK1UlSMqesa4sETJ/zWopwpUI1pk/wluV/PkpD+gZAbu4oP+DWOmDWBQFM zAluc2WSvvGB3k85MXF1WtfNp9bUwyh5+R9DFYYFqXyJ+B5VX1OTYoE+ZBDhi7nqx3qC RrVYgbocsJDIr0kF1CMiEWeV7QGY48sz0wF7R29x3wINcSKyJGZzNeoYPwObvE0K2mhR gX3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784557913; x=1785162713; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=NcSamp9exkJ1Fby32rmvFHho2eeeIfSytg7+tRCw5yg/5WQ+3FTOvLLrZq0/Oww7cS jWMAoDQh4P8nSZYGSFTo+gpf6BG77pXKKAIDWWhE9OE9PWGgczMYcE0kZoaJj9+DJWFJ jCjbxC3TJ4EtFpBJGicHQ7TSQor/jr76uANhiOO3Xo083Vq0HTB8MlrsHp0nVcjkUUmT BJ6EInKBJ2GhgNeA9LYmaPN6ohspxm54sxvMi6ZZiNSQjHKS+XSDbTP8TPObrqQRZRd1 e37rC07HyW3j07s8YT5mH9RMQJD7WMAtFgMoDUxca6HZA/YT/43X7hmnJGw8IbbtqoKR Uf1g== X-Forwarded-Encrypted: i=1; AHgh+Rom4/z/qZb7aTDrZkt/J99O12PoENuc9PM7rucUxm5maxWByOVj/fzPGkVJ8bOtKp5zbkH0TePGUA8DO9E=@vger.kernel.org X-Gm-Message-State: AOJu0YwPmqae3uZIKyv1srdpq+tWfhQuOz63jGcSQHveoCQo6Y4yZALL j6xu9HOrAEkN+WOLPdSgPc1Qj6ztHr7Z6deocOy17xBFE3YCFWNudnMAMbmWBXK6isrKGUkqfMy BPcWgTUwzI8+b/RKlTuscQZJl/5DSSFuQUuCUpPH0nLIgc8bVIkRQtilQPNJrt2GOLM0= X-Gm-Gg: AfdE7cmsjJyZJQfkZ40Ah9UoGgXLKie/3mjMDe5jpakspIPhcN8ItLMP1IhulsMNjyY UIrZRTAHKDUMkp9al1p4GOcplB8GGmHiVDAw5FeJpqr6VONSxx7fam452ng7rvx4aEwWsyMXIcS QkVPLlsU6We/M2zjaBt7cdO/NiIpD559rsS4Ovcl2OrU5/ThVsir4/ueaiqnEJt15DA2veKDJs5 lL5ARoV2JBWf2RjhMOLy5kywEPErxAp4jXxm+7wn6BqLXmguwQIY9JDwm8fi+OYggPLDQj41Qke 2sl8MsxtqMwOMAgQXB+h6WAE4Nr9ygqapvC9THWA2plLxpwisI29ACNm8WA091pyI6zLPN5he9G a77gNvj2KXg4p6KQQZg3XK8S5YQmZy6cR8M2AMgMukadn8n1D728QTcbvpFBv4jEFkZTHoKZ8sh 52KDTAdl4ye8Hx+w== X-Received: by 2002:a05:6102:3e12:b0:744:cb59:d6e4 with SMTP id ada2fe7eead31-7475373fae7mr4340472137.22.1784557912705; Mon, 20 Jul 2026 07:31:52 -0700 (PDT) X-Received: by 2002:a05:6102:3e12:b0:744:cb59:d6e4 with SMTP id ada2fe7eead31-7475373fae7mr4340446137.22.1784557912168; Mon, 20 Jul 2026 07:31:52 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291e297ecsm2333411e87.82.2026.07.20.07.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:31:50 -0700 (PDT) Date: Mon, 20 Jul 2026 17:31:49 +0300 From: Dmitry Baryshkov To: Cristian Ciocaltea Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Niederpr=FCm?= , Simon Wright Subject: Re: [PATCH v4 8/8] phy: rockchip: samsung-hdptx: Consistently use bitfield macros Message-ID: References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2MiBTYWx0ZWRfX7JHx2AK9Ej7T tJyugJ+zeizBZjUFPbwrXdPjPvM3x5t3Jt0khisq7iUore+I/mSbAGKl60GdlJmN0RelQbMvUmf Mw6z3VNMNUdqO8m7stHXxadIb8sCEcU= X-Proofpoint-GUID: yUJbHGVBVo1WH8dpK5erq8qxqGs7LhhL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2MiBTYWx0ZWRfX69tr9wRm3etL DK+kZ3pbmJUEjkWiNXA17C9ljlZZ2Z3psByzqZQCvOLWTAqtjDxPKHxswyGLdDEcthj6xO0Mydn iPdE3VQkDXZJinPZ4QxY6qnEXkwOI8Pw7eLXJbmgH93poVT08ijRT76RLi5+fWkETa2IQ3e+80t ZBpCLLzj6uJM6g3egfvxxBek7+OCxY4p/ecVU08/s5ev+Orq3AnzIMvHXwOl+clcPWS+6s3Xucc 6uiSIkBReZbh5DBqCViMgoSmcN2yT0TIyXBSIW/lXWRhUDRTSFlK2qfoqRaJp/f4a8mn9MkjEzn 6qnoyllh4Wrr9AWXGTg9U8q6yu0oZEAF7ScMQziuDl5vAFrOK/yA330J1+MWFBVkvaPPaXrVa6w uU+H01UT+39ubAaE8026V5cxdxV/EmyqM/2UI0qsqw9VpwPsUCeE+jss+57NyEa579jNpSisfkg yVoYzMg4LznuP5nh3hw== X-Authority-Analysis: v=2.4 cv=CpiPtH4D c=1 sm=1 tr=0 ts=6a5e3159 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=I81vlq0Cx9dIN7l1fGsA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=XD7yVLdPMpWraOa8Un9W:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-ORIG-GUID: yUJbHGVBVo1WH8dpK5erq8qxqGs7LhhL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200162 On Fri, Jun 12, 2026 at 02:45:27AM +0300, Cristian Ciocaltea wrote: > Make the code more robust and improve readability by using the available > bitfield macros (e.g. FIELD_PREP, FIELD_GET) whenever possible, instead > of open coding the related bit operations. > > Tested-by: Thomas Niederprüm > Tested-by: Simon Wright > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 30 +++++++++++++++-------- > 1 file changed, 20 insertions(+), 10 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05A6BC4452B for ; Mon, 20 Jul 2026 14:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=koye5Fvsy4W1GaoSoZalMx/lkGV70mw6fHeZhIF1HsY=; b=T1HZwCf6zbiIHY 4bDHhTWK7rCA0/DeAwZCWZ3G/x7rXG/iu7shLOVmuzGIJgrlISaqhlOJFWyyexzEd4sfDdZfpbkMm YQ8QsGYQqCLxKDFXBnFEmvyne6C3dA0mQh0OQfEgbK7J/pfWc3Czd26w1Vo9WqbRof4k01sr2Blt3 nCbuQKzP0bLIUSyElcGQ1pIzfXSu/q4uCRQxEtNhTIaccuIVfC/GOh6Q3oyfqIlrlqwFooIHRk2ze hBhlBpUue0ShgkOOyJ136+UOe3SHU3d1fBVnmwXBzCFSUPyqe4IFHdtz6KMNA70mhZ/HNLX/el3QT 2hCK7v4ukYX9ePGun1qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlp2C-00000006ylz-2L0q; Mon, 20 Jul 2026 14:31:56 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlp2A-00000006ykb-2BB9 for linux-rockchip@lists.infradead.org; Mon, 20 Jul 2026 14:31:55 +0000 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDqZY72498883 for ; Mon, 20 Jul 2026 14:31:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=V6pIIHGM0seBO1ic X+CnzBsSRPjH6xnkOdQ8UYvGh7BixZbGKrh6OlPhq6FqhL+vnOb1c2lcrUgDPS9w zwatz+mM7TqLOSkr0toRwd2gav64hHxjynCDuNuDYBCFRk90zp18qayTF/rYCaG9 QbvQ8dcxtE14Hvtupigb90qF3O0+405yVAxoATSzvs4cUFol3N2SP4d6yQeHo0bI mEHk3fRH1vi7V3at+4H1UrTu10l5wZU1VCmiSHY8vJI6gGGCpnKWP3Wg03QW0d5v ZcDfOMlkGj5ioqm0BuTU/Zy4VA7zMZ6jqj1vsn9doC5yLBiE45u5DgP0Qj4Iyacd /5Bgbg== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhh5y18wd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:31:53 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-97702191344so3070705241.0 for ; Mon, 20 Jul 2026 07:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784557913; x=1785162713; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=JUvITvhe7aL/PjPrS5A9ZNse5wEaMwnaOokTZSM8Dr/V8qIjTYPg+cuBRotaL8ESe3 3aP6f0251XnaB1w9j/xNWIrDo0Id0Tc/vwfXU5+neAbmkmHQ4NlgNHESTlO3VQ+mg/vd dBDEPxOxWayVC8B3tlhw2jz360OldbwCr4c5Beh5qsZYUOgN7VzppdjMGLaeehFoKQyZ pW2cNRmGP6qg/S5OVe/Z+k6OaQkBmXsXPaJEJA7TfmCm4IJVDqIFG3Wx8WR6zO7k0E3c B4bXusJMHUA2g4ydAxY6a10JOMRK6ZHmYsnuyi4hMu2SunhKE5C0AoxkE4q+ObwPw7ZF 7YzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784557913; x=1785162713; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=XVVBJ31A6FbKsFlgxmXSOPAtuGA8TxPtOacCBKqwyhM=; b=r32BdLEJhVFuMA0+8vi2j4uxd9DMbCuEliGbrm1YMODXnsVNVXQ7qQEe/9SvemCS+k Yu+WEEyMbBYrNR1OrEkHPeVL10ZWgQUkwKHkXDvm4giedYPLrI9J1RHT1H38GJEP69Y7 hjIKhMtiO/6YzsxHaqVDRcUSGsfjksO3V4/U4YKYnB/7uQ0HrNERJ6vM1bmCDxq8b+0U 4QS1fM86ikNVApeLySYA4NYNwEqSdEyyXP2QIEZdCDLCcrmHOLSExFREYFCKvBzgA6KZ G+Ku1LObXzZhWOgCuIvCQJtT9KMC4jX2onYYuBTMZ5tt4TC43OG48cs5uS0DLL85tAnj zvOA== X-Forwarded-Encrypted: i=1; AHgh+RpRGklSsFDoUNCD9VJily48Mwr1WYOFagQwaYryKn8G3Bb7ApXeLZGoslk4zp5bE+plHoOJuvnYvQBv3XzAYg==@lists.infradead.org X-Gm-Message-State: AOJu0Yx/NoMS3q5Au/SxI08Cxdt58dxylCDVYKR4IDaNH13tjt0yw63K 7rfz+1Twm6o6k+D49nfxH9V4Xa0eFpi4JbRNLtDkhxypb4wKI0USIE/I7nZi2VDqOUbVSHA2USi AIsi3TmG8gEaWp5sbe2ykanJloc4/eu05IJ2IbRjWbl65byG254GQPHMyMDmjqhI7MvaltzMus+ 0= X-Gm-Gg: AfdE7cnbB94h5a8ID73Ty5ll1l9Zvr6lc4rHUvb7CpvNhqZIJG/ZzXommLYJ5okd6dX Uq3lo1TaYk3Q9o8JJaOTGSCY5Nyf7BYvUE+EePrnboGQV98fptGp4/GKFkbEWgXL113rofn9ETb eKlqfbqzN4n8tqER+ReNDCgzoGjiMNutLU0NFDsAtHIdEGEMN/XIIOgYxZsDsjMAAmH/cAOmMuO 4imK8JmKYCwfPbfHD3g73HAtfwjt/8yzP2fk7ieuaWHqWqHYptCkyRM7h+Tni94v+b9E5pjLget de8DK2Px7ABJgnCm7kJEUk4DXYgP2ILcb3kX7s15nqQSv9zQM1VW+tnwO5WoKaJG76GPUZUvdsY ANNBeSibtWNuGApJGm4jdtI0j/YVF0PRlRIvTt04aTSjq21xoYj8qLAx/57IuU9v4fQDlZ38fWI CapDbLB+o6zA0WRA== X-Received: by 2002:a05:6102:3e12:b0:744:cb59:d6e4 with SMTP id ada2fe7eead31-7475373fae7mr4340476137.22.1784557912706; Mon, 20 Jul 2026 07:31:52 -0700 (PDT) X-Received: by 2002:a05:6102:3e12:b0:744:cb59:d6e4 with SMTP id ada2fe7eead31-7475373fae7mr4340446137.22.1784557912168; Mon, 20 Jul 2026 07:31:52 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291e297ecsm2333411e87.82.2026.07.20.07.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:31:50 -0700 (PDT) Date: Mon, 20 Jul 2026 17:31:49 +0300 From: Dmitry Baryshkov To: Cristian Ciocaltea Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Niederpr=FCm?= , Simon Wright Subject: Re: [PATCH v4 8/8] phy: rockchip: samsung-hdptx: Consistently use bitfield macros Message-ID: References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2MiBTYWx0ZWRfX89/jevzBE/qM ZbfrE6NyFBvI8Vl29nCJgzvBeUoTly4uzFYFbP8uLgNmjuOJfWXdNjEO14WDUFNIW0WTIUP5aeV dpwl9c9Wrk63B7qtUkxD1/qvsu7Bfew= X-Proofpoint-GUID: sXPZRfp5Lva9MJ43KVnYNgZ8IF8q8R6d X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2MiBTYWx0ZWRfX8Lhd9LBUZ2IA iqnyszPtfTVvXag3MXiZrjP4CDtdOUIOkT0G2cYQHitFiWzWpiqPqFvb9OCe7svgcWGLW4MeObp GG2/IExNo6hM8pkwuTQfXgQ3VzMu3u5sB9wupVz4s2VzL6jVK6OdGW8I73Nu2edMw/7XXwy4qkk IktcM6uXUqYJTBR7VL445yt/W5dE1bBjH6BrDme0EPCv+VFStZ2PkG2wfGZ9iTXULJG8ecwQ7tC TXAIy96bOarbQREtk+rUPSmqNqoe3buBOXEqlqbPVv5csxAZyO99oM6QpbqTg4retC5TyzsLbgg KXc8fx99EvwflU5gP60MnHHOdpbv1bweBzEGPNBFPm6WcBc1oWYdf8bH/XchwQcl/cEJC7i3AVy DfKLh+nMCKKwxw7Z0/6louli2sbDKRbQhOUbAeDFvwqdJXCmmrRtyabDEoOxgt+0JUB8NTSq5+F 2dR86jeSDD2DRXNs+oA== X-Proofpoint-ORIG-GUID: sXPZRfp5Lva9MJ43KVnYNgZ8IF8q8R6d X-Authority-Analysis: v=2.4 cv=f/x4wuyM c=1 sm=1 tr=0 ts=6a5e3159 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=I81vlq0Cx9dIN7l1fGsA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=TD8TdBvy0hsOASGTdmB-:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200162 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_073154_562225_49905811 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Jun 12, 2026 at 02:45:27AM +0300, Cristian Ciocaltea wrote: > Make the code more robust and improve readability by using the available > bitfield macros (e.g. FIELD_PREP, FIELD_GET) whenever possible, instead > of open coding the related bit operations. > = > Tested-by: Thomas Niederpr=FCm > Tested-by: Simon Wright > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 30 +++++++++++++++--= ------ > 1 file changed, 20 insertions(+), 10 deletions(-) > = Reviewed-by: Dmitry Baryshkov -- = With best wishes Dmitry _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip