All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <sdf.kernel@gmail.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
	magnus.karlsson@intel.com,  stfomichev@gmail.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	 bjorn@kernel.org, kerneljasonxing@gmail.com
Subject: Re: [PATCH v4 net 0/6] xsk: fix AF_XDP multi-buffer Tx descriptor reclaim
Date: Mon, 20 Jul 2026 12:30:22 -0700	[thread overview]
Message-ID: <al53I9K0ThMPXjSU@devvm7509.cco0.facebook.com> (raw)
In-Reply-To: <20260719135609.147823-1-maciej.fijalkowski@intel.com>

On 07/19, Maciej Fijalkowski wrote:
> v3:
> https://lore.kernel.org/netdev/20260714140722.111645-1-maciej.fijalkowski@intel.com/T/
> v3->v4:
> 
> * Return standalone invalid Tx descriptors through the completion ring in
>   both the generic and zero-copy Tx paths. Advancing the Tx-ring consumer
>   releases only the ring slot; returning the descriptor address through
>   the CQ also transfers ownership of the corresponding UMEM frame back to
>   userspace.
> 
> * Remove xsk_tx_batch::consumed_descs. With standalone invalid descriptors
>   now reclaimed through the CQ, every descriptor permanently removed from
>   the Tx ring is represented by either tx_descs or reclaim_descs. Use
>   their sum for Tx-consumer advancement, shared-UMEM fairness accounting,
>   and progress detection.
> 
> * Ensure that generic reclaim-only processing publishes the updated
>   Tx-ring consumer even when no packet was submitted to the networking
>   stack.
> 
> * Update the XSK selftests to count every descriptor submitted to the Tx
>   ring as an expected CQ entry, while continuing to count only valid
>   packets as expected Rx traffic. This covers standalone invalid
>   descriptors, invalid multi-buffer packets, oversized packets, and the
>   non-verbatim STAT_TX_INVALID tests.
> 
> * Update the AF_XDP documentation to describe the completion ring as an
>   ownership-transfer mechanism and document that standalone, invalid
>   multi-buffer, and oversized Tx packets are reclaimed through the CQ.
> 
> * Add Jason's tags

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

Kudos for updating the doc with the new expectations! (and I still hope
that we can separately redo the generic tx path)

      parent reply	other threads:[~2026-07-20 19:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19 13:56 [PATCH v4 net 0/6] xsk: fix AF_XDP multi-buffer Tx descriptor reclaim Maciej Fijalkowski
2026-07-19 13:56 ` [PATCH v4 net 1/6] xsk: fix buffer leak in xsk_drop_skb() for AF_XDP multi-buffer Tx Maciej Fijalkowski
2026-07-19 13:56 ` [PATCH v4 net 2/6] xsk: drain continuation descs after overflow in xsk_build_skb() Maciej Fijalkowski
2026-07-20 13:58   ` sashiko-bot
2026-07-21 18:04   ` Maciej Fijalkowski
2026-07-19 13:56 ` [PATCH v4 net 3/6] xsk: provide sufficient space in pool->tx_descs Maciej Fijalkowski
2026-07-20 13:58   ` sashiko-bot
2026-07-19 13:56 ` [PATCH v4 net 4/6] xsk: reclaim invalid Tx descriptors in ZC batch path Maciej Fijalkowski
2026-07-19 13:56 ` [PATCH v4 net 5/6] selftests/xsk: fix too-many-frags multi-buffer Tx test Maciej Fijalkowski
2026-07-19 13:56 ` [PATCH v4 net 6/6] selftests/xsk: account reclaimed invalid Tx descriptors Maciej Fijalkowski
2026-07-20 19:30 ` Stanislav Fomichev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=al53I9K0ThMPXjSU@devvm7509.cco0.facebook.com \
    --to=sdf.kernel@gmail.com \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=horms@kernel.org \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stfomichev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.