From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BCB0625; Mon, 20 Jul 2026 17:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784567416; cv=none; b=igiQNnv7o5Fd/Ha8WhPVF27/X4CifQgvymWclPKNf0c6Yw+jisvNPQUt0YdaWloSkBnreJ/HbPCNBbkXGgCSm1VGKlfwd8QCEyL+JfeZh3vcoeaqgK01myxCw3WghlTyx/vX+4r3Di372ta4MVt31J01q/nVTl4B6sjHIEzhIbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784567416; c=relaxed/simple; bh=y78gdP4Mhf4DF9a087GDBf+ZMhh7EhPFI++5A5Fodco=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D9U1J4sEk+vrDcw1aD8nQm2bIZBhaDZIwrhpfY7KaNTsR3apRN1uHaSxJblhJwMrBgXOz3yxYxYHBULDfHt7zP+xckydCy1pSjbj8kuA+slJnjc5dClgEpLLTcSzyn4I9xVFmOHk/lSfG242FlbZXcrLWCVL3TyV1WiQNE7SbuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=itoK4Mdj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="itoK4Mdj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A03961F000E9; Mon, 20 Jul 2026 17:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784567407; bh=BjfOV+NKNZXLs5UViExwi4UTvSENVwLsFID1r6Q/kEw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=itoK4Mdjj5ii0LNFWHvWvZeKb1bM5ZWQY2SLjLXjkfO1feztT6Gn6G8NiVOat+KPg 0D/NB12mkVZe0Qu8dpRL0oONt2wA5dLQq2HFtDJt5+6MzcZEUaN8ebT6E6dQey+8Bv U67NhgIIVjM0yZ2RgwCjpyBriixC3kOUjNzXDQkdhvIe5nvIncSc+M1s1QCf4Glnzw 79N0nsDl390dkbxedNNurbefhulS5jWgAZhH6RiSFZ8JtYiyqnIGyKYLSKviEh1SQL 11vzxbZo4cCDnI1BgewLbszrJZvcJRudTbDKrMrm+59/LFG+1WpbrwjdfmaUCqah49 bbOMVK1BbfpDw== Date: Mon, 20 Jul 2026 10:10:05 -0700 From: Drew Fustini To: yunhui cui Cc: Adrien Ricciardi , Alexandre Ghiti , Atish Kumar Patra , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , Zhanpeng Zhang , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [External] [PATCH v5 4/8] riscv_cbqri: Add capacity controller probe and allocation device ops Message-ID: References: <20260714-dfustini-atl-sc-cbqri-dt-v5-0-b0ae7e9c932e@kernel.org> <20260714-dfustini-atl-sc-cbqri-dt-v5-4-b0ae7e9c932e@kernel.org> Precedence: bulk X-Mailing-List: linux-rt-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jul 20, 2026 at 05:56:29PM +0800, yunhui cui wrote: > Hi Drew, > > On Wed, Jul 15, 2026 at 8:24 AM Drew Fustini wrote: > > > > Add support for the RISC-V CBQRI capacity controller. A platform driver > > passes a cbqri_controller_info descriptor together with the cache level > > to riscv_cbqri_register_cc_dt(), which probes the controller and adds it > > to the controller list. > > > > Assisted-by: Claude:claude-opus-4-8 > > Co-developed-by: Adrien Ricciardi > > Signed-off-by: Adrien Ricciardi > > Signed-off-by: Drew Fustini > > --- > > MAINTAINERS | 3 + > > drivers/resctrl/Kconfig | 13 + > > drivers/resctrl/Makefile | 3 + > > drivers/resctrl/cbqri_devices.c | 563 +++++++++++++++++++++++++++++++++++++++ > > drivers/resctrl/cbqri_internal.h | 122 +++++++++ > > include/linux/riscv_cbqri.h | 45 ++++ > > 6 files changed, 749 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index a0a4b41f02c5..064a6ae2823e 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -23365,6 +23365,9 @@ L: linux-riscv@lists.infradead.org > > S: Supported > > F: arch/riscv/include/asm/qos.h > > F: arch/riscv/kernel/qos.c > > +F: drivers/resctrl/cbqri_devices.c > > +F: drivers/resctrl/cbqri_internal.h > > +F: include/linux/riscv_cbqri.h > > > > RISC-V RPMI AND MPXY DRIVERS > > M: Rahul Pathak > > diff --git a/drivers/resctrl/Kconfig b/drivers/resctrl/Kconfig > > index 672abea3b03c..92b9c82cf9f3 100644 > > --- a/drivers/resctrl/Kconfig > > +++ b/drivers/resctrl/Kconfig > > @@ -29,3 +29,16 @@ config ARM64_MPAM_RESCTRL_FS > > default y if ARM64_MPAM_DRIVER && RESCTRL_FS > > select RESCTRL_RMID_DEPENDS_ON_CLOSID > > select RESCTRL_ASSIGN_FIXED > > + > > +menuconfig RISCV_CBQRI > > + bool "RISC-V CBQRI support" > > + depends on RISCV && RISCV_ISA_SSQOSID > > + help > > + Capacity and Bandwidth QoS Register Interface (CBQRI) support for > > + RISC-V cache QoS resources. CBQRI exposes cache capacity > > + allocation through the resctrl filesystem at /sys/fs/resctrl when > > + RESCTRL_FS is also enabled. > > + > > +if RISCV_CBQRI > > + > > +endif > > Should this empty if/endif block go in patch [8/8] instead? Good point. I'll move it to patch 8. Thanks, Drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98159C44515 for ; Mon, 20 Jul 2026 17:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+llWHsej/56LVtLE2Zxih/IwfeWZzaWObfnCOacoMms=; b=yEPkG4EfMVFy/8 xd3z1FnkndJjvPX0lgK2Lyk9kZlym+yM3pZNpYzodoqCYAN0/3yg1RKRj2Kgd+tv1S4tpJHowgoUf /oN12NLtDYvggKXYJuou3ZfQc9Bdi2Y/MmKVswKeIbst4pQSo+vm4TO/f3brNE87KQszyPvARfhs0 hEHX+FcN5Oe9zplCKvFkvBaZUma+/fQ+NajE0gKe6H9zER+kii2k+YnNJEUelBho5ycXykTosBXw/ Xlch7btkEG8ioMNSLwSx4EF3FbPQu2gWeRxn+KfZGV6bEL9LttkVSL83UEE+6X97WQWDeaglyhiU0 M3IuEg0RDyi6bqQtz7vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlrVK-00000007TxC-0T3n; Mon, 20 Jul 2026 17:10:10 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlrVI-00000007Twj-2IQf for linux-riscv@lists.infradead.org; Mon, 20 Jul 2026 17:10:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 6D93060052; Mon, 20 Jul 2026 17:10:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A03961F000E9; Mon, 20 Jul 2026 17:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784567407; bh=BjfOV+NKNZXLs5UViExwi4UTvSENVwLsFID1r6Q/kEw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=itoK4Mdjj5ii0LNFWHvWvZeKb1bM5ZWQY2SLjLXjkfO1feztT6Gn6G8NiVOat+KPg 0D/NB12mkVZe0Qu8dpRL0oONt2wA5dLQq2HFtDJt5+6MzcZEUaN8ebT6E6dQey+8Bv U67NhgIIVjM0yZ2RgwCjpyBriixC3kOUjNzXDQkdhvIe5nvIncSc+M1s1QCf4Glnzw 79N0nsDl390dkbxedNNurbefhulS5jWgAZhH6RiSFZ8JtYiyqnIGyKYLSKviEh1SQL 11vzxbZo4cCDnI1BgewLbszrJZvcJRudTbDKrMrm+59/LFG+1WpbrwjdfmaUCqah49 bbOMVK1BbfpDw== Date: Mon, 20 Jul 2026 10:10:05 -0700 From: Drew Fustini To: yunhui cui Cc: Adrien Ricciardi , Alexandre Ghiti , Atish Kumar Patra , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , Zhanpeng Zhang , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [External] [PATCH v5 4/8] riscv_cbqri: Add capacity controller probe and allocation device ops Message-ID: References: <20260714-dfustini-atl-sc-cbqri-dt-v5-0-b0ae7e9c932e@kernel.org> <20260714-dfustini-atl-sc-cbqri-dt-v5-4-b0ae7e9c932e@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdWwgMjAsIDIwMjYgYXQgMDU6NTY6MjlQTSArMDgwMCwgeXVuaHVpIGN1aSB3cm90 ZToKPiBIaSBEcmV3LAo+IAo+IE9uIFdlZCwgSnVsIDE1LCAyMDI2IGF0IDg6MjTigK9BTSBEcmV3 IEZ1c3RpbmkgPGZ1c3RpbmlAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gQWRkIHN1cHBvcnQg Zm9yIHRoZSBSSVNDLVYgQ0JRUkkgY2FwYWNpdHkgY29udHJvbGxlci4gQSBwbGF0Zm9ybSBkcml2 ZXIKPiA+IHBhc3NlcyBhIGNicXJpX2NvbnRyb2xsZXJfaW5mbyBkZXNjcmlwdG9yIHRvZ2V0aGVy IHdpdGggdGhlIGNhY2hlIGxldmVsCj4gPiB0byByaXNjdl9jYnFyaV9yZWdpc3Rlcl9jY19kdCgp LCB3aGljaCBwcm9iZXMgdGhlIGNvbnRyb2xsZXIgYW5kIGFkZHMgaXQKPiA+IHRvIHRoZSBjb250 cm9sbGVyIGxpc3QuCj4gPgo+ID4gQXNzaXN0ZWQtYnk6IENsYXVkZTpjbGF1ZGUtb3B1cy00LTgK PiA+IENvLWRldmVsb3BlZC1ieTogQWRyaWVuIFJpY2NpYXJkaSA8YXJpY2NpYXJkaUBiYXlsaWJy ZS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBZHJpZW4gUmljY2lhcmRpIDxhcmljY2lhcmRpQGJh eWxpYnJlLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IERyZXcgRnVzdGluaSA8ZnVzdGluaUBrZXJu ZWwub3JnPgo+ID4gLS0tCj4gPiAgTUFJTlRBSU5FUlMgICAgICAgICAgICAgICAgICAgICAgfCAg IDMgKwo+ID4gIGRyaXZlcnMvcmVzY3RybC9LY29uZmlnICAgICAgICAgIHwgIDEzICsKPiA+ICBk cml2ZXJzL3Jlc2N0cmwvTWFrZWZpbGUgICAgICAgICB8ICAgMyArCj4gPiAgZHJpdmVycy9yZXNj dHJsL2NicXJpX2RldmljZXMuYyAgfCA1NjMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gPiAgZHJpdmVycy9yZXNjdHJsL2NicXJpX2ludGVybmFsLmggfCAxMjIgKysr KysrKysrCj4gPiAgaW5jbHVkZS9saW51eC9yaXNjdl9jYnFyaS5oICAgICAgfCAgNDUgKysrKwo+ ID4gIDYgZmlsZXMgY2hhbmdlZCwgNzQ5IGluc2VydGlvbnMoKykKPiA+Cj4gPiBkaWZmIC0tZ2l0 IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwo+ID4gaW5kZXggYTBhNGI0MWYwMmM1Li4wNjRh NmFlMjgyM2UgMTAwNjQ0Cj4gPiAtLS0gYS9NQUlOVEFJTkVSUwo+ID4gKysrIGIvTUFJTlRBSU5F UlMKPiA+IEBAIC0yMzM2NSw2ICsyMzM2NSw5IEBAIEw6ICAgICAgbGludXgtcmlzY3ZAbGlzdHMu aW5mcmFkZWFkLm9yZwo+ID4gIFM6ICAgICBTdXBwb3J0ZWQKPiA+ICBGOiAgICAgYXJjaC9yaXNj di9pbmNsdWRlL2FzbS9xb3MuaAo+ID4gIEY6ICAgICBhcmNoL3Jpc2N2L2tlcm5lbC9xb3MuYwo+ ID4gK0Y6ICAgICBkcml2ZXJzL3Jlc2N0cmwvY2JxcmlfZGV2aWNlcy5jCj4gPiArRjogICAgIGRy aXZlcnMvcmVzY3RybC9jYnFyaV9pbnRlcm5hbC5oCj4gPiArRjogICAgIGluY2x1ZGUvbGludXgv cmlzY3ZfY2JxcmkuaAo+ID4KPiA+ICBSSVNDLVYgUlBNSSBBTkQgTVBYWSBEUklWRVJTCj4gPiAg TTogICAgIFJhaHVsIFBhdGhhayA8cmFodWxAc3VtbWF0aW9ucy5uZXQ+Cj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9yZXNjdHJsL0tjb25maWcgYi9kcml2ZXJzL3Jlc2N0cmwvS2NvbmZpZwo+ID4g aW5kZXggNjcyYWJlYTNiMDNjLi45MmI5YzgyY2Y5ZjMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJz L3Jlc2N0cmwvS2NvbmZpZwo+ID4gKysrIGIvZHJpdmVycy9yZXNjdHJsL0tjb25maWcKPiA+IEBA IC0yOSwzICsyOSwxNiBAQCBjb25maWcgQVJNNjRfTVBBTV9SRVNDVFJMX0ZTCj4gPiAgICAgICAg IGRlZmF1bHQgeSBpZiBBUk02NF9NUEFNX0RSSVZFUiAmJiBSRVNDVFJMX0ZTCj4gPiAgICAgICAg IHNlbGVjdCBSRVNDVFJMX1JNSURfREVQRU5EU19PTl9DTE9TSUQKPiA+ICAgICAgICAgc2VsZWN0 IFJFU0NUUkxfQVNTSUdOX0ZJWEVECj4gPiArCj4gPiArbWVudWNvbmZpZyBSSVNDVl9DQlFSSQo+ ID4gKyAgICAgICBib29sICJSSVNDLVYgQ0JRUkkgc3VwcG9ydCIKPiA+ICsgICAgICAgZGVwZW5k cyBvbiBSSVNDViAmJiBSSVNDVl9JU0FfU1NRT1NJRAo+ID4gKyAgICAgICBoZWxwCj4gPiArICAg ICAgICAgQ2FwYWNpdHkgYW5kIEJhbmR3aWR0aCBRb1MgUmVnaXN0ZXIgSW50ZXJmYWNlIChDQlFS SSkgc3VwcG9ydCBmb3IKPiA+ICsgICAgICAgICBSSVNDLVYgY2FjaGUgUW9TIHJlc291cmNlcy4g Q0JRUkkgZXhwb3NlcyBjYWNoZSBjYXBhY2l0eQo+ID4gKyAgICAgICAgIGFsbG9jYXRpb24gdGhy b3VnaCB0aGUgcmVzY3RybCBmaWxlc3lzdGVtIGF0IC9zeXMvZnMvcmVzY3RybCB3aGVuCj4gPiAr ICAgICAgICAgUkVTQ1RSTF9GUyBpcyBhbHNvIGVuYWJsZWQuCj4gPiArCj4gPiAraWYgUklTQ1Zf Q0JRUkkKPiA+ICsKPiA+ICtlbmRpZgo+IAo+IFNob3VsZCB0aGlzIGVtcHR5IGlmL2VuZGlmIGJs b2NrIGdvIGluIHBhdGNoIFs4LzhdIGluc3RlYWQ/CgpHb29kIHBvaW50LiBJJ2xsIG1vdmUgaXQg dG8gcGF0Y2ggOC4KClRoYW5rcywKRHJldwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1yaXNjdgo=