From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
kernel test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: fix compile error with hub6_match_port() when compiled as a module
Date: Mon, 20 Jul 2026 21:09:03 +0200 [thread overview]
Message-ID: <al5yTxizfIGibYZa@black.igk.intel.com> (raw)
In-Reply-To: <20260715153707.4181828-1-hugo@hugovil.com>
On Wed, Jul 15, 2026 at 11:37:05AM -0400, Hugo Villeneuve wrote:
> With CONFIG_SERIAL_8250_HUB6=m, we have the following compile error:
>
> ../drivers/tty/serial/8250/8250_hub6.c:46:6: error: redefinition of
> 'hub6_match_port'
>
> Fix hub6_match_port() prototype definition by using IS_REACHABLE() to
> support both built-in and module values, and substitute empty prototype
> otherwise.
...
> +#include <linux/kconfig.h>
It's special header. It is always-included one, and hence here is a dup, please
drop this line.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-20 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 15:37 [PATCH] serial: 8250: fix compile error with hub6_match_port() when compiled as a module Hugo Villeneuve
2026-07-20 10:39 ` Uwe Kleine-König
2026-07-20 19:09 ` Andy Shevchenko [this message]
2026-07-20 19:11 ` Hugo Villeneuve
2026-07-20 19:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al5yTxizfIGibYZa@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.