Re: [PATCH] i2c-tools: i2ctransfer: Set I2C adapter timeout using I2C_TIMEOUT ioctl

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

Hi,

>   Thanks for the review. Your suggestion makes sense to me - I'll move
>   it out of i2ctransfer and add -T (timeout) and -R (retries) to
>   i2cdetect instead. I agree a separate i2cconfig tool is not needed.

Great, thanks.

>   While checking the list of ioctls, I observed the I2C_TIMEOUT ioctl
>   to set the timeout, but I did not observe any "get" ioctl to read
>   the timeout value back from user space (same for retries). So
>   setting a value with -T/-R works, but reading the current value
>   (when no value is given) does not seem possible right now.

You are right. That shows how seldom those IOCTLs are used. I forgot
that one cannot read them, sorry about that.

>   Could you let me know how you would like me to handle this - should
>   I keep -T/-R as set-only for now?

Yes. This is the way to go.

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]