Re: [PATCH] ASoC: rt766: add RT766/RT767 SDCA driver

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Tue, Jul 21, 2026 at 07:10:00AM +0000, Shuming [范書銘] wrote:
> > > +                             if (ret)
> > > +                                     return ret;
> > > +
> > > +                             interrupt->priv = rt766;
> > > +                             ret = sdca_irq_request(dev, info, irq,
> > interrupt->name,
> > > +
> > handler, interrupt);
> > > +                             if (ret) {
> > > +                                     dev_err(dev, "failed to
> > request irq %s: %d\n",
> > > +                                             interrupt->name,
> > ret);
> > > +                                     return ret;
> > > +                             }
> > > +                             dev_dbg(dev, "Requesting IRQ %d
> > InterruptName=%s\n", irq, interrupt->name);
> > > +                     } else {
> > > +                             sdca_irq_free(dev, info, irq,
> > interrupt->name, interrupt);
> > > +                             dev_dbg(dev, "Freeing IRQ %d\n", irq);
> > > +                     }
> > > +             }
> > > +     }
> > > +
> > > +     return 0;
> > > +}
> > 
> > Hmm... yeah this is moving in a slightly different direction from where I was
> > going with the core code. Let me think about that and update tomorrow.
> 
> Sorry, I don't quite follow the point.
> Do you mean that it will not work with this patch (ASoC: SDCA: Populate IRQ data earlier)?

Mostly, the issue here is you are calling things at different
times to the class driver, so the devm allocations will probably
leak but I think I will update my patch chain to drop the devm
allocations to keep things flexible. There are some minor updates
required to this patch for my core changes but that is the only
one that doesn't work I think.

I will send out a new spin later today and CC you on it.

Thanks,
Charles