From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9FB4C44501 for ; Fri, 10 Jul 2026 08:07:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wi6GK-0008VA-LP; Fri, 10 Jul 2026 04:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wi6GJ-0008Up-7t for qemu-devel@nongnu.org; Fri, 10 Jul 2026 04:07:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wi6GH-0006Nd-Du for qemu-devel@nongnu.org; Fri, 10 Jul 2026 04:07:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783670824; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tCgOFOD16OJF/0xn0dQOC+l1EPZ+ctd/ZsABuqUHURs=; b=cevj8wncAt4hEG3PmV0TdtEL3g6isQlQWLSZryxWMf5Ui1/ETZWiEnkKTSBrzc803VWh0i t2bnakqCFRS/WMUZOR+1hfSTXqpbrYV/mNxMlxz8UhYTQJE0mXtEH3KdDt46fVG4nKXg7M 0LupT6jtsCDFATBUONLZ5PW/9Hx+59s= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-370-5niyaRRuMR24eS5lwt8H4A-1; Fri, 10 Jul 2026 04:07:01 -0400 X-MC-Unique: 5niyaRRuMR24eS5lwt8H4A-1 X-Mimecast-MFC-AGG-ID: 5niyaRRuMR24eS5lwt8H4A_1783670820 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3E9EA1955F1B; Fri, 10 Jul 2026 08:07:00 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.145]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2D1E31800348; Fri, 10 Jul 2026 08:06:57 +0000 (UTC) Date: Fri, 10 Jul 2026 09:06:54 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Paolo Bonzini , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v2 2/4] tests/docker: add support for podman remote access Message-ID: References: <20260210163556.713841-1-berrange@redhat.com> <20260210163556.713841-3-berrange@redhat.com> <947a4843-34ae-43f7-8fbc-80109bc0c077@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <947a4843-34ae-43f7-8fbc-80109bc0c077@oss.qualcomm.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Jul 09, 2026 at 09:24:12AM -0700, Pierrick Bouvier wrote: > On 7/9/2026 9:13 AM, Daniel P. Berrangé wrote: > > On Thu, Jul 09, 2026 at 07:48:14AM -0700, Pierrick Bouvier wrote: > >> On 2/10/2026 8:35 AM, Daniel P. Berrangé wrote: > >>> When a developer's environment is already within a podman container it > >>> is not possible to use 'podman' again to create containers. It will > >>> usually result in wierd errors such as: > >>> > >>> Error: fatal error, invalid internal status, unable to create a new pause process: cannot re-exec process to join the existing user namespace. Try running "podman system migrate" and if that doesn't work reboot to recover > >>> > >>> Podman offers the ability to talk to a daemon outside the container, > >>> however, which could be leveraged by QEMU. > >>> > >>> This can be used by invoking "podman --remote", or equivalently the > >>> separate "podman-remote" binary: > >>> > >>> https://github.com/containers/podman/blob/main/docs/tutorials/remote_client.md > >>> > >>> The current 'podman version' check is insufficient to detect the > >>> inability to launch containers, so it is replaced with the stronger > >>> 'podman info' check. > >>> > >>> Signed-off-by: Daniel P. Berrangé > >>> --- > >>> tests/docker/docker.py | 10 ++++++---- > >>> 1 file changed, 6 insertions(+), 4 deletions(-) > >>> > >>> diff --git a/tests/docker/docker.py b/tests/docker/docker.py > >>> index ff68c7bf6f..9e18b984f4 100755 > >>> --- a/tests/docker/docker.py > >>> +++ b/tests/docker/docker.py > >>> @@ -76,14 +76,16 @@ def _guess_engine_command(): > >>> commands = [] > >>> > >>> if USE_ENGINE in [EngineEnum.AUTO, EngineEnum.PODMAN]: > >>> - commands += [["podman"]] > >>> + commands += [["podman"], ["podman-remote"], ["podman", "--remote"]] > >>> if USE_ENGINE in [EngineEnum.AUTO, EngineEnum.DOCKER]: > >>> commands += [["docker"], ["sudo", "-n", "docker"]] > >>> for cmd in commands: > >>> try: > >>> - # docker version will return the client details in stdout > >>> - # but still report a status of 1 if it can't contact the daemon > >>> - if subprocess.call(cmd + ["version"], > >>> + # 'version' is not sufficient to prove a working binary > >>> + # for podman. 'info' is a stronger check that is more > >>> + # likely to correlate with ability to create containers, > >>> + # and required to detect the need for podman remote > >>> + if subprocess.call(cmd + ["info"], > >>> stdout=DEVNULL, stderr=DEVNULL) == 0: > >>> return cmd > >>> except OSError: > >> > >> Taking a look at why tcg tests are slow to compile, I reached this > >> commit. It seems like that calling 'podman info' is 5 to 10 times slower > >> than calling 'podman version'. > >> Thus, a container run now takes +1s when it was 0.2 before. > > > > Hmmm, but we call 'docker.py probe' in configure and cache the result, > > so that probe should only be done once. 0.2 vs 1s is just noise in > > the context of configure. > > > > That you're seeing any negative effects suggests that we've got > > something not using the cached probe result, which we should fix. > > > > Not really, docker.py --engine X still calls X info. > > https://gitlab.com/qemu-project/qemu/-/blob/master/tests/docker/docker.py#L675 > https://gitlab.com/qemu-project/qemu/-/blob/master/tests/docker/docker.py#L78 > > Maybe the fix is to remove the check if user specified an explicit > engine. But in this case, there is a problem with podman-remote not > being detected anymore. > > We can fix this by introducing engine=podman-remote, and skip the check > if engine is explicitly set. > What do you think? Urgh, so i see now we have two code paths / make variables RUNC=podman --remote CONTAINER_ENGINE=auto Sometimes we'll invoke docker.py --engine $(CONTAINER_ENGINE) and sometimes we'll directly invoke $(RUNC). The result of "probe" cannot be fed back in to "--engine" which is a bit of a mess. I think the "engine" concept should not be exposed on the cli, and instead have a "--runc" arg which takes the full arg(s), since we need probe to report the runc args for other reasons. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|