From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: Tianchu Chen <tianchu.chen@linux.dev>
Cc: philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH] drbd: reject oversized DataReply before signed conversion
Date: Fri, 10 Jul 2026 12:34:42 +0200 [thread overview]
Message-ID: <alDJWJYBNGpugftk@localhost.localdomain> (raw)
In-Reply-To: <d4924afb559896a4a22258f14e4a97c8d12d8527@linux.dev>
On Tue, Jun 30, 2026 at 10:59:31AM +0000, Tianchu Chen wrote:
>From: Tianchu Chen <flynnnchen@tencent.com>
>
>Discovered by Atuin - Automated Vulnerability Discovery Engine.
>
>Reject DataReply payload lengths that cannot fit in recv_dless_read()'s
>signed size argument so a bogus remote peer cannot wrap the length negative
>and turn it into a huge heap OOB-write.
>
>Fixes: b411b3637fa7 ("The DRBD driver")
>Cc: stable@vger.kernel.org
>Signed-off-by: Tianchu Chen <flynnnchen@tencent.com>
This is similar to [0], but the mentioned patch is a more complete fix.
There is also a case in recv_dless_read where data_size can underflow
when a data-integrity-alg is configured.
The other patch catches this case as well by placing the guard later, so
I would prefer to apply that one instead of this.
Thanks,
Christoph
[0] https://lore.kernel.org/all/20260710022837.3738461-1-michael.bommarito@gmail.com/
prev parent reply other threads:[~2026-07-10 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 10:59 [PATCH] drbd: reject oversized DataReply before signed conversion Tianchu Chen
2026-07-10 10:34 ` Christoph Böhmwalder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alDJWJYBNGpugftk@localhost.localdomain \
--to=christoph.boehmwalder@linbit.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=tianchu.chen@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.