From: Dan Carpenter <error27@gmail.com>
To: Jianbo Liu <jianbol@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [bug report] net/mlx5: Change TTC rules to match on undecrypted ESP packets
Date: Fri, 10 Jul 2026 14:30:38 +0300 [thread overview]
Message-ID: <alDX3hoJMMWcasUy@stanley.mountain> (raw)
In-Reply-To: <0104f0d4-060f-4554-ac60-3db4bbb519c5@nvidia.com>
On Fri, Jul 10, 2026 at 06:04:35PM +0800, Jianbo Liu wrote:
> Thanks for the report.
>
> This appears to be a false positive. On every failure path in
> mlx5_create_ttc_table_ipsec_groups(), mlx5_create_flow_group() stores an
> ERR_PTR in:
>
> ttc->g[ttc->num_groups]
>
> The helper increments ttc->num_groups only after successful group
> creation.
> Therefore, when the helper returns an error, ttc->num_groups still
> identifies
> the failed entry and that entry contains the same ERR_PTR. It remains
> unchanged before the shared error label calls PTR_ERR().
>
Ah, yes. Thanks. I should have checked... :/
regards,
dan carpenter
prev parent reply other threads:[~2026-07-10 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 9:41 [bug report] net/mlx5: Change TTC rules to match on undecrypted ESP packets Dan Carpenter
2026-07-10 10:04 ` Jianbo Liu
2026-07-10 11:30 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alDX3hoJMMWcasUy@stanley.mountain \
--to=error27@gmail.com \
--cc=jianbol@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.