From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F7AA21D3F5 for ; Sat, 11 Jul 2026 22:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783810074; cv=none; b=CYSzOcYF2OaDtkHXxMcGX9d+jxVfnoaV8jmG8V8R/a1ROKA2sFGGkGO+E5cy3YqXM2fZ8vpubG+CkL0MYg7zVAYWkLdbC1Oeq3wu72NpBk3btBMW8zRK4Z76IsmU709ROoz5+bZ9UcalOAYuF/BMLTQ07f1V5elQIprMF8jsGlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783810074; c=relaxed/simple; bh=aboeeCUIcUaO3xT9USn6gRikuUTg1ZLrqdsYVPRWZTQ=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hp7fCUjcPT7vc9TrSg6w60Ruo0XNZUJF2kyjS5dMb1TeI1DTpEj9Flc6Lp0qUwC1g415h79jP7YrJdnNU/aSfjU1acqOI/0F1jh4AfqsWKviG8YocgR+HaI9uIaF8snh7J1qMo3EuecWcmAcHsf0VY417NKEQ39uEuoDxYLdtQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CGWTO7aU; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CGWTO7aU" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-385ea3ce80dso2298407a91.2 for ; Sat, 11 Jul 2026 15:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783810072; x=1784414872; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dHq/bn+Fso5t22HHctH3DoJ0EJ7q2N6ddOX0jX3sBNg=; b=CGWTO7aUY1KkyD3qa8jCKmTnW2vGaiqj3xQhK4kBoFUoeG0KRtoo3ALCA6qY26g8r/ 3W/hBmhd3cuOL3ZKyeFJxycOpyRN0yvnWmgX3qtgvfIE0eJOpnFPOaVwk9pf0RGM1Dhu KH/y9QGSVxDkX9UlfmEp9DfeawOsNH4LHbdeXC9ItLplii5AL6vbJ0fFhSvyKfrgazIX ffQjmfk5iqu1Om+267X3n/hcMvKZ+hG1eUSWa+qL+atIw8hQH51oC5c5nt1t/FWAvFdj BgqvKjJTZd4ktkiFZ+UWSMo+iXaSxHuOoJXwR927IxjA7lSkrFIVktnSiocUMLilFPer omZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783810072; x=1784414872; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dHq/bn+Fso5t22HHctH3DoJ0EJ7q2N6ddOX0jX3sBNg=; b=bFjps6ilA/RMnDcm8ZzNqkKuisY+XcaIP7lYmUzd01R0Vh54up/h6WuR8UT5OphWEK F9cP6okSLEnGoPXhjErtYipRFtYwYeFQEtxURCOlsFNUP2U+dDgrx7b8YVtrQ3F/AQGO fMnHr6rDywozH//z9UKHKp02r4lA+CgYpv1sDkoeXoJQJTZzLjRHnVavvKOn1TJXgS1B ifiWlByFCM4BVbGNGGCEDFZgbJVKajjGiwGeY2C+Ish3Rs7j62NzIEillcIZNvyNistJ 4GS9WrTNlcONawMVmOpzpU+vaxM/hC6nD5I+QmcYkrGg9gIPL2oN7Kj5ftwofbUhikqN 4UrA== X-Forwarded-Encrypted: i=1; AHgh+RowAS3xO9CTAHeEiaMTB+/m3T1i+xw+ZmlhymPqC+fyRr66iWhOs4jM3v7DvUopV2y0FV2W8NkjEWozN9o=@vger.kernel.org X-Gm-Message-State: AOJu0YwHkbaIVtfUe4lNin9BG+w7QtaTpbu0pfq0LlsERjQWBNvkGhFF Osifo8Jk7FsgQon/Y/AWcfYpQ/55oSt4AdvWf5FPagKqbSl8eMzmhmBT58+lOA== X-Gm-Gg: AfdE7cmAcFgJK7TKPW/SfxxyHObUKJGhocLC7KZNcZljyrKqgOEfwoltJYjS9qNNYUH XwW5k47dt2fN1pKYQipLB9CYndvez1IZgP2yxSE4328U5itKeTrZkCksPNgTnRCOuNKx131BZPV pNlHkSfR948AqmOF8LMrMk5Ndk8jU1G0WrlSrbW92D3B5bK8+53HkGTPUNJpRSEmwyplKfb9Dji 2oYNgLn4x3qcktuqprlEubGbw76Y//UEAwsARDfx2QkCS+mNVCeXCDZdd26bJQt/mm/9/Z+htLx zBStAnxTJeaY/3pVVCuFjewUliejyuXIA0DP//R/+bx5LWBXp9UCWi11eRk0v+btspyAfbw5CxD mBLBWqGeqmtI4Oh/ZHBVGqTLrgKGi8weUz8skCBVptQRH2MTjSVQSgZIL94uobxg14jwUCDPg/G OVCBMgxFICSv0Tz+D/evJY0SqwPt5Hhm1jscPi52y0hQA3+28p1kcm X-Received: by 2002:a05:6a20:7350:b0:3b3:e05:7fc4 with SMTP id adf61e73a8af0-3c110ac62b9mr4080020637.30.1783810071914; Sat, 11 Jul 2026 15:47:51 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:c63e:9756:a95c:c75]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659d87a2sm50140429c88.13.2026.07.11.15.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 15:47:51 -0700 (PDT) Date: Sat, 11 Jul 2026 15:47:48 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: joydev - replace ev_match boolean with goto for early exit Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Ashton, On Thu, Jul 09, 2026 at 04:18:49PM +1200, Ashton Warner wrote: > The joydev_dev_is_absolute_mouse runs unnecessary Event type checks to > determine whether a joydev device is an absolute mouse. Change ev_match > to a goto statement to exit early. > > Signed-off-by: Ashton Warner I think this is one of the cases where I'd avoid using goto. The extra computation is not in hot path and will be unnoticeable. Thanks. -- Dmitry