From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4E723806C4 for ; Sun, 12 Jul 2026 08:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783845654; cv=none; b=XsfRcauzRF0rXWYc/d8F1i2p4pHEOLyB6B04Mb3sQW00a15YuRMOTEsVEO+NIVSJfZ9yXrR56JyVXcPnROTbFAkWoi5TOElT8QG2TyD8wzqIRU8sS0oirz/pst1EA85D26Sxzk8ioba0Y+DZSk0nT513ObtPx4ocJTST5ZbYOE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783845654; c=relaxed/simple; bh=Z31Ftg0Pmc/qZmgzofFaoCkIVc+T6kMM3xqLcclhg4I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E4EfqrlgZEveb594o2VFNLdl5Z5AFHqwVTJxIEY+AmbMZAqlqvRavTgJIrlz79liR90+oqGDhXUM8EYN9FmA0nIfXGQNO0eImDm37QNPIuaRlGrdTLqdrdsqgWAMJPej3SvF/FcYcgtp86ZMvmoKi4wf1UXVz8gI/8bMmOzHmsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: by Chamillionaire.breakpoint.cc (Postfix, from userid 1003) id C0B5560225; Sun, 12 Jul 2026 10:40:47 +0200 (CEST) Date: Sun, 12 Jul 2026 10:40:47 +0200 From: Florian Westphal To: Greg KH Cc: netfilter-devel@vger.kernel.org Subject: panic_on_warn and lack of lesser-WARN (was: Re: [PATCH nf] netfilter: nf_nat: do not reuse an unexpected expectation on RTCP clash) Message-ID: References: <2026071134-turkey-detonator-0d87@gregkh> <178377968720.33756.12204817361601593230@proton.me> <2026071235-geometric-snowdrift-bb4c@gregkh> <2026071249-contented-gallantly-2927@gregkh> <2026071210-grid-runaround-4318@gregkh> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026071210-grid-runaround-4318@gregkh> Greg KH wrote: > > > True, but adding new ones is not a good idea, and removing the existing > > > ones is a good idea. > > > > We're fucked, then. Can we at least use DEBUG_NET_WARN or something > > like that so at least fizzers can give us hints about bugs?! > > That's up to you. If panic_on_warn wasn't an option, about half of the > kernel CVEs would disappear tomorrow. That explains your WARN() allergy, I can relate to that. Its a shame there is nothing like WARN_BENIGN() or similar that doesn't panic even with panic_on_warn=1. I get some people really want s/WARN/BUG at run time for things like "this list is corrupted" or "you tried refcount_inc() on a 0 refcount". But even for "this refcount is saturated" I don't get why you want to crash the system right away. Feels a bit like setting your car on fire because the side window was slightly dirty :-)