From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31D05399346 for ; Mon, 13 Jul 2026 07:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929403; cv=none; b=TKb4I6e2DjB2678+ZBD3ncXjGNyHVtt4+8dmN0otx2dNJWRE5MSAY5Amqls3jIQ3+zOkxjDvOSbn90rwhdet1/W2hSCccckaNyW2zbw87HahXIQyh967OkOH9ohjkkW9TFL/pLqPDsUZzXHT50+reT+bjUFIXao8dL7VHipcMF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783929403; c=relaxed/simple; bh=aL01UCz5oQh/DomQ8SNmfwxRa+JNQ30Xd1UyAslLPSY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fOgD5I70eL2xivfmYema2ZxFIx3XXe+Bl/zlEiwArLejunhVRoAmPeMl4Q14qU3eNEkq9oCAeCqZizfa066Sm6a55FWZQb1rsdeayEB6iNWPo3M8Yau/WQHjTnGqo3ju2U+nl/heIh3wG/1xDcLHNjvua9CVqAaxxi3qYTKVSgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rkfhlj//; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rkfhlj//" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-455a61c53d3so480752fac.2 for ; Mon, 13 Jul 2026 00:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783929401; x=1784534201; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=P0vsxLxBBBbTIPap5RklVXU/DWovFUXWDEGWzYh+JAg=; b=rkfhlj//bq8xeZLTAfDB4hi63m6A6b25LrvI3ntebpF08NUAcoej8os5A0wttRhkGZ klv8rwwOuon9OQP08oaHw2mRgl10kEBe045PvtfCRm9DpdRXnIBIBpQTEcrr2RjWGVWX TTNEV2Iu7vv3kWnPpJQ9EI3lRRilY+ARQv5VUbnYM5nNVh8sb8ccs6k6kyQw1xVLocZi Lb0FfP3v0zDQnPyMs26d/fItBkIFJordkrPTxnW+4jtelLGvglVmEHEHfJTvaH3WQChe /bPoRYriCDd+TW6m6++TJ3nPyA/FkEWWEU9aln8FFAWN2bJOJzu6RhOV9mC9+NNSwArT 5WBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783929401; x=1784534201; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=P0vsxLxBBBbTIPap5RklVXU/DWovFUXWDEGWzYh+JAg=; b=mj6C7H5+I6vloG+NHz0m3Tjf2rS+9wHzohNIamYvUTQQrjEoy4D2kTnPf97EbCb4sF KMgWuj2vUgrfVXoolI2buD1RdptoNGzcOjbKJMSEDHxI4b9DDA+ROsyUYk/d389oadc2 X0PsAlOBrx2q57DHdfTeJNGBiyOcFmmFTY4xbnPV6EdokxTOSk1QzKhB6myIucdpoGaa ize25sFJ6mO4hfqEBCmDK8PDlPIQavUaKyDPR8LlWaIzJHBySkN+Jip46WwoSi9N221i xRGChRyyrKCb5EQPwFs9rxvztJLJDDcUzS34TRZwdc9ZhJ3MQ3Ntw/zOpXvQyBs+LuSc 2l/w== X-Forwarded-Encrypted: i=1; AFNElJ9Bl2Y+TyGbiTWCEWxVPipPOk6BPusAsQXydIkjUx1gAXwKWEAf7Vnq/+mE64zDcvqWdm5eRhdjciz/JkE=@vger.kernel.org X-Gm-Message-State: AOJu0YzV96CfD4BTNLKj7PS2E+8MJYlCXCwb2MXf0V9iXm6LiA9EYPcD 6djc4mPqr5p8h6WJPVXlsj7R9XDJIfOEmskA8gF2UkfypjxH3aNVIwTA X-Gm-Gg: AfdE7cnI8O8oo4xBdBJeKxGBF46gKkVvA4OZ3DmCi8BMrEC4rRBLbkCXMzYMEUViplD 2rVQCjTxc5+by4xIp1AzjhwY7+nTUuhu+bRJBkUe/gpIdi9Or5J2N9FGi/zeRD/twf7T66pwyh2 nX+4C7Ia3WHmfGQZBP090r3miO0R+6XsHJzejU7QplkJkZM/Dc4UOmTsW8txD6mKmT1KHp40knE T0eISlJMTq713AuIZe9OnJU/2tXzl2IvC6JlMa2cKZNq2EkcJmOHyVemIkVKwINv1pKhNXUnwiz O50Z4Dib4epNQ2+W10UeFrVZDC2/O5oY0sVamylyNUx03o0QaTEw/QsxkEOvelpmFHkNJWOBXjh 2FZELBw8aASw1by6uwhXZIdFZXYzE24XE88hoCZjZeOug3XvHASEvf0pqIDbuaqTq4C1PcbJ56f GnrF96 X-Received: by 2002:a05:6871:780b:b0:44a:e523:aff2 with SMTP id 586e51a60fabf-451f12a69a9mr4363394fac.23.1783929401136; Mon, 13 Jul 2026 00:56:41 -0700 (PDT) Received: from localhost ([74.80.182.78]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-451a7c8fe33sm11393098fac.0.2026.07.13.00.56.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 00:56:38 -0700 (PDT) Date: Mon, 13 Jul 2026 10:56:32 +0300 From: Dan Carpenter To: Viresh Kumar Cc: Zhongqiu Han , Deepak Sikri , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] cpufreq: Fix an IS_ERR() vs NULL bug in spear1340_set_cpu_rate() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 13, 2026 at 09:31:12AM +0530, Viresh Kumar wrote: > On 12-07-26, 21:30, Zhongqiu Han wrote: > > On 7/11/2026 3:34 AM, Dan Carpenter wrote: > > > The clk_get_parent() function doesn't return error pointers, it returns > > > NULL on error. Update the error checking to match. > > origin/master:include/linux/clk.h > > /** > * clk_get_parent - get the parent clock source for this clock > * @clk: clock source > * > * Returns struct clk corresponding to parent clock source, or > * valid IS_ERR() condition containing errno. > */ > struct clk *clk_get_parent(struct clk *clk); > > I think this is the source of the confusion. > I'll send a separate patch to update that documentation. regards, dan carpenter