From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 223BEC43458 for ; Mon, 13 Jul 2026 08:33:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjC6E-0007b4-CD; Mon, 13 Jul 2026 04:33:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjC6C-0007TR-Hy for qemu-devel@nongnu.org; Mon, 13 Jul 2026 04:33:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjC69-0002I0-Lj for qemu-devel@nongnu.org; Mon, 13 Jul 2026 04:33:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783931587; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfAW90pXU1HRhrfUcUTUz1H0V5GyfUF4rZWOBSAZYgk=; b=dft8RMmCidssOqdM/oab37lNw6G70oK01nI/dTe9/BPx/PcGjNdLKWxwPcX+oXqU7oum+v mVsoT0aFj5/mpAbMD0cdJR14HSpUHqTckNxVnKORZboYvo/yrOV0IBcQDjyxI1LIpQqiCh FF5ONY54Eeu1YSC1cI62fEPKOK4BNXg= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-U7XbEv5QPni-7ZDBXXxbMg-1; Mon, 13 Jul 2026 04:33:04 -0400 X-MC-Unique: U7XbEv5QPni-7ZDBXXxbMg-1 X-Mimecast-MFC-AGG-ID: U7XbEv5QPni-7ZDBXXxbMg_1783931583 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B99DA18052C1; Mon, 13 Jul 2026 08:33:02 +0000 (UTC) Received: from redhat.com (unknown [10.44.50.22]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 596DC30001A1; Mon, 13 Jul 2026 08:33:00 +0000 (UTC) Date: Mon, 13 Jul 2026 09:32:56 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, Paolo Bonzini , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "Edgar E . Iglesias" Subject: Re: [PATCH v2 2/4] tests/docker: add support for podman remote access Message-ID: References: <20260210163556.713841-1-berrange@redhat.com> <20260210163556.713841-3-berrange@redhat.com> <947a4843-34ae-43f7-8fbc-80109bc0c077@oss.qualcomm.com> <87ldbjqd67.fsf@draig.linaro.org> <2bbe43b8-2654-40f3-ac7f-c68ab6ebdcce@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2bbe43b8-2654-40f3-ac7f-c68ab6ebdcce@oss.qualcomm.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: permerror client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Jul 10, 2026 at 11:20:37AM -0700, Pierrick Bouvier wrote: > On 7/10/2026 4:52 AM, Daniel P. Berrangé wrote: > > On Fri, Jul 10, 2026 at 12:47:28PM +0100, Alex Bennée wrote: > >> Daniel P. Berrangé writes: > >> > >> (added Edgar for Microblaze) > >> > >>> On Thu, Jul 09, 2026 at 09:24:12AM -0700, Pierrick Bouvier wrote: > >>>> On 7/9/2026 9:13 AM, Daniel P. Berrangé wrote: > >>>>> On Thu, Jul 09, 2026 at 07:48:14AM -0700, Pierrick Bouvier wrote: > >>>>>> On 2/10/2026 8:35 AM, Daniel P. Berrangé wrote: > >>>>>>> When a developer's environment is already within a podman container it > >>>>>>> is not possible to use 'podman' again to create containers. It will > >>>>>>> usually result in wierd errors such as: > >>>>>>> > >>>>>>> Error: fatal error, invalid internal status, unable to create a new pause process: cannot re-exec process to join the existing user namespace. Try running "podman system migrate" and if that doesn't work reboot to recover > >>>>>>> > >>>>>>> Podman offers the ability to talk to a daemon outside the container, > >>>>>>> however, which could be leveraged by QEMU. > >>>>>>> > >> > >>>>>> Taking a look at why tcg tests are slow to compile, I reached this > >>>>>> commit. It seems like that calling 'podman info' is 5 to 10 times slower > >>>>>> than calling 'podman version'. > >>>>>> Thus, a container run now takes +1s when it was 0.2 before. > >>>>> > >>>>> Hmmm, but we call 'docker.py probe' in configure and cache the result, > >>>>> so that probe should only be done once. 0.2 vs 1s is just noise in > >>>>> the context of configure. > >>>>> > >>>>> That you're seeing any negative effects suggests that we've got > >>>>> something not using the cached probe result, which we should fix. > >>>>> > >>>> > >>>> Not really, docker.py --engine X still calls X info. > >>>> > >>>> https://gitlab.com/qemu-project/qemu/-/blob/master/tests/docker/docker.py#L675 > >>>> https://gitlab.com/qemu-project/qemu/-/blob/master/tests/docker/docker.py#L78 > >>>> > >>>> Maybe the fix is to remove the check if user specified an explicit > >>>> engine. But in this case, there is a problem with podman-remote not > >>>> being detected anymore. > >>>> > >>>> We can fix this by introducing engine=podman-remote, and skip the check > >>>> if engine is explicitly set. > >>>> What do you think? > >>> > >>> Urgh, so i see now we have two code paths / make variables > >>> > >>> RUNC=podman --remote > >>> CONTAINER_ENGINE=auto > >>> > >>> Sometimes we'll invoke docker.py --engine $(CONTAINER_ENGINE) > >>> and sometimes we'll directly invoke $(RUNC). > >> > >> Yeah that could do with cleaning up. I suspect the only places we > >> actually still need the script is where we are doing binfmt_misc enabled > >> containers unless there is a way to emulate the copying of qemu into the > >> container with a plain call? Maybe all the systems now have the > >> persistent flags which would skip this. > > > > Yeah, I'd be inclined to say this is a job for the distros to have > > qemu-user integration, and simplify our life. THe docker.py script > > always confuses me. We could choose podman vs podman --remote vs > > docker simply in the meson.build file, as we do for other dev env > > choices. > > > >> The toolchain case could be skipped if we could find hosted compilers > >> for microblaze. However I do see we have a patch in there. > >> > >>> > >>> The result of "probe" cannot be fed back in to "--engine" which > >>> is a bit of a mess. I think the "engine" concept should not be > >>> exposed on the cli, and instead have a "--runc" arg which takes > >>> the full arg(s), since we need probe to report the runc args > >>> for other reasons. > >>> > >>> With regards, > >>> Daniel > >> > >> -- > >> Alex Bennée > >> Virtualisation Tech Lead @ Linaro > >> > > > > With regards, > > Daniel > > Is it me or did we incredibly derailed from original issue which was: > "It was fast to query which container engine is available, and now it's > 5-10 times slower to accommodate toolbox workflow where podman is > available but not really available?" > I agree it's sad to have several ways to set container engine, but it's > absolutely not related to the current issue. It is relevant because that difference in speed is not something that should be noticable unless something is repeatedly probing over & over again which should not be done. > Daniel, since you introduced the slow check path with podman info for > your personal need, I would appreciate if it's something you could fix also. I'll looking into the missing caching. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|