From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-eh: make ata_eh_qc_complete() and ata_eh_qc_retry() static
Date: Mon, 13 Jul 2026 10:17:52 +0200 [thread overview]
Message-ID: <alSfMHUAzBoitCI7@fedora> (raw)
In-Reply-To: <20260713050942.576415-1-dlemoal@kernel.org>
On Mon, Jul 13, 2026 at 02:09:42PM +0900, Damien Le Moal wrote:
> The functions ata_eh_qc_complete() and ata_eh_qc_retry() are used only in
> libata-eh.c. So remove the declaration of these functions from
> include/linux/libata.h and define them as static. While at it, add a
> missing blank line between variable declaration and code in these two
> functions.
>
> No functional changes intended.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
prev parent reply other threads:[~2026-07-13 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 5:09 [PATCH] ata: libata-eh: make ata_eh_qc_complete() and ata_eh_qc_retry() static Damien Le Moal
2026-07-13 8:17 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alSfMHUAzBoitCI7@fedora \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.