From: Alice Ryhl <aliceryhl@google.com>
To: FUJITA Tomonori <tomo@flapping.org>
Cc: a.hindborg@kernel.org, arve@android.com, boqun@kernel.org,
brauner@kernel.org, cmllamas@google.com, gary@garyguo.net,
gregkh@linuxfoundation.org, ojeda@kernel.org, tkjos@android.com,
acourbot@nvidia.com, anna-maria@linutronix.de,
bjorn3_gh@protonmail.com, dakr@kernel.org,
daniel.almeida@collabora.com, frederic@kernel.org,
jstultz@google.com, lossin@kernel.org, lyude@redhat.com,
sboyd@kernel.org, tamird@kernel.org, tglx@kernel.org,
tmgross@umich.edu, work@onurozkan.dev,
rust-for-linux@vger.kernel.org,
FUJITA Tomonori <fujita.tomonori@gmail.com>
Subject: Re: [PATCH v2 3/4] rust: workqueue: use Delta for enqueue_delayed's delay parameter
Date: Mon, 13 Jul 2026 08:59:56 +0000 [thread overview]
Message-ID: <alSpDAILCIIU4q7u@google.com> (raw)
In-Reply-To: <20260712235246.3069713-4-tomo@flapping.org>
On Mon, Jul 13, 2026 at 08:52:45AM +0900, FUJITA Tomonori wrote:
> From: FUJITA Tomonori <fujita.tomonori@gmail.com>
>
> enqueue_delayed() took a raw jiffies count (a plain c_ulong alias with
> no type safety), so callers had to know on their own that the value
> meant jiffies and convert to/from it themselves. This mirrors the
> issue already fixed for CondVar's wait_interruptible_timeout().
>
> Switch to Delta, the duration type already used elsewhere, so the
> unit is part of the type instead of a caller convention.
>
> Use as_jiffies_ceil() rather than a plain truncating conversion:
> queue_delayed_work_on() treats a delay of 0 jiffies as "enqueue
> immediately", so truncating a small nonzero Delta down to 0 would
> silently turn a requested delay into no delay at all.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
It seems unfortunate that a caller might be forced to convert jiffies ->
nanos -> jiffies if they already have the value in jiffies.
Alice
next prev parent reply other threads:[~2026-07-13 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 23:52 [PATCH v2 0/4] rust: use Delta instead of raw jiffies for timeouts and delays FUJITA Tomonori
2026-07-12 23:52 ` [PATCH v2 1/4] rust: time: add jiffies conversion helpers to Delta FUJITA Tomonori
2026-07-12 23:52 ` [PATCH v2 2/4] rust: sync: use Delta for CondVar timeout API FUJITA Tomonori
2026-07-12 23:52 ` [PATCH v2 3/4] rust: workqueue: use Delta for enqueue_delayed's delay parameter FUJITA Tomonori
2026-07-13 8:59 ` Alice Ryhl [this message]
2026-07-13 9:07 ` Onur Özkan
2026-07-13 9:40 ` FUJITA Tomonori
2026-07-13 11:55 ` Gary Guo
2026-07-13 12:17 ` FUJITA Tomonori
2026-07-12 23:52 ` [PATCH v2 4/4] rust: time: remove unused Jiffies/Msecs helpers FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alSpDAILCIIU4q7u@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=anna-maria@linutronix.de \
--cc=arve@android.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jstultz@google.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tamird@kernel.org \
--cc=tglx@kernel.org \
--cc=tkjos@android.com \
--cc=tmgross@umich.edu \
--cc=tomo@flapping.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.