From: Jan Maslak <jan.maslak@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH 09/11] lib/rendercopy: Convert pipeline emit commands to genxml
Date: Mon, 13 Jul 2026 11:26:49 +0200 [thread overview]
Message-ID: <alSvWQGtgJAYsEfS@ART-DEV-395> (raw)
In-Reply-To: <jqde5hdoyqor6snkirq3xgs3itsrceiqumjprsvgf4qre5k4fu@dr6gzlzobn3k>
> There's only one nit I got for this patch. Why HAS_4TILE() is necessary
> and > 12 is not enough? Have CI complained without this before?
Both plain Gen12 LP (TGL/ADL/DG1) and Gen12.5 (DG2/ATS-M/MTL) return intel_gen() == 12.
Gen12 LP wants GFX11 STATE_BASE_ADDRESS, while Gen12.5 platforms want GFX125.
We need to differentiate between the two, and HAS_4TILE() is a way to do that.
Pre-genxml code also used this logic for differentiation so I kept it for consistency.
No CI failures were tied to it either way.
--
Jan
next prev parent reply other threads:[~2026-07-13 9:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 3:50 [PATCH 00/11] lib/genxml: Introduce Mesa genxml infrastructure to IGT Jan Maslak
2026-06-22 3:50 ` [PATCH 01/11] lib/intel/genxml: Add genxml generators, headers, and build integration Jan Maslak
2026-06-22 3:50 ` [PATCH 02/11] lib/intel/genxml: Import gen4-gen8 XML hardware definitions from Mesa Jan Maslak
2026-06-22 3:50 ` [PATCH 03/11] lib/intel/genxml: Import gen9-gen12.5 " Jan Maslak
2026-06-22 3:50 ` [PATCH 04/11] lib/intel/genxml: Import Xe2/Xe3/Xe3p " Jan Maslak
2026-06-22 3:51 ` [PATCH 05/11] lib/intel_bufops: Add intel_buf_mocs() helper Jan Maslak
2026-06-22 3:51 ` [PATCH 06/11] lib/mocs: Add packed MOCS helpers Jan Maslak
2026-06-22 3:51 ` [PATCH 07/11] lib/rendercopy: Convert surface state and sampler setup to genxml Jan Maslak
2026-06-26 8:34 ` Zbigniew Kempczyński
2026-06-22 3:51 ` [PATCH 08/11] lib/rendercopy: Convert vertex data and CC state " Jan Maslak
2026-06-26 8:59 ` Zbigniew Kempczyński
2026-06-22 3:51 ` [PATCH 09/11] lib/rendercopy: Convert pipeline emit commands " Jan Maslak
2026-06-26 9:11 ` Zbigniew Kempczyński
2026-07-13 9:26 ` Jan Maslak [this message]
2026-06-22 3:51 ` [PATCH 10/11] lib/rendercopy: Convert render op and entry points " Jan Maslak
2026-06-26 9:13 ` Zbigniew Kempczyński
2026-06-22 3:51 ` [PATCH 11/11] lib: Add genxml annotated batch buffer decode Jan Maslak
2026-06-26 9:19 ` Zbigniew Kempczyński
2026-06-22 19:39 ` ✓ Xe.CI.BAT: success for lib/genxml: Introduce Mesa genxml infrastructure to IGT (rev6) Patchwork
2026-06-22 19:45 ` ✓ i915.CI.BAT: " Patchwork
2026-06-23 0:35 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-23 1:50 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alSvWQGtgJAYsEfS@ART-DEV-395 \
--to=jan.maslak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.