From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Munkhbaatar Enkhbaatar <munkhuu0825@gmail.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH] hw/usb/hcd-ohci: Make sure that ohci_service_ed_list() cannot loop forever
Date: Mon, 13 Jul 2026 17:23:11 +0100 [thread overview]
Message-ID: <alUQ71c_k5VehJD-@redhat.com> (raw)
In-Reply-To: <20260713160458.343323-1-thuth@redhat.com>
On Mon, Jul 13, 2026 at 06:04:58PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> The inner while loop in ohci_service_ed_list() could theoretically
> loop forever if a malicious guest prepares a set of bad descriptors.
> Add a check to the loop to avoid this situation.
>
> Reported-by: Feifan Qian <bea1e@proton.me>
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3781
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/usb/hcd-ohci.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
prev parent reply other threads:[~2026-07-13 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 16:04 [PATCH] hw/usb/hcd-ohci: Make sure that ohci_service_ed_list() cannot loop forever Thomas Huth
2026-07-13 16:23 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alUQ71c_k5VehJD-@redhat.com \
--to=berrange@redhat.com \
--cc=munkhuu0825@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.