Re: [PATCH v1 1/3] perf sched: Add missing perf_session__delete()

[Namhyung Kim <namhyung@kernel.org>]

On Mon, Jul 13, 2026 at 08:59:07PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The patch introduces a double close of the file descriptor `fd` because `perf_session__delete(session)` inherently closes it before the explicit `close(fd)`.
> --
> 
> --- Patch [1]: [PATCH v1 1/3] perf sched: Add missing perf_session__delete() ---
> commit 2da9bd6a7ce8e17e442d8be81b1b57837aaee6e1
> Author: Namhyung Kim <namhyung@kernel.org>
> 
> perf sched: Add missing perf_session__delete()
> 
> This patch addresses an ASAN-reported memory leak in the perf sched stats
> record command by explicitly deleting the session before returning.
> 
> > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> > index 6e0d8f4d270e2..68147a0be5c71 100644
> > --- a/tools/perf/builtin-sched.c
> > +++ b/tools/perf/builtin-sched.c
> > @@ -4027,6 +4027,7 @@ static int perf_sched__schedstat_record(struct perf_sched *sched,
> >  	else
> >  		fprintf(stderr, "[ perf sched stats: Failed !! ]\n");
> >  
> > +	perf_session__delete(session);
> >  	evlist__put(evlist);
> >  	close(fd);
> 
> [Severity: Medium]
> Does adding perf_session__delete() result in closing the file descriptor twice?
> 
> Since perf_session__delete() internally closes the file descriptor associated
> with the session data, the subsequent explicit close(fd) will attempt to
> close it again. This could return EBADF or erroneously close an unrelated
> file descriptor if another thread opens a file in the meantime.

Hmm.. looks right.  I think I can just remove the close().

Thanks,
Namhyung