From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6861BC43458 for ; Tue, 14 Jul 2026 08:47:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjYnf-0006vj-DQ; Tue, 14 Jul 2026 04:47:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjYnV-0006v5-Qx for qemu-devel@nongnu.org; Tue, 14 Jul 2026 04:47:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjYnQ-0003IA-EB for qemu-devel@nongnu.org; Tue, 14 Jul 2026 04:47:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784018839; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=j19jvw+BnhEGZifgQmQ5oQdqvpZXcNwgifkCwiuB1b4=; b=fCrNXvwje4dXKiAng3GJA0hSQGysvrLhF97Ocbu6IVuAern7Xn26GMUsl7834eWIvfRied CO4ES1DX95bOd377VMWq7KMj2Irxwk1ROcvkX8DgKQRhDSYMSpnihK71BBEJlnaEsf9K+7 ntulnxtpQFvuiKZr/d/bzWkxHi+NJhQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-WMXnxL99P3yOmJduoJkIHQ-1; Tue, 14 Jul 2026 04:47:15 -0400 X-MC-Unique: WMXnxL99P3yOmJduoJkIHQ-1 X-Mimecast-MFC-AGG-ID: WMXnxL99P3yOmJduoJkIHQ_1784018834 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C08D8180047F; Tue, 14 Jul 2026 08:47:13 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.163]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E26611800361; Tue, 14 Jul 2026 08:47:07 +0000 (UTC) Date: Tue, 14 Jul 2026 09:47:04 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Jamin Lin Cc: =?utf-8?Q?C=C3=A9dric?= Le Goater , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Eric Blake , Markus Armbruster , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:All patches CC here" , "open list:ASPEED BMCs" , Troy Lee Subject: Re: [PATCH v1 00/15] Support the ASPEED HACE crypto command Message-ID: References: <20260714072900.3023742-1-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260714072900.3023742-1-jamin_lin@aspeedtech.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: permerror client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jul 14, 2026 at 07:29:01AM +0000, Jamin Lin wrote: > qapi/crypto.json | 4 +- > crypto/cipherpriv.h | 8 + > include/crypto/cipher.h | 36 + > include/hw/misc/aspeed_hace.h | 1 - > tests/qtest/aspeed-hace-utils.h | 20 + > crypto/cipher.c | 32 + > hw/misc/aspeed_hace.c | 454 +++++++++++- > tests/qtest/aspeed-hace-utils.c | 662 ++++++++++++++++++ > tests/qtest/aspeed_hace-test.c | 18 + > tests/qtest/ast2700-hace-test.c | 9 + > tests/unit/test-crypto-cipher.c | 240 +++++++ > crypto/cipher-gcrypt.c.inc | 101 +++ Both nettle and gnutls also support GCM mode, so can you impl those too. > .../aarch64/test_aspeed_ast2700a1.py | 5 - > .../aarch64/test_aspeed_ast2700a2.py | 5 - > .../aarch64/test_aspeed_ast2700fc.py | 5 - > 15 files changed, 1563 insertions(+), 37 deletions(-) > > -- > 2.43.0 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|