From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 109063EE1F2 for ; Tue, 14 Jul 2026 07:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784014645; cv=none; b=kIf0QnztoaZaztOFU1cE/qdv8ubBf4UNOes2AzJ1/vJBVoNz2DSzGEB5GG2H2QJv2LVjUSVnqtxK1kxrAq3tQhTIo+hccDOjzWlMlZISJDkTBrcodHnjW0eoboNtJTT4+cS8U4C03rgofyd/8zj6IB9qtGmePUvOlKlWobW98Dk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784014645; c=relaxed/simple; bh=JNaplmwtLRxCCsPbnwvbEje4USEdmIzQ0+Jn+jtWBa4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QNg92gAWJQZLpzHHjgsX3PbJSGp8qs/oiCx5doSIvhC2OsFKMSD8eMgMIHyPR4tlp9+ngeE2+V3BUEbj0nBgc2yguFTmg8/HMTlxuPszqHTFKDcknnv5NAryi2fW991m2KxqBiAY2/Gm9ux0Nsv5Y2YjeJDpZLPfdmFTrc1ZVYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ShtfrnrC; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ShtfrnrC" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2ccdf36f63dso88205ad.0 for ; Tue, 14 Jul 2026 00:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784014643; x=1784619443; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qxPrq/QLaw64AHuPTEEH4v8WBZAurPWVIQauUM2RcxE=; b=ShtfrnrCz8YEWfbaJ9WFT0ikNQQiP4qNOQUhPYnnaI5yX75Jo6MONMxc9GQ/1+bdPt zT65eIS8x1iJKyfhpYh/BNYZ4NS7FVaickRcsUV9kvoJHmmbtceVNmX3oe54uqtQPnMn qcKuDlRhqgoW39YyM/PYmXdkbXNqmd1SBMAyo0xoeMPrlYy4C7M4fLDZQdy/R7UgNHtp 0XssdUjwNeVwtEFbniFGqRFm7jq97q0DAkXn5OfgTD4Njpf8RqnBTE3dkpwBSL3Y/FBF NtcAIXmvayvQHJW3XaGXRGr6Vo1DyTj3Hn6z4XI0slJsjeArZsFgX64kq9Hc1N519j/f Q3GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784014643; x=1784619443; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qxPrq/QLaw64AHuPTEEH4v8WBZAurPWVIQauUM2RcxE=; b=JdsfCtisJ1m2eMat0IL+epplFonJfv8Z5YbC+tel3AfcWyPziT8qAFujLLV/23zlMz itK/tcEH8Uji6ikApLkgi0Vf7Bt4aU6McNOgCTtq02vnf1Oor8eCj7X2gE2cQdt/2ouS d4KrUYKNi5qjEKhqVtJicuOzyx6WImctHAsNMTTpcZ5MLOerVaj3pNJybbkuDrzaqjmd ZA9EzmyvWlmruQaQ2I5gNGVWFOy4evTBCrsIil4L3QDCmjODeVXm2DoeZ+qABX/7ghaD X6jAucHD+XYTc4ZLrn4zjS54ZdqqTg0nG8bgqsNobspXGMqh1xDIEoiy9msURtfEs1KU 8kHA== X-Forwarded-Encrypted: i=1; AHgh+RreJwpk2jWAk03JO88yltvPGRe72d4ewidNYa0/56dAj+p3+HDORFpBcYA2aX5vzdffLSUcywusNx+JYfE=@vger.kernel.org X-Gm-Message-State: AOJu0YwVC3ZPMlfRK1h0SkXtkNnG2lHoG6WXAKBGyRqIvL1jhKRDIpDA kqP9Uqye9JaUz8djTurkb66Aq0W5JpPHO5ZMEJsFA0es/S2jFOqHkCDwFTqptq+ymw== X-Gm-Gg: AfdE7clj7hn6i9BHLhGNFspBMq4wDco9HRJLZYdw54QMEk0uXXXX8RK1+CW3kVXmMxZ ve2pIj2mt0p3XVMRdnoUtKs1HmFOfRde6eDAazkdOhVAwp8XRGLBnOUEu/C4EKlVfHVvO9Vve8V /t2WVDDfWeXZHpQgB9LGoP5K1dW+GWCI/UfCP/anyokDVtT9wUYcEWYxS+VseDgM14hJdrcEJys wJQqyOhHSpPEECV1wCyeQdK0s3O84/aOTKcCp9UOvlLk0kRV0x7c/Qo6QnRdAgP299b3FbgImW6 Aj/AzC21wuDVppTztGQ9izlWvLl3uZkgFL7KIs2G9NbjmDYYcPgdstsT5mF56ZWIBatdwB8OyQ+ j2ELpSIn9gZuRzQcYP8la+E2PNPqOF0ha283Qz8a+Kj63ktChZVNZujpaiQ7P2X9oHFTlvXBlBZ Z6a4TCqv0GAXSn1hAzWniOh4QztmiBAAkzTe+DD45MFMjuUNw= X-Received: by 2002:a17:902:c952:b0:2bf:1000:d3ac with SMTP id d9443c01a7336-2cee16bf99fmr4874315ad.11.1784014642830; Tue, 14 Jul 2026 00:37:22 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f7dc7ffsm1022895b3a.40.2026.07.14.00.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 00:37:21 -0700 (PDT) Date: Tue, 14 Jul 2026 07:37:15 +0000 From: Pranjal Shrivastava To: Marek Szyprowski Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Leon Romanovsky , Robin Murphy , Lu Baolu , Luis Chamberlain , Bjorn Helgaas , Logan Gunthorpe , Christoph Hellwig , Li RongQing Subject: Re: [PATCH] dma-direct: Improve readability of the dma_direct_map_sg() for P2PDMA case Message-ID: References: <20260713083022.1110993-1-m.szyprowski@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260713083022.1110993-1-m.szyprowski@samsung.com> On Mon, Jul 13, 2026 at 10:30:22AM +0200, Marek Szyprowski wrote: > Improve readability of the sg_dma_len assignment in the P2PDMA cases by > removing duplicated code, which was a direct result of the d0d08f4bd7f6 > ("dma-direct: Fix missing sg_dma_len assignment in P2PDMA bus mappings") > fix. No functional change. > > Suggested-by: Leon Romanovsky > Link: https://lore.kernel.org/all/20260604071856.GA245424@unreal/ > Signed-off-by: Marek Szyprowski > --- > kernel/dma/direct.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 4391b797d4db..d8219efe3273 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -486,15 +486,14 @@ int dma_direct_map_sg(struct device *dev, struct scatterlist *sgl, int nents, > goto out_unmap; > } > break; > case PCI_P2PDMA_MAP_BUS_ADDR: > sg->dma_address = pci_p2pdma_bus_addr_map( > p2pdma_state.mem, sg_phys(sg)); > - sg_dma_len(sg) = sg->length; > sg_dma_mark_bus_address(sg); > - continue; > + break; > default: > ret = -EREMOTEIO; > goto out_unmap; > } > sg_dma_len(sg) = sg->length; > } Reviewed-by: Pranjal Shrivastava Thanks, Praan