All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Mikko Perttunen <mperttunen@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	 Jonathan Hunter <jonathanh@nvidia.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-pwm@vger.kernel.org,  linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	 Thierry Reding <treding@nvidia.com>,
	Yi-Wei Wang <yiweiw@nvidia.com>
Subject: Re: [PATCH v6 0/7] Tegra264 PWM support
Date: Tue, 14 Jul 2026 11:35:20 +0200	[thread overview]
Message-ID: <alYBz2PVs7hCsR91@monoceros> (raw)
In-Reply-To: <20260701-t264-pwm-v6-0-2718f61f411f@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

Hello,

On Wed, Jul 01, 2026 at 12:20:29PM +0900, Mikko Perttunen wrote:
> this adds support for the PWM controller on Tegra264. The controller
> is similar to previous generations, but the register fields are
> widened, the depth is made configurable, and the enable bit moves
> to a different spot.
> 
> This series adds only basic support with fixed depth -- configurable
> depth will come later.
> 
> Patch 1 adds device tree bindings for Tegra264 PWM (compatible
>   string).
> 
> Patch 2 prefixes driver-local macros and static helpers with
>   tegra_/TEGRA_ to make their scoping clear.
> 
> Patches 3 to 6 contain the PWM driver changes for Tegra264.
> 
> Patch 7 adds device tree nodes for the PWM controllers on Tegra264.

I'm not entirely happy with the driver (as already pointed out during
review of earlier revisions of this series), but it's an improvement.

I'll take a look to improve the things that annoy me in this driver and
I didn't want to do that on the current state which would make it
necessary to respin your changes.

So I applied patches #1 to #6 to
	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
.

I assume patch #7 will go via armsoc? If I should take this, too, please
tell me.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2026-07-14  9:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01  3:20 [PATCH v6 0/7] Tegra264 PWM support Mikko Perttunen
2026-07-01  3:20 ` [PATCH v6 1/7] dt-bindings: pwm: Document Tegra264 controller Mikko Perttunen
2026-07-01  3:20 ` [PATCH v6 2/7] pwm: tegra: Prefix driver-local macros and functions Mikko Perttunen
2026-07-01  3:20 ` [PATCH v6 3/7] pwm: tegra: Avoid hard-coded max clock frequency Mikko Perttunen
2026-07-01  3:36   ` sashiko-bot
2026-07-01  3:20 ` [PATCH v6 4/7] pwm: tegra: Modify read/write accessors for multi-register channel Mikko Perttunen
2026-07-01  3:20 ` [PATCH v6 5/7] pwm: tegra: Parametrize duty and scale field widths Mikko Perttunen
2026-07-01  3:20 ` [PATCH v6 6/7] pwm: tegra: Add support for Tegra264 Mikko Perttunen
2026-07-01  3:30   ` sashiko-bot
2026-07-01  3:20 ` [PATCH v6 7/7] arm64: tegra: Add PWM controllers on Tegra264 Mikko Perttunen
2026-07-07 10:57 ` [PATCH v6 0/7] Tegra264 PWM support Jon Hunter
2026-07-14  9:35 ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alYBz2PVs7hCsR91@monoceros \
    --to=ukleinek@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=treding@nvidia.com \
    --cc=yiweiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.