From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51CD947B42F for ; Tue, 14 Jul 2026 14:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784038851; cv=none; b=DeQxlDNq4XU3uFwMpJtnhNf+AGTccA1/8sEimzmRwDWRd7t0bL7caJS0V9xIeIrB78X5mNmk0ybXFbtrgqqrP7ADLOFvJR0Tg6DxFDa77T5i0EkDwfmZ+VcFBMzJA8eSFAAfB/KwQDzIr5FJSMCEIV27WzlkK4eQOeC7ixsrFCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784038851; c=relaxed/simple; bh=ADFj06N0oqMVyrdNJZj5pfnva5x2yOwJyQdtFUKGENE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CCvIJQGi6tskT0NRr61JgS8SU1PGWqBU2GF5zQpoKQK7r/g3/f68MybCII4cqvpLvepTMJC8wI+sDZW8X4QjyPsw65E95bgctuxlZiwIi6KMW0+fgx/QmGKa3L08VQOhVPjMFg9yHHdo8oMRJLrxx4CYXrvA7NTyUTEmO+TtBHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oSjuewk0; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oSjuewk0" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cacef7d299so133965ad.1 for ; Tue, 14 Jul 2026 07:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784038849; x=1784643649; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=q8PI+jedvflyq/VB7m0YvNOqkrFrLjJK6JjkfGkp2tY=; b=oSjuewk09kVXHm0KHRM3BsZ+MTSSOP1cWADbbbhrWhvGVbmRNX9D9Y7X1V51tWrRGm UVm1znGpbQNMdSqqgxl6hoMeavzaSmwaoPRrBAAYZJQXVrMOxEKFdcvjAkOTNSSrY/uT exWvGREDqM3BMs4606YbBUetJXDm42/qBNAzN6R9PhOWMQX3aoi3USLo4bTLOH/fNAMz nuqGkI4mHkYSLHhiQh2x0mWzJWcDjFRYTq985pz0FS2l+qviSRhXcjkNX5QqOVdgLrEy nZJaFCTR49hY2cljj9WJ3+jVcq9y7GVuAIKcEskX5IlCNeSdcdsdQKQtlB5F97Og8J50 GgMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784038849; x=1784643649; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=q8PI+jedvflyq/VB7m0YvNOqkrFrLjJK6JjkfGkp2tY=; b=SnqODkF6OEmAanFXVUHIvHE6SSdYalMa0+kYRq0Jvzcplk5r+IwFZly0Y72G8tP+oT w3c31EJydAY0DzBd5ydEWkPPOx/4m65FiX0OdOiHE8m+TKDa5RgMe49ECfDSphIFOG+P x4lOPvMh+1Zd6A1PnXjLTvEk/1nA73t3syOjfxo9L9Q5ERRNXoNX3syac9m/fD5GX88m iyCMX6RsqiRCPbSpBzqbQe4rIbQ1/f9HIRQkwhkda8m47cuffiNlRfzA23XnI9rIZAks epK/pLYuk6EK/5EjURTaOC90v1mBAgu+QgxBf0cr5zgKAUfsAKEiQZvLXyLpmZ7GNFvE 77nw== X-Forwarded-Encrypted: i=1; AHgh+Ro7LHqMXFZqojJTQMLHrXWObfcS9AznlkjkWDbZUiugDQ5uqJ7jR/PzogQwLJL0PTGnlhOzCnzjjrp8N+I=@vger.kernel.org X-Gm-Message-State: AOJu0YxQtGjw2dQ5xoxxSImMv03FpBQG0yHB//7eo4pVo/C9fq4oXHVJ fQ5oWgKrQzZxkbUDKo7gZmnwKNZnKwA5N53+lgFW/+weOLb5jxje8n2RXpNHpcSHMhhkyk/jXcz 6Undn+w== X-Gm-Gg: AfdE7cnIjeboM1Pcluy88aFcKyVErWLGAHga5ybkhn5Hg5/4FUApeK2TxvstXtOLtOQ WUWOg5bHzBWjVA/ALDHH88V8h7iSbJPvHeDnRLfaAOxKXBQPFy+5OkVlmjqgBk9TjAQMX8ziO37 /ScGqmZrDxwu0Ak6BckihBe+7V/86lZuxPSBSA1KEm0dA5Io1s3fDq1W9HsgG4KHJHmA5/PAehU XAeJAPEofuvRawXlMY3+gHOZyPEIxmGShX6ly5GfTi7qyPe2IvmxBcFTKarlvZ/0TfdQ+Nmhfog ycj0GiwxpSwusdqDErPP3BgNxA+ZTLaf4x9Cy7ydklPy7hO2Rj6KJNg35zww2uQ90LCs8oE+1eu BRhDd4WzayIShT9oRBgpxTfVbtjTOX8KGZbcJUWZjNkhrWttF4eAB8a5HGKvRQ74N6pITse3SjC anOzx71zms43g9C187LHswBFFS2bjGL9nGfUtMVB1yHKwztUI= X-Received: by 2002:a17:903:26c6:b0:2ca:be81:b469 with SMTP id d9443c01a7336-2cee1134f8emr5728555ad.0.1784038849054; Tue, 14 Jul 2026 07:20:49 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f2389e8sm1590432b3a.8.2026.07.14.07.20.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 07:20:48 -0700 (PDT) Date: Tue, 14 Jul 2026 14:20:43 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: Will Deacon , Jason Gunthorpe , Robin Murphy , joro@8bytes.org, Kevin Tian , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] iommufd: Fix vDEVICE allocation lifecycle bugs Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Jul 05, 2026 at 10:36:08PM -0700, Nicolin Chen wrote: > Sashiko flagged a few bugs in how IOMMU_VDEVICE_ALLOC creates and validates > a vDEVICE on a vIOMMU: > > - the core publishes a vDEVICE into the vIOMMU xarray before the driver's > vdevice_init() runs, so a concurrent invalidation can reach one it has > not yet accepted; > - the undersized-vdevice_size guard returns holding the igroup mutex, > deadlocking later vDEVICE operations on that group; > - the Arm SMMUv3 vIOMMU accepts a device without exactly one Stream ID: > an out-of-bounds streams[] read for none, stale ATC/IOTLB for several. > > Fix each of them properly. > > This is on Github: > https://github.com/nicolinc/iommufd/commits/fix_vdevice_sashiko-v2 > > Changelog > v2 > * Add "Reviewed-by" from Kevin > * Patch-2: Add "Cc stable"; drop the out_release label by inlining the > xa_release() call > * Patch-2: Note that the reserved slot is hidden only via xa_* helpers > * Patch-3: Return -EOPNOTSUPP instead of -EINVAL > v1 > https://lore.kernel.org/all/cover.1782767110.git.nicolinc@nvidia.com/ > > Nicolin Chen (3): > iommufd/viommu: Release the igroup lock on the vdevice_size error path > iommufd/viommu: Publish a vDEVICE only after vdevice_init() succeeds > iommu/arm-smmu-v3-iommufd: Require exactly one Stream ID for a vDEVICE > > .../arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 15 +++++++++++++ > drivers/iommu/iommufd/viommu.c | 22 ++++++++++++++----- > 2 files changed, 31 insertions(+), 6 deletions(-) > Reviewed-by: Pranjal Shrivastava Thanks, Praan