Re: [PATCH v3] drm/xe/pf: Disable display in admin only PF mode

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Jul 14, 2026 at 11:03:00AM +0530, Satyanarayana K V P wrote:
> Admin-only PF mode does not expose media or 3D execution capabilities
> to userspace, so display pipelines cannot receive rendered content.
> 
> Fixes: d88c4bac8c2a ("drm/xe/pf: Restrict device query responses in admin-only PF mode")
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> 
> ---
> V2 -> V3:
> - Missed RB while resolving rebase conflicts. Fixed it.

pushed to drm-xe-next. Thanks for the patch and review

> 
> V1 -> V2:
> - Rebased to resolve merge conflicts.
> ---
>  drivers/gpu/drm/xe/xe_device.c | 2 --
>  drivers/gpu/drm/xe/xe_pci.c    | 3 ++-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index ad7f3e61d457..785222d54701 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -427,7 +427,6 @@ static const struct drm_ioctl_desc xe_ioctls_admin_only[] = {
>  
>  static const struct drm_driver admin_only_driver = {
>  	.driver_features =
> -	    XE_DISPLAY_DRIVER_FEATURES |
>  	    DRIVER_GEM | DRIVER_RENDER,
>  	.open = xe_file_open,
>  	.postclose = xe_file_close,
> @@ -439,7 +438,6 @@ static const struct drm_driver admin_only_driver = {
>  	.major = DRIVER_MAJOR,
>  	.minor = DRIVER_MINOR,
>  	.patchlevel = DRIVER_PATCHLEVEL,
> -	XE_DISPLAY_DRIVER_OPS,
>  };
>  
>  /**
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index a3b968bccd40..3133e1b99565 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -822,7 +822,8 @@ static int xe_info_init_early(struct xe_device *xe,
>  
>  	xe->info.probe_display = IS_ENABLED(CONFIG_DRM_XE_DISPLAY) &&
>  				 xe_modparam.probe_display &&
> -				 desc->has_display;
> +				 desc->has_display &&
> +				 !xe_device_is_admin_only(xe);
>  
>  	xe_assert(xe, desc->max_gt_per_tile > 0);
>  	xe_assert(xe, desc->max_gt_per_tile <= XE_MAX_GT_PER_TILE);
> -- 
> 2.53.0
>