From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D693839CD00 for ; Tue, 14 Jul 2026 17:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784048956; cv=none; b=mE4PIRY7PVzWyumTfvNgbyWoTXDP2FXuhGTObeRiwU1WU4CPwGGzDOt0A9GvftQsoY4w2yQ/pTBxOG4x55eL/kJkIbTfyqOOblOqJFy6DTg1Ffbk3oOiFfmW38UY4EieOIHAHHWujeFhzSRK1kY/+qkj/6AID5E2LKaP1CJj4U8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784048956; c=relaxed/simple; bh=WxjKhm4bXqb1u5k7AfWGErLZRYGcCQ0DKtR2CPH2VSk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qkCsM5szlYVTusCVj4NUVSvA9uvrLqJNYpw6ofrAel87Tgggu7R+9l7O94ZMsD6XA+gUqnC7G65ZVa9GOwG3GAlDcUbWy3ZacUUtwy5PTZWBVC9AX90OKMuEsOehApAVLTMUS9D/FRtgQaenK2f2C3LJ3H854ddPDUXWNuzvIJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=FeBCzUFg; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="FeBCzUFg" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493bfe9f886so24734035e9.0 for ; Tue, 14 Jul 2026 10:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784048952; x=1784653752; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wmvTM4kKQclmnuTjf5INwpa0cW/U4YQPx7uaHT1J05U=; b=FeBCzUFghxNUCaA+Tnspo2GcArQVoHou4iqU/X3CWuu/xsXkrj/IaUqEYAihXnZI57 cFxmzbEjVNoNdUJRXNjqqINcTlFmsL2v2JSplk3gwBDcsTlUwN1yESpdy+UM44agYSU/ zZ2h02HtirDa29GDfz75/BGSWkfyeAEPszMqUdMVez+DXzj6eO566c6OKmazapJGYEJp PTuDJjNGfmkvGdb1dBHrBM0cMsxs+dsDZapAfnREmqGosuDSQgvs5gTmjyOMZddxuoXu U5fOG9aOoLeaD/eeyoed46S/rO4zdWOAZMDrZmm9PSk4Z45MNcMZjSyK4WhueROu1oMa Co1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784048952; x=1784653752; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wmvTM4kKQclmnuTjf5INwpa0cW/U4YQPx7uaHT1J05U=; b=Sw0McMtQKO67Xijtt7i3mla9mbzroas090/DnfUiFok+P2Ph8g5knDV7Y/i0K+SFyC Hq+Na/CQn0IrC3qhxxQkwuU2Aw7F5iRiWc5o21FFWR2YujfUf8S/1MmMxn0jzkGCwqaI omJfErBY7lf+H7Ow4NIFn73GigwPyG6fUdOIvEjaHLXaK9ZhDDeIV/fO+GVEwQzE/PGN r27Lg3dEsSiy1OMx24ULUmnvAlUEZub8KmBtHJUvTAudraXWyIbZ7ZGkPAs1ikorixz2 g9AqkSQ6p2sry78WO8DK5vKN2oEHlvc2qjkPdzm1sO2uJJZ9JHNUf3NtG92T9+DzDC4u 6F8w== X-Forwarded-Encrypted: i=1; AHgh+RqIPRYzk44pMT0KrnqgdaWQcaS9rUg/FC+zI951kCYAXxOuwM+uJhpjrdAugToyVMb9AYuk3uHAN+g6lK8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8qxEAdxyufrTWcXlHxts2bZomM5eGAC5vqd87g6wCelfBwV8I PWc9wbtDlNHDK2ZzarNQXOp+VkJtUrqBANC/4CtjzHRtpDrRDP1XuyGW6kYuHIUMbzx2zyk8fhG xUZhO X-Gm-Gg: AfdE7cmW7UZCAzqccW4pbk6SYTfsD6I6ICcl5+68HtukRCkcy9BMVwGfGiH6sTGV5uW 4K8VULk2QhCBcaHv+5fjENyo/9lXfAMAblR6OYCEa2zmWN3k4mH/m/iVnhsKQuHgrCQIN1kwIEJ S97YGJTn+awapwE44yuXAmuFfgKPG9oe1b1M2Sv5m8aWXI1mSXmc9iyZ2gu/6Tzl3USndN4c5Ac iRH1t+rsV4TzwcOWWv3TxWCZuaDY/6ka9GajQhVkTCE/8EK3dzUghYhBCRX11osYYOor/5XJDuC 417fqMUT+IGb/m+ODe6dpr1FPwVT3X7b2hvnklXaewlEGyrcFjguWYtfR32cdy5RpdO8e2JROsV s7hvLkI8kEXVtGR10PrfOv0dXNZme16f4G4CNI8Z1Y2cTF2MIqA3+f7q01OSZgtiji0RmFTUncM dWVyelffqsa+sm0ikQeQ== X-Received: by 2002:a05:600c:37cf:b0:493:c4e1:40a6 with SMTP id 5b1f17b1804b1-493f882e97fmr123207855e9.32.1784048952148; Tue, 14 Jul 2026 10:09:12 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4953bbd7eb2sm665125e9.0.2026.07.14.10.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 10:09:11 -0700 (PDT) Date: Tue, 14 Jul 2026 19:09:07 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Guenter Roeck Cc: Flaviu Nistor , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: (lm90) Switch channel parsing to fwnode APIs Message-ID: References: <20260713190659.4511-1-flaviu.nistor@gmail.com> <9b8a49f4-2632-4984-a617-66f4161a3c5f@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hsid2ik4lsvckpps" Content-Disposition: inline In-Reply-To: <9b8a49f4-2632-4984-a617-66f4161a3c5f@roeck-us.net> --hsid2ik4lsvckpps Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] hwmon: (lm90) Switch channel parsing to fwnode APIs MIME-Version: 1.0 Hello Guenter, On Tue, Jul 14, 2026 at 07:43:13AM -0700, Guenter Roeck wrote: > On 7/14/26 05:22, Uwe Kleine-K=F6nig wrote: > > On Mon, Jul 13, 2026 at 10:06:59PM +0300, Flaviu Nistor wrote: > > > Replace OF property handling with fwnode API in the probe function to= read > > > the channels properties, improving the driver compatibility since this > > > method is not limited to Device Tree only. > > > Add also the needed headers for explicit include and clean up related > > > function naming. > > >=20 > > > Signed-off-by: Flaviu Nistor > > > --- > > > drivers/hwmon/lm90.c | 48 +++++++++++++++++++++--------------------= --- > > > 1 file changed, 23 insertions(+), 25 deletions(-) > > >=20 > > > diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c > > > index 4b9c0ccdf260..045977e30cf4 100644 > > > --- a/drivers/hwmon/lm90.c > > > +++ b/drivers/hwmon/lm90.c > > > @@ -101,14 +101,16 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > #include > > > #include > > > #include > > > +#include > >=20 > > is going away soon. Please rely on > > to provide of_device_id. >=20 > My hwmon-next branch is based off v7.2-rc1 and of_device_id > is declared in mod_devicetable.h. That sounds factual correct. If you want to imply with that statement that my recommendation is wrong, annoying or in other ways unsuitable to you I guess you either have to be more explicit or live with it. provides i2c_driver which uses of_device_id (via struct device_driver) and thus includes a header that provides that struct. That won't change in the foreseeable future. If that is not good enough for you, find means to handle that in another way. Best regards Uwe --hsid2ik4lsvckpps Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpWbTAACgkQj4D7WH0S /k4v6gf8CbKocLZWdTkDRzyhhLVuU5NemXPdLKbJQJFOBL66QV0y7tnHGVwSm5zJ QKZkZVx6HVdQ4DGdIRLA4gosw0SAR/oOdCKRnslolbpo9WOldzsGh/c3Bqj8T1R5 YXX6vIyyLolJiOF7w3OVoxmKW6CiS6TNOzoxMIccAW1sRRZCGiu5mUtqrrKySg0q Tndo/JbFAeuze68svKdGnylXaudPFGHVnrKhw0kqWkfsBEtZj/FYR+/uqM7xF2wH uQIGjl4a851sVIu7/uTIRiXlrMSrbsdjjWdfQkzus8g+EJ80DJZbknWvnuh7yqnR GLmA37OxO/KnAaIYGy1PlBzjJ8+EOQ== =hwf7 -----END PGP SIGNATURE----- --hsid2ik4lsvckpps--