All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Leo Yan <leo.yan@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf capstone: Fix build with Capstone versions before 6
Date: Tue, 14 Jul 2026 10:02:27 -0700	[thread overview]
Message-ID: <alZroz3uzOGmUTjk@google.com> (raw)
In-Reply-To: <20260714083652.GD512733@e132581.arm.com>

On Tue, Jul 14, 2026 at 09:36:52AM +0100, Leo Yan wrote:
> On Mon, Jul 13, 2026 at 01:53:55PM -0700, Namhyung Kim wrote:
> 
> [...]
> 
> > > Perhaps checking the Capstone version would be a safer approach?
> > 
> > I'm not sure.  IIUC RISC-V support was added to v5.0 and CS_MODE_RISCV_C
> > was changed before v6.0 is out.  Do you build capstone from source or
> > use a packaged version?
> 
> I checked Capstone source for two RISCV commits:
> 
>   ec6428f9 Refactoring the RISCV architecture to Auto-Sync on LLVM (#2756)
>   b8fcf27b RISCV support ISRV32/ISRV64 (#1401)
> 
>   $ git describe --contains ec6428f92
>   6.0.0-Alpha7~10
>   $ git describe --contains b8fcf27b2
>   6.0.0-Alpha1~513

I'm curious what `git tag --contains` would say.  I can see RISCV in the
5.0 source code.

https://github.com/capstone-engine/capstone/blob/5.0/include/capstone/capstone.h#L90

> 
> This is why I concluded that v6.0 is the version start to support. I did
> not build capstone from scratch but just use a packaged version.

What's your version?

> 
> Just remind, CS_MODE_RISCVC might break build when you work with the
> latest Capstone, as it has been renamed to CS_MODE_RISCV_C.

Yep.  https://github.com/capstone-engine/capstone/issues/2977

Thanks,
Namhyung


      reply	other threads:[~2026-07-14 17:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 11:08 [PATCH] perf capstone: Fix build with Capstone versions before 6 Leo Yan
2026-07-13 17:39 ` Namhyung Kim
2026-07-13 18:21   ` Leo Yan
2026-07-13 20:53     ` Namhyung Kim
2026-07-14  8:36       ` Leo Yan
2026-07-14 17:02         ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alZroz3uzOGmUTjk@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.