From: Ted Nyman <tnyman@openai.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Taylor Blau" <me@ttaylorr.com>, "Patrick Steinhardt" <ps@pks.im>,
"Karthik Nayak" <karthik.188@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 2/2] fetch-pack: accept "pack" output for packfile URIs
Date: Tue, 14 Jul 2026 11:38:56 -0700 [thread overview]
Message-ID: <alaCQKXKcWr723Ij@com-76773> (raw)
In-Reply-To: <20260714071231.GD2516582@coredump.intra.peff.net>
> I also think this would all be much nicer with a strbuf (which would
> let us get rid of the magic numbers), but that is a slightly larger
> refactor:
Using a strbuf makes sense. One wrinkle, I think, is that with
transfer.fsckobjects enabled, index-pack can emit dangling .gitmodules
OIDs after the initial pack/keep line, which parse_gitmodules_oids()
still needs to read from cmd.out. Would strbuf_getwholeline_fd() be a
better fit here, so we don't consume those with strbuf_read()?
I'll also fix the --index-pack-args documentation while rerolling.
Thanks,
Ted
next prev parent reply other threads:[~2026-07-14 18:39 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 22:37 [PATCH 0/2] packfile URIs: support concurrent downloads Ted Nyman
2026-07-13 22:34 ` [PATCH 1/2] http: use unique tempfiles for packfile URI downloads Ted Nyman
2026-07-14 1:00 ` Junio C Hamano
2026-07-14 1:58 ` Ted Nyman
2026-07-14 4:07 ` Taylor Blau
2026-07-14 5:28 ` Jeff King
2026-07-14 18:10 ` Junio C Hamano
2026-07-14 18:31 ` Ted Nyman
2026-07-14 4:06 ` Taylor Blau
2026-07-14 5:44 ` Jeff King
2026-07-14 6:46 ` Jeff King
2026-07-13 22:34 ` [PATCH 2/2] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-14 7:12 ` Jeff King
2026-07-14 7:13 ` Jeff King
2026-07-14 18:38 ` Ted Nyman [this message]
2026-07-14 21:47 ` Jeff King
2026-07-14 4:13 ` [PATCH 0/2] packfile URIs: support concurrent downloads Taylor Blau
2026-07-20 22:33 ` [PATCH v2 " Ted Nyman
2026-07-20 22:33 ` [PATCH v2 1/2] http: avoid concurrent appends to partial packs Ted Nyman
2026-07-21 19:56 ` Junio C Hamano
2026-07-20 22:34 ` [PATCH v2 2/2] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-21 23:29 ` [PATCH v3 0/3] packfile URIs: support concurrent downloads Ted Nyman
2026-07-21 23:29 ` [PATCH v3 1/3] http-fetch: correct --index-pack-arg documentation Ted Nyman
2026-07-21 23:29 ` [PATCH v3 2/3] http: avoid concurrent appends to partial packs Ted Nyman
2026-07-21 23:29 ` [PATCH v3 3/3] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-24 4:43 ` [PATCH v3 0/3] packfile URIs: support concurrent downloads Junio C Hamano
2026-07-25 9:09 ` Jeff King
2026-07-25 9:21 ` Jeff King
2026-07-25 10:02 ` Jeff King
2026-07-25 10:10 ` Jeff King
2026-07-25 16:20 ` Junio C Hamano
2026-07-24 8:14 ` [PATCH v4 " Ted Nyman
2026-07-24 8:14 ` [PATCH v4 1/3] http-fetch: correct --index-pack-arg documentation Ted Nyman
2026-07-24 21:38 ` Taylor Blau
2026-07-24 8:14 ` [PATCH v4 2/3] http: avoid concurrent appends to partial packs Ted Nyman
2026-07-24 8:14 ` [PATCH v4 3/3] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-24 21:46 ` Taylor Blau
2026-07-26 6:44 ` [PATCH v5 0/3] packfile URIs: support concurrent downloads Ted Nyman
2026-07-26 6:44 ` [PATCH v5 1/3] http-fetch: correct --index-pack-arg documentation Ted Nyman
2026-07-26 6:44 ` [PATCH v5 2/3] http: avoid concurrent appends to partial packs Ted Nyman
2026-07-26 9:20 ` Jeff King
2026-07-26 10:04 ` Ted Nyman
2026-07-26 10:27 ` Jeff King
2026-07-26 6:44 ` [PATCH v5 3/3] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-26 9:21 ` [PATCH v5 0/3] packfile URIs: support concurrent downloads Jeff King
2026-07-27 0:28 ` [PATCH v6 0/6] " Ted Nyman
2026-07-27 0:28 ` [PATCH v6 1/6] http-fetch: correct --index-pack-arg documentation Ted Nyman
2026-07-27 0:28 ` [PATCH v6 2/6] http: avoid closing index-pack input twice Ted Nyman
2026-08-01 13:53 ` Jeff King
2026-07-27 0:28 ` [PATCH v6 3/6] http: accept HTTP 416 for complete partial packs Ted Nyman
2026-08-01 13:58 ` Jeff King
2026-07-27 0:28 ` [PATCH v6 4/6] http: avoid concurrent appends to " Ted Nyman
2026-07-27 0:28 ` [PATCH v6 5/6] http: permit unlinking partial packs on Windows Ted Nyman
2026-07-27 0:28 ` [PATCH v6 6/6] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-29 21:41 ` [PATCH v6 0/6] packfile URIs: support concurrent downloads Junio C Hamano
2026-08-01 14:02 ` Jeff King
2026-08-08 16:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alaCQKXKcWr723Ij@com-76773 \
--to=tnyman@openai.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.