From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6740F435509 for ; Tue, 14 Jul 2026 19:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784058819; cv=none; b=k8EulTqRzrx1xxqhiDGfOKBO1mMC+SetdFIC1eoIvcOSpDbECQBq0Vps2kP83d6Ori3yn7VqcJ1K5N0qDg1C/wyLdm/DWG31Yj7uGnEmh9eKwcq3AVvuzrqN95fCYZ73BCA0nVc+7NS43tAI0iPkD6WIsUgqfcTHcHHrpWVLNUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784058819; c=relaxed/simple; bh=bPG8Rg+RQcR4e2GIKzREiFhLVzWSzy/GiYW9X/qDJ9w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tnue0WM1DSmi1zZ33N2w0ky/FwohUKIdDf1TImxhxVut7bFkjMVXaICYkDlL19C1XF43zHwyBDAyoAuupxtQKb++ceIQ/x4SpD/TJDwfCFaNE/FkenHo9/segH5FMtILAwkf2qsTBkEl2sg/4dFkFtLB00/ePCp4b68GjvNcYz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=n3Mw7wBp; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="n3Mw7wBp" Date: Tue, 14 Jul 2026 12:52:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784058816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tzALV2d53RJaMjFjlVkiVRur0WMV7gOh4zd/yZy2+NI=; b=n3Mw7wBpML1vKHir0x9lBaLY8AeH32oim58MtgrjP1ALriUDJi2hACH18GAMpSacDzsHvR Qfj2fnw0VhK2ogHSCyXuWC0nrdoWo4W5MbgWwIRrfr61OemJmsDycoSza7ko9AMaVkKHBa Pexlkt9xv2thRYcb+6ZduLoiu/a1ggg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Guopeng Zhang Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Alexandre Ghiti , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Guopeng Zhang Subject: Re: [PATCH] mm: memcontrol: update state_local when flushing NMI stats Message-ID: References: <20260713085053.2916813-1-guopeng.zhang@linux.dev> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260713085053.2916813-1-guopeng.zhang@linux.dev> X-Migadu-Flow: FLOW_OUT On Mon, Jul 13, 2026 at 04:50:53PM +0800, Guopeng Zhang wrote: > From: Guopeng Zhang > > flush_nmi_stats() updates state[] for kmem and slab counters but leaves > the corresponding state_local[] counters unchanged. Local kmem and > slab statistics therefore miss updates collected through the NMI-safe > atomic path. > > Update state_local[] together with state[]. > > Fixes: 940b01fc8dc1 ("memcg: nmi safe memcg stats for specific archs") > Signed-off-by: Guopeng Zhang Acked-by: Shakeel Butt