From: Sean Christopherson <seanjc@google.com>
To: Ackerley Tng <ackerleytng@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH v5 6/7] KVM: x86: Combine .gmem_prepare()+.gmem_invalidate() into .gmem_convert()
Date: Tue, 14 Jul 2026 17:10:58 -0700 [thread overview]
Message-ID: <albQErGisdVyHoQL@google.com> (raw)
In-Reply-To: <CAEvNRgG1Jm7k1F1H9TK3ACvsbHYBzoNEohvii_N0_da_ForTRw@mail.gmail.com>
On Tue, Jul 14, 2026, Ackerley Tng wrote:
> Sean Christopherson <seanjc@google.com> writes:
> > #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_RECLAIM
> > void kvm_arch_gmem_reclaim(kvm_pfn_t pfn, kvm_pfn_t nr_pages, int max_order)
> > {
> > - kvm_x86_call(gmem_invalidate)(pfn, pfn + nr_pages);
> > + WARN_ON_ONCE(kvm_x86_call(gmem_convert)(NULL, -1ull, pfn, nr_pages, max_order, false));
>
> This setup means later pKVM would have to define a .gmem_convert but
> actually only use it for reclaim, which seems kind of an odd
> definition. (We can fix this later.)
No, pKVM (on arm64) would just implement kvm_arch_gmem_reclaim(), and then do
whatever it wants under the hood.
next prev parent reply other threads:[~2026-07-15 0:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 23:10 [PATCH v5 0/7] KVM: guest_memfd: reclaim()/convert() cleanups Sean Christopherson
2026-07-14 23:10 ` [PATCH v5 1/7] KVM: guest_memfd: Plumb the number of pages and max order into .invalidate() Sean Christopherson
2026-07-14 23:52 ` Ackerley Tng
2026-07-15 8:15 ` Fuad Tabba
2026-07-16 7:09 ` Xiaoyao Li
2026-07-14 23:10 ` [PATCH v5 2/7] KVM: guest_memfd: Rename invalidate() arch hook to reclaim() and isolate it Sean Christopherson
2026-07-14 23:53 ` Ackerley Tng
2026-07-15 8:19 ` Fuad Tabba
2026-07-16 10:04 ` Xiaoyao Li
2026-07-14 23:10 ` [PATCH v5 3/7] KVM: guest_memfd: Drop the redundant printk on arch gmem_prepare() failure Sean Christopherson
2026-07-15 8:21 ` Fuad Tabba
2026-07-16 10:05 ` Xiaoyao Li
2026-07-14 23:10 ` [PATCH v5 4/7] KVM: guest_memfd: Fold __kvm_gmem_prepare_folio() into its sole caller Sean Christopherson
2026-07-14 23:39 ` sashiko-bot
2026-07-14 23:55 ` Ackerley Tng
2026-07-14 23:10 ` [PATCH v5 5/7] KVM: guest_memfd: Explicitly pass number of pages to kvm_arch_gmem_prepare() Sean Christopherson
2026-07-14 23:10 ` [PATCH v5 6/7] KVM: x86: Combine .gmem_prepare()+.gmem_invalidate() into .gmem_convert() Sean Christopherson
2026-07-15 0:06 ` Ackerley Tng
2026-07-15 0:10 ` Sean Christopherson [this message]
2026-07-15 9:50 ` Fuad Tabba
2026-07-15 9:48 ` Fuad Tabba
2026-07-14 23:10 ` [PATCH v5 7/7] KVM: guest_memfd: Rework PREPARE config and hook into a more generic CONVERT Sean Christopherson
2026-07-15 0:09 ` Ackerley Tng
2026-07-15 9:53 ` Fuad Tabba
2026-07-16 9:35 ` Xiaoyao Li
2026-07-16 21:42 ` Ackerley Tng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=albQErGisdVyHoQL@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=tabba@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.