Re: [PATCH] drm/xe: Remove ifdef in DRM_GPUVA_OP_DRIVER svm subop checking

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Jul 15, 2026 at 01:28:46PM +0100, Matthew Auld wrote:
> On 15/07/2026 11:31, Mika Kuoppala wrote:
> > Always emit the DRM_GPUVA_OP_DRIVER case so the previous break is
> > effective and we never fall through to the default warning.
> > This also allows adding more subops in the future without ifdef dancing.
> > 
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> 
> Assuming it still builds,

+1

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> 
> > ---
> >   drivers/gpu/drm/xe/xe_pt.c | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
> > index 7111b5d0f6aa..d1b939dfaa13 100644
> > --- a/drivers/gpu/drm/xe/xe_pt.c
> > +++ b/drivers/gpu/drm/xe/xe_pt.c
> > @@ -1547,7 +1547,6 @@ static int op_check_svm_userptr(struct xe_vm *vm, struct xe_vma_op *op,
> >   			err = vma_check_userptr(vm, gpuva_to_vma(op->base.prefetch.va), pt_update);
> >   		}
> >   		break;
> > -#if IS_ENABLED(CONFIG_DRM_XE_GPUSVM)
> >   	case DRM_GPUVA_OP_DRIVER:
> >   		if (op->subop == XE_VMA_SUBOP_MAP_RANGE) {
> >   			struct xe_svm_range *range = op->map_range.range;
> > @@ -1562,7 +1561,6 @@ static int op_check_svm_userptr(struct xe_vm *vm, struct xe_vma_op *op,
> >   			}
> >   		}
> >   		break;
> > -#endif
> >   	default:
> >   		drm_warn(&vm->xe->drm, "NOT POSSIBLE");
> >   	}
>