From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F7833DED5 for ; Thu, 16 Jul 2026 08:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784191924; cv=none; b=NRgWedrWIbpEajg0aDwRBSvOMLiwoUBV2AaMbkrKp0CcEjDH69qAeuOw3vO5xdzOUbKulo9kLZ1Z9JM+ziwlRFy/HxPClS/MhPMaLPhVkK48fvXTD4/oK9SaO6bRPQXnxAFCcONWwaf/myhq0QwopaN+x5luy7qa+MuSijMSL1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784191924; c=relaxed/simple; bh=BOTKuDCU3tdRP45CCg7RV/Mi6Bf+ewUdiyCH4EcQBJI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gztRSfub23mqv8wqK7XOA5Pfu9bNJjqDnB8tHFubegsK6hENroRrm3yGvpxNw8oDrNbJKDaK8OR7pEQVLbp/O865wZPANVrRONIULBVE8KL8Lv+IDFiUMAA3hf8afyj44WhaQmB6K5Xc137IlfqBhz1a11MlzXV1R/BLzpfNpus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ENTm51aR; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ENTm51aR" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-7eb29ed2bbdso2082083a34.2 for ; Thu, 16 Jul 2026 01:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784191921; x=1784796721; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+yR2FDEtVlWoof8SpuOcxS9lUEU3R1LMgkuOGcWos4U=; b=ENTm51aR9uORyZ6Aw7JH0HmnhaPt4MU5GZGy6hly9dFR6wna8KMoiNf0Pd/inP52ug 5HgcHm7H0fDy6eaeIreJqFXJoWQQC015PhQ/V0NXPSIDan7BNdEv2P0DN6tkwLJm9Rzr s034Vs9oK5Uj4ByTLN1egNu8MvbvU+31sJ2WD5gt37Z6XnUrUD2BS/4Jaf+lYPvGYZ+c +aPZGODBnp/7bxcESB/fIZZq4CtxZolgEp/6hroutY3LWEVxC3KTj8qPhR+y0Wne+f0F 82lHL8c3eQqfHOdFLDGj8iVcF/cUL1eJpk3Ck5DFDQZWfkwtswgMwO6mU2dOBQS8lJ0S PlqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784191921; x=1784796721; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+yR2FDEtVlWoof8SpuOcxS9lUEU3R1LMgkuOGcWos4U=; b=MiSpBylx7r0A90wrTbKBpYjcrUjg0AV1Eo273m5A+C4ZM59l18nFPEw2SDwyplHHHs Mbs/LuYFkkvYsKHtQu21tSNy7vaKfqlIUawHoMDrbelDqsB/j5w0qvRTlEB2lPyBNOek dIwnV1t/XCoXkVL2BB5YlmIPvpLB70Ns8yPrD9u4v8zJcisKo5X1uP72cdbY7jrK7SLR 33rEiv1eTrXy4O/t2wBf8eSH4BrD1HNk5t26deZ3sivy9PEvAuWcxbYex2Pur24LeuIj LoNqfCUJ9ON3c2YdhAD2FagffVE2u7zBWONMOEpT5km1LYL1JiR7+x7pDXLiYw98W+WP CyoA== X-Forwarded-Encrypted: i=1; AHgh+Rqs7s6WJ8WKreh/QkK9tQqdvqE4b1oZ+t06gShx3flwLw7UAR2AvwNZ+g5gLcyDR+EJ1gu7J4H8J0vg8Ho=@vger.kernel.org X-Gm-Message-State: AOJu0YzeFe+tV+bGWl7Qd3QaIeZOTmiJ0WosA1bY7dFW+pVXUx/suoK+ zNrgbXZfKlXo2cWYgEjgp7FeFDkqBlxuc7lrf95g8Ls7HlF/rajwx+TL X-Gm-Gg: AfdE7cltWZbGBWxD/hnpFm1Mz9R+pGbU+DCwtEe2AgUNieDIu58zp7NJdwkatVOc2yq demYxFZE/rmPkQeiowPqPSqx/pIf+XuuigeUUJzNsYdHjRQFswdrtQ7IRCByT3vL9wzts4+WmOd P7fQPczfT6VhykDzXBHCxgHPDSwglw5f0BSxRDoydzhmqmh56CUQZYR4nmoIwsiEP3ynpY+Gi5A SKyH1ss3t7JRQ0P7Wq1pcP/7+IKXM4GK+0g94tcN6rz12Ux2S1GqN3fkiQR/HZwCJKZ5VQt2Ik1 AmAACUcZZijLIqlbs9/GPcSLVIpm4uEgIloiXv1jR5srxXedamLDLCliAB5N99JNPxbrzz2xIA2 /xn0NCt/YuG2DXLcL8VGM9X3nMFM7Cc+B3jwgyDcvibezpNip+d1MjGBCTErNWB+8Wy7SKlizWE sF+ftB X-Received: by 2002:a05:6830:6a92:b0:7e9:e448:a28d with SMTP id 46e09a7af769-7ec4a916eccmr6064965a34.31.1784191921279; Thu, 16 Jul 2026 01:52:01 -0700 (PDT) Received: from localhost ([74.80.182.90]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ebcb2bc0d0sm19022110a34.19.2026.07.16.01.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 01:51:59 -0700 (PDT) Date: Thu, 16 Jul 2026 11:51:53 +0300 From: Dan Carpenter To: Amin Madani Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org Subject: Re: [PATCH v2] staging: rtl8723bs: Split multiple assignments in _rtw_open_pktfile Message-ID: References: <20260716083822.2898-1-aminmadani112@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260716083822.2898-1-aminmadani112@gmail.com> On Thu, Jul 16, 2026 at 12:08:22PM +0330, Amin Madani wrote: > In _rtw_open_pktfile(), multiple variables are assigned on the same > line. According to the Linux kernel coding style, multiple assignments > on a single line should be avoided. Split them into separate lines to > improve readability. > > Signed-off-by: Amin Madani > --- > v2: Assign pktptr values directly to variables instead of chaining them, > as suggested by Dan Carpenter. > (https://lore.kernel.org/all/aZ_0OratIkUBNHmy@stanley.mountain/) > Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter