From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C476346A08 for ; Thu, 16 Jul 2026 09:11:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784193112; cv=none; b=HG4DZilBNeNyHCu8J0rVyVcYH2heeg5C287i7tQXrr8nVpzO45mXjE2I1NyrsNpVxO260ab1JBOFzd/YGhKoWrRIMwb/L7Z3UMRTBiIL4ghA78Nd0zA/cqs+vkLl1R1NnMpwP7UXhyGULEeglMnp/ONOLz68XdmeqZ71T8wgVug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784193112; c=relaxed/simple; bh=RfumTSrPWE3OPhzpiLKUp8aa5HfscOzxp+MuunelGFU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gF48q1HIIeV9xjj/W+sr2VxjT+54FvTjdwpMRnbffn8spZ4gU7agJ9aqvUO67/G1JzMDMbULjgBmrbDmDWjyQabh/x6DVYSmVbmurgwXIu0zJmSJBp+1kDrYrlO/KLIsSVXZO16CmJYODFVOd4jQfFVdA+PCQvaZvJvfkpqQzEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YLkMyvI6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YLkMyvI6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BE8E1F000E9; Thu, 16 Jul 2026 09:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784193104; bh=xB39CnaamFGjxi2No9XuGiZYlHIkv9GTqdvDkMfQ2U0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YLkMyvI6smebQ0r8qQhLaVbGJXqEGv4i2ifMh+PjTftW0MSVNL9fBB72HhScB9LtO PTXpYB3ZDpHBgBdq37dJbik9BrTujcPIMflvzeKPSE5iLge4SrfRGOPEqvsabsoJbI 1sc2OFFl8V/+LFB/0HTSWxbvRX0k8hMe5I3tEv9wSnFnVYsI4pN8jqP/IhZXEjoyw5 VvaVBH8b2OkH+Y928ezd3PSNi0H8yM0iN3XKDcXsYoUfMFwGAVst+bb3KUNqUC/uzI KHvdmPqs44l7hwEtwO4PoHxjOPZmKaAJhmVIJwcbaeWWFjN13fomp10PeRYbJDWdCa QK5xYX8QsOjlQ== Date: Thu, 16 Jul 2026 10:11:30 +0100 From: "Lorenzo Stoakes (ARM)" To: Aditya Prakash Srivastava Cc: Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/khugepaged: use page_cache_sync_ra() directly Message-ID: References: <20260716083211.2688-1-aditya.ansh182@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260716083211.2688-1-aditya.ansh182@gmail.com> On Thu, Jul 16, 2026 at 08:32:11AM +0000, Aditya Prakash Srivastava wrote: > The static inline page_cache_sync_readahead() wrapper in pagemap.h > is legacy and only wraps page_cache_sync_ra() after initializing > a local readahead_control structure using DEFINE_READAHEAD. As Dev notes there's nothing legacy about it, it's used in multiple places. > > Modernize the khugepaged readahead call by using page_cache_sync_ra() > directly. This avoids the legacy wrapper and aligns the khugepaged > readahead implementation with other subsystems in the kernel. Nope, it's replacing a helper function that wraps something with open coding it instead for no good reason. > > No functional change is introduced, as the logic and behavior > remain identical. > > Signed-off-by: Aditya Prakash Srivastava Sorry this patch is replacing a wrapper with open code for not really much benefit. > --- > mm/khugepaged.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 617bca76db49..2682b39401b2 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2331,10 +2331,10 @@ static enum scan_result collapse_file(struct mm_struct *mm, unsigned long addr, > } > } else { /* !is_shmem */ > if (!folio || xa_is_value(folio)) { > + DEFINE_READAHEAD(ractl, file, &file->f_ra, mapping, index); > + > xas_unlock_irq(&xas); > - page_cache_sync_readahead(mapping, &file->f_ra, > - file, index, > - end - index); > + page_cache_sync_ra(&ractl, end - index); > /* drain lru cache to help folio_isolate_lru() */ > lru_add_drain(); > folio = filemap_lock_folio(mapping, index); > -- > 2.47.3 > Cheers, Lorenzo