From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15559C4450A for ; Thu, 16 Jul 2026 10:15:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkJ7r-0002yp-1c; Thu, 16 Jul 2026 06:15:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkJ7p-0002wo-MU for qemu-devel@nongnu.org; Thu, 16 Jul 2026 06:15:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkJ7n-0004RZ-0C for qemu-devel@nongnu.org; Thu, 16 Jul 2026 06:15:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784196926; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=127lHvq6qlz1+4z4X14WRABFSX0rEPsR0bZodUSsga4=; b=fxttmxQZJppjOAysxO7wo+lT1glNNOLmGFB+6C5OJ5BcNHA41hD6/8YHoTfnvWpxo5Hahv /9e8Tcrz+lfse9/RPnvwxv29Wmn8fPYDsl7ZBD0SL3t73jNH5oH0OFuQFGbQgkFpfxRvVQ 2NyXJYFndzWFFXl59Ncu80BX+6X2/f4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-nEHOqfV9MAC2Q9yP-_VHrA-1; Thu, 16 Jul 2026 06:15:22 -0400 X-MC-Unique: nEHOqfV9MAC2Q9yP-_VHrA-1 X-Mimecast-MFC-AGG-ID: nEHOqfV9MAC2Q9yP-_VHrA_1784196922 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E49AE1955F23; Thu, 16 Jul 2026 10:15:21 +0000 (UTC) Received: from redhat.com (unknown [10.44.34.221]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 260D51956044; Thu, 16 Jul 2026 10:15:19 +0000 (UTC) Date: Thu, 16 Jul 2026 11:15:16 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: qemu-devel@nongnu.org Cc: Hanna Reitz , Kevin Wolf , qemu-block@nongnu.org Subject: Re: [PATCH] iotests: increase timeouts for tests to 5 minutes Message-ID: References: <20260623160326.2346255-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260623160326.2346255-1-berrange@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: permerror client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Ping: any reviewers for this simple robustness fix. On Tue, Jun 23, 2026 at 05:03:26PM +0100, Daniel P. Berrangé wrote: > Currently we have tests timeout set to 3 minutes, on the basis > that they're generally done in less than a minute. I've hit a > couple of random failures suggesting that's not sufficiently > pessimistic. Increase the timeout to 5 minutes to have a greater > safety net in high load scenarios. > > Signed-off-by: Daniel P. Berrangé > --- > tests/qemu-iotests/meson.build | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build > index bc6132a0f7..8857f25f29 100644 > --- a/tests/qemu-iotests/meson.build > +++ b/tests/qemu-iotests/meson.build > @@ -52,16 +52,17 @@ foreach driver, speed: qemu_iotests_drivers > '-tap', '-' + driver, item, > '--source-dir', meson.current_source_dir(), > '--build-dir', meson.current_build_dir()] > - # Some individual tests take as long as 45 seconds > - # Bump the timeout to 3 minutes for some headroom > - # on slow machines to minimize spurious failures > + # Some individual tests take as long as 3 minutes > + # in high load scenarios. Bump the timeout to 5 > + # minutes for some headroom on slow / loaded > + # machines to minimize spurious failures > test('io-' + driver + '-' + item, > python, > args: args, > depends: qemu_iotests_binaries, > env: qemu_iotests_env, > protocol: 'tap', > - timeout: 180, > + timeout: 300, > suite: suites) > endforeach > endif > @@ -94,16 +95,14 @@ foreach driver, speed: qemu_iotests_drivers > '-tap', '-' + driver, item, > '--source-dir', meson.current_source_dir(), > '--build-dir', meson.current_build_dir()] > - # Some individual tests take as long as 45 seconds > - # Bump the timeout to 3 minutes for some headroom > - # on slow machines to minimize spurious failures > + # See earlier note about timeouts > test('io-' + driver + '-' + item, > python, > args: args, > depends: qemu_iotests_binaries, > env: qemu_iotests_env, > protocol: 'tap', > - timeout: 180, > + timeout: 300, > suite: suites) > endforeach > endforeach > -- > 2.54.0 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|