All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Luc Michel <luc.michel@amd.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Francisco Iglesias" <francisco.iglesias@amd.com>,
	"Frederic Konrad" <frederic.konrad@amd.com>
Subject: Re: [PATCH v2] meson.build: re-add explicit gcrypt/nettle request check
Date: Thu, 16 Jul 2026 11:23:11 +0100	[thread overview]
Message-ID: <alixDyX9bC3Ju161@redhat.com> (raw)
In-Reply-To: <20260710132531.97844-1-luc.michel@amd.com>

On Fri, Jul 10, 2026 at 03:25:30PM +0200, Luc Michel wrote:
> c4b3d0074 removed the check that nettle or gcrypt were explicitly
> requested as the crypto library to use, breaking the --enable-nettle and
> --enable-gcrypt options. Re-add the logic to force usage of nettle or
> gcrypt for crypto operations, while still keeping gnutls for TLS.
> 
> Fixes: c4b3d0074 (crypto: bump min gnutls to 3.7.5)
> Signed-off-by: Luc Michel <luc.michel@amd.com>
> ---
> v2:
>    - Revert more of c4b3d0074 to restore the gnutls_crypto logic to
>      disable gnutls only for crypto ops but keep it for TLS [Daniel]
> ---
>  meson.build                    | 11 ++++++++++-
>  crypto/cipher.c                |  2 +-
>  tests/unit/test-crypto-block.c |  3 ++-
>  crypto/meson.build             |  2 +-
>  4 files changed, 14 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

and queued.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



      parent reply	other threads:[~2026-07-16 10:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 13:25 [PATCH v2] meson.build: re-add explicit gcrypt/nettle request check Luc Michel
2026-07-10 19:31 ` Pierrick Bouvier
2026-07-16 10:23 ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alixDyX9bC3Ju161@redhat.com \
    --to=berrange@redhat.com \
    --cc=francisco.iglesias@amd.com \
    --cc=frederic.konrad@amd.com \
    --cc=luc.michel@amd.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@mailo.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.