From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 706003FBEBC for ; Thu, 16 Jul 2026 13:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209974; cv=none; b=G0q3rU+ZQywV/AplqcQ5N+gzX55XIzvlnun2m54kr2wals1KmLMab9WwJiozf3rw2H+qwd2L84MH0bmdclURTP3xSHcCFlojNMqrteQBtEj4aoie9OoVVp7imtQaIvDNB/UNgJbDojuqFCTQ7xD2TmyF2+PL1QlfE6Sm25Tmu8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209974; c=relaxed/simple; bh=ZzvOSWfmqv9aqz3OutE1nF+NZHVJv0qhvIUZTLAPIc0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q1241uPMxRWYw5ZuzFo5GP2l0kc+nwW5dPka3PFDrrvSv012D4PQ+yALW+UlI6Ld1QUkTPM6hf6wvxigH4hqAReU64QvPnHBGEON2ayMqqACj21HSw+wcTjv6FFz0QwAey4lIBs1oC0DfMmN6i1sUVIoTGuvYe6T6+6nOp7vIRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VLDjiQ9i; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VLDjiQ9i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECAB71F00AC4; Thu, 16 Jul 2026 13:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784209972; bh=VqoUQDDVg1sK22IYjK8mURPEC3+0dDYihfXJb+e4fcI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=VLDjiQ9iOXUUY8bOLQFvqxEdqqtdbOCPGqvGtmXLmzaerr9D/xa3YPyvzQ+HRD8PM iIVZD2/lGd3qpd2NK79RQdFKbmM933CEfj+gDCTnTCvZ2SryyRjrjz5tThoF3lkpE7 xM2Fewy+p2GkcTyZdBc4sT9xhtwNmYlP6w5cdiBO6DulLF+VGQoTzhKeZ20XYecNIz rm7SOE9rYMjKlXyzzn1RLHnnsjJ2mMkEUM8knPJDt+aL+0fD+RRZPptIOt/KN18Y0b IVtAqH0xXLR4SiBouYC6euNNSmlc081bTEnwp9bSrA5SsNxRn15gSSIKKqGjNP4jaL 0Y8o7qgQLCotA== Date: Thu, 16 Jul 2026 14:52:37 +0100 From: "Lorenzo Stoakes (ARM)" To: Kiryl Shutsemau Cc: Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kiryl Shutsemau (Meta)" Subject: Re: [PATCH 2/2] mm/huge_memory: fold split_folio_to_list_to_order() into split_folio_to_order() Message-ID: References: <20260716100345.473473-1-kirill@shutemov.name> <20260716100345.473473-3-kirill@shutemov.name> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260716100345.473473-3-kirill@shutemov.name> On Thu, Jul 16, 2026 at 11:03:45AM +0100, Kiryl Shutsemau wrote: > From: "Kiryl Shutsemau (Meta)" > > split_folio_to_list_to_order() had no direct callers; its only user was > split_folio_to_order(), which always passed a NULL list. Fold it into > split_folio_to_order() and call split_huge_page_to_list_to_order() > directly. > > No functional change. > > Signed-off-by: Kiryl Shutsemau (Meta) LGTM, so: Reviewed-by: Lorenzo Stoakes (ARM) > --- > include/linux/huge_mm.h | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 6961db4d1591..1842b1e6862a 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -792,15 +792,9 @@ static inline bool is_pmd_order(unsigned int order) > return order == HPAGE_PMD_ORDER; > } > > -static inline int split_folio_to_list_to_order(struct folio *folio, > - struct list_head *list, int new_order) > -{ > - return split_huge_page_to_list_to_order(&folio->page, list, new_order); > -} > - > static inline int split_folio_to_order(struct folio *folio, int new_order) > { > - return split_folio_to_list_to_order(folio, NULL, new_order); > + return split_huge_page_to_list_to_order(&folio->page, NULL, new_order); > } > > /** > -- > 2.54.0 > Cheers, Lorenzo