From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33EBB3264E7 for ; Thu, 16 Jul 2026 19:55:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784231730; cv=none; b=PXo8VwIw43vWlYAGYueownwYNuxtXgannUPha2nJpyUCcHXj3HDa6Z/ijil8yKh/4zxgeAum2708Osqu+5Bd+yX2loCPQ2mCqUn2igFQoPcEG5hHBsUDS5K23uQpHpAkk5z8VPQwdFqnvGEZNZ/F34YNlZX3xaq/WvMrSwOh1j4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784231730; c=relaxed/simple; bh=xTH5SRivTOjKCeZK/CQzkS1OrhVK53Hs5nd5Py0Ytbs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qewtEUn1/xD/DBvRqL/NdpHvpMNmk6/5gK6/UZhZWcl5M88ovid/fTCZmh+lLjYeDSxuq7FMKYqpaHk5uS5QcK28HyW21feV+o7aQ/uIcnVLq3XyzoHRwt8L8tBi4lSf/t5H7LaclwHm8Kt8EvJErdSrs+ZF29SoB0biLctID70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Q58FR6VM; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Q58FR6VM" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49547fc63a0so1049475e9.2 for ; Thu, 16 Jul 2026 12:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784231726; x=1784836526; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hFJ0EpzatP7/QvJCIqNNnPldKAnCwWETMXqW+7ClCHY=; b=Q58FR6VMHsD4Fg0Ya3aDFIisk7ZWa2+yoSJebEVVvSpd1C0x5Vgrkl8rK7+ZkydyZ5 kHMcKYXGl/ej2po7pSODXahWNOzee5WrTYcRxhOZID6tj4TJ2oBdbPzpG2PrRn9CTxKj kuGxqhJsGJYwzqFE+LRy/TpXb5EiDu9kNMeXj8AzlIIKZMJgXjJLRYYUJck4k2wKtpaN /Y9Uvi/sEc/gV30gm7AAgrtsh4m9GWvfEeOE+ZL/lIufWNivGyzAWH0J5QGHOdHp22a3 F8tHh/DfGJCsOV/G1/7EAHZATEE2ldMiASBfqezPjktUV53LDxHrNqZIx14uTW3FUAki F3aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784231726; x=1784836526; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hFJ0EpzatP7/QvJCIqNNnPldKAnCwWETMXqW+7ClCHY=; b=KLCkUk7y74/WAWCGVFIfEBj0P303YxVqzBjUBpLU/QP1DMB3C3Bn1gAk5CUnGZk6lH 0ypYo8yEYP/+n2/Svnj7k5eVYe/xO6CS2Wd4hw/5x1qxFFUbi2eURTagR6DUpRpgdS2X K4RFkGQAj4WsqXo753n4u+lDYMT0uHwME1LoA/oEBfXbSDjTYz3/dBKuE9LyD1j16QTu oUVUZswBdQFgYZE+C2vjOwoZjzt9QqZ1OtEy3dSqiqUoZbHt/GOpH9H8XMvBgOlAz/uj n4lTHpduZF/UdPoDPDfYXA5jrbl3m9MsYm6kISERtPfp9EFvJCVgGh3xhcv+QoCRo7jN 9qDw== X-Forwarded-Encrypted: i=1; AHgh+RoGEL03BiPmLdjEa2S6kYeYGVnZz4omWnXoZipLfDJD4fga5NXkmsQlw7PD+Pt7L04/H/uEQmI0DOHQc6A=@vger.kernel.org X-Gm-Message-State: AOJu0YzL39ELi4XIcQOSaS6+OQD5F+Ph2ha4K53X2KQmcnhszyNhR6Vu gov/F6Kq4IoGMUPRMXjzcuBlQ2yfooH9fOyZDH/zd2Iz3IIl8/xO7SlMYx3yysyr4LXGg9518Za eQ8OI X-Gm-Gg: AfdE7cma/RtdAtKVRDphn+PNOC8wMNL+TOZeb0dhs8zfo+sUz+KmsimXVvXnBSGpFB5 dyBEuUbrrA3n0jO2Yhmetuvh1X0DRcARx0kOYjnvB/o77NsVvT5+8MFZFRE9olySQDyNel0mEJt VYtpY68FtT/1l0R+3fZCryvu10+a/0nNjKlyxm5RvFqZ1SKHQaqy+GISQO8jH593AvzwBZO3I0Q rVtYP44cIFQ1qMyUJkiHaofSFZMQQbBrr5Kec6mgy+32mMpxbYgJEmDtQp/YWaj6+gq3MxNdMzy PnuBoKfTHlkoR9xe3jbWzlr01zd2KZ9sZ+2sOlWhToS+DJct7T7jDzHRARXrZBWKfCI3dKIYnAJ w/c/SrmUTtUEKGQO9qgTklcAoF0nrj1bzkBRF6rGEe5IVQ1VEKjURl3Rp9fxNj4b92YM9LXsfVv pLKui0sRg= X-Received: by 2002:a05:600c:8b6d:b0:495:3fc4:81b4 with SMTP id 5b1f17b1804b1-495403fcaadmr65609285e9.30.1784231726263; Thu, 16 Jul 2026 12:55:26 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-49547988756sm14556025e9.6.2026.07.16.12.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 12:55:25 -0700 (PDT) Date: Thu, 16 Jul 2026 21:55:23 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Brian Masney Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] clk: qcom: Drop inclusions of Message-ID: References: <7b6441aa3b0dba35112ea486bfea3b3171d8527b.1784225976.git.ukleinek@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dqkq77d6dtuu255e" Content-Disposition: inline In-Reply-To: --dqkq77d6dtuu255e Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1] clk: qcom: Drop inclusions of MIME-Version: 1.0 Hello Brian, On Thu, Jul 16, 2026 at 03:15:55PM -0400, Brian Masney wrote: > On Thu, Jul 16, 2026 at 08:21:05PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > The only used symbol in these four drivers that is provided by > > is of_device_id and this is also provided by > > . >=20 > I don't see it defined in platform_device, unless I am missing > something? >=20 > It looks like the reason this compiles is because of this chain of > includes: >=20 > linux/clk-provider.h -> linux/of.h -> linux/device-id/of.h Well, the chain for is: -> -> -> but the more relevant thing is: makes use of struct of_device_id and most consumer of that header (typically platform drivers) need struct of_device_id. So it's very sensible that is enough to get that definition. The include chain is just an implementation detail. =20 > > So drop the unneeded include which brings us > > one step closer to removing . > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) >=20 > With an updated commit message: >=20 > Reviewed-by: Brian Masney Does this discussion convince you that the commit log is ok as is? Thanks Uwe --dqkq77d6dtuu255e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpZNykACgkQj4D7WH0S /k6ljgf1H7m6MuWzdTL3PPS2CmQmF0zqeBZ7EYoM32dLL1e9Yr6O0gFZNZwnGWrr tTXctZ1u1LJslAfnJ/6Dyc3meHNXlgpOFxJYuQz8G01n/eYKx2yCEq7k5MIRoVj/ qCTzcuywXdlsDwyVHYyiONlBfJjgVTdMrCENFPObWTjqs5lZkMgaajH74RlF4b6b MbJBX1BmlzgPPw+8RTRDvqQUHl/LsXgriWDQb7pBqCsLuCMfVags1CbYsxDdfN1Y 8VxyKMELO2a1sj6odYEekuTUpZ6JLjwXgR1yne7k01KkyfXAbJyUBLTVInv2jvtr k6tuCpT2Maqlu144x/WffOSo8CSQ =XhNj -----END PGP SIGNATURE----- --dqkq77d6dtuu255e--