From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D608042D75E for ; Thu, 16 Jul 2026 16:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784220005; cv=none; b=Ba6qkVB7ca1WDl1SSwdqB6Y2Nn+2PBacxyRlh6WpO2Ln1oJsZCTIkXCzgC7s+5xQdP7eQtS2fETdHOJrxKH1gJVqZieTcGyuKSdqp0qmExKtDI8BoACoA0iI/balgbbrFtlsl591YYL0nm7N5QCtBzO+hbQpK8vJ12QhwGKx4aA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784220005; c=relaxed/simple; bh=sCnSEAcQLkSlVpUucyYp9aMacNMMDnI5O/pPjNUvsxw=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jDM9G4WpAsj0za6hOKrmPQjMFZqz/j2hmU88sfs0jsoDtCUp155lcw0P856r6CB/rkBp6LQ/NfMuamwmdXJs9//0Ymt0Z69lUcYx9ueUWAj8GCtfmA+FotGjAV6xRFqsp6jzFbkJi9IDeZsnTMVEYpOqOYfXfUVtdwkYKnLvLOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Vk4UzJO2; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Vk4UzJO2" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47f3b39f2a1so2510582f8f.2 for ; Thu, 16 Jul 2026 09:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784219990; x=1784824790; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=PhJR0B4zmY+ut1WPpB2f7MS0nYEiVkKYS005pg+HUHo=; b=Vk4UzJO2olppsSVxJWNOoL2pvvgmBSriGXX9azJZkarUk9UpY7HP1lZiccfIykSRDL mUWX3iZPPQrn7VJAHJeHGtZl4S09/N6TJONCnKTNMiZU+q0EJxmAKw0UqUSWHma7zs3U vPKBoVbOUE9fhKBz2Ajs7dowtos22/dKWe86+LnwiMAMzT0CjZ43KJ5FsdXM2ZrqEF8M OjF0rp7OU7U0qWBTPIChk7mM7MOikCQ9vWnnk4Otfcni29E2D61s8p74wCWXWTy/09wL lcj64I8gY1w9vYpwYgErkYsYFE3a4McnCkMNDvqn4zEvpm1XoQeeejPMp696mtxWOFn3 ka7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784219990; x=1784824790; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PhJR0B4zmY+ut1WPpB2f7MS0nYEiVkKYS005pg+HUHo=; b=D4C7g++rE6KYFr2xKPsX0TjQyAI6BKB4s4x+Hf/ciWHaQc1j1hfiA6MHQVQFUqLuWK U0M6yXjEMVbukjuHaNTcQ/EgKoyf2dtwZ3+Luw5tx/RW0FEbzbW3TbvFzRqVq0ooPk6x R2tdA9CeUUENItBpn7uGkctybR5D0boKEvwB7EQalN4mLYazIa1z4yEwegUQkhd0ZDZU 763YElCRsAJH45X08+t4jj1H+CsF9ZU1+TN/0qZbxKIDr04iVDH6eC/KbskdPnlFFyWY YyS+c1jDCTDcK+nTtdTN83RB47+XENhbj5ozjhbgrg51Egh/CO/SKJYFWEYVJhA/LpoK zYdQ== X-Forwarded-Encrypted: i=1; AHgh+RrCBzOuNtsQV3pSheHkJOAMFdOm59yMkqD5JeKNOQiHQN/o809m0SBdTL0/SvILLfoZ/mkI6DfbadZYyW4=@vger.kernel.org X-Gm-Message-State: AOJu0YwsxlaAfB8PX5X2WvFbmE3JASMcqpoPkdRITJQcggBysngL8JjE NxY1MzIOLNF4wLbMWS8Ny8cW5jSatOiRzli4mnAkeiu6bBVtgijFXwIZtAIkrFY6Ra3CNCru7Jt +OVN3erc= X-Gm-Gg: AfdE7ckt/BZvfwAXKUskREi3aoy42/TUT1/mypHzKdl0fWVi1vZNpbFguZz3pcQLQvv lLGjFgjLn/iU59nKXPDr+SkWEqgr0Uo2payPInXbo47AaaBDjvS9x7roU6W5tbvTtZvc2Cx+osh sgyPrF2YM4nWzVO03ilWP0jUYh/YOk+OwJ8jugykZslJYA1mX97np1WBx1cGTaL//eOUd0rw7Ur uFk8BBftnf80RKBQol6hOjytwOroKh1dWh07S0fuflw8QYOij7GoKi7dCVHf7HoQ8JOKAQ/NKdA mtgBFRDv8Ib+BtI7nvL1KHftpUGWdbD9dzMxPw4M8IrfGuMgUg8RoActE0rI8okpljBXmiIy0uJ YYtkOqjDDzSlokkXh1OEAfZ5rGCvrgm3W6Z7Jwt6iMUQgshDjPFYPnCQ4qpczgzHcjrzetlR6ef tzeNlHRxvaHeM= X-Received: by 2002:a05:600c:3111:b0:495:43ab:4f6b with SMTP id 5b1f17b1804b1-49548391e8amr981835e9.8.1784219989650; Thu, 16 Jul 2026 09:39:49 -0700 (PDT) Received: from localhost ([195.94.145.62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954812f0d0sm4841415e9.12.2026.07.16.09.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 09:39:49 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 16 Jul 2026 18:43:18 +0200 To: "Jiri Slaby (SUSE)" Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Andrea della Porta , Arnd Bergmann Subject: Re: [PATCH] misc: rp1: Switch to irq_domain_create_linear() Message-ID: References: <20260708095733.385396-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260708095733.385396-1-jirislaby@kernel.org> Hi Jiri, On 11:57 Wed 08 Jul , Jiri Slaby (SUSE) wrote: > irq_domain_add_linear() is going away as being obsolete now. Switch to > the preferred irq_domain_create_linear(). That differs in the first > parameter: It takes more generic struct fwnode_handle instead of struct > device_node. Therefore, of_fwnode_handle() is added around the > parameter. > > Note some of the users can likely use dev->fwnode directly instead of > indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not > guaranteed to be set for all, so this has to be investigated on case to > case basis (by people who can actually test with the HW). > > Signed-off-by: Jiri Slaby (SUSE) > Cc: Thomas Gleixner > Cc: Andrea della Porta > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > --- > drivers/misc/rp1/rp1_pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/rp1/rp1_pci.c b/drivers/misc/rp1/rp1_pci.c > index 81685e3f3296..4a0620e85ad5 100644 > --- a/drivers/misc/rp1/rp1_pci.c > +++ b/drivers/misc/rp1/rp1_pci.c > @@ -238,8 +238,8 @@ static int rp1_probe(struct pci_dev *pdev, const struct pci_device_id *id) > } > > pci_set_drvdata(pdev, rp1); > - rp1->domain = irq_domain_add_linear(rp1_node, RP1_INT_END, > - &rp1_domain_ops, rp1); > + rp1->domain = irq_domain_create_linear(of_fwnode_handle(rp1_node), RP1_INT_END, > + &rp1_domain_ops, rp1); > if (!rp1->domain) { > dev_err(&pdev->dev, "Error creating IRQ domain\n"); > err = -ENOMEM; > -- > 2.55.0 > Tested-by: Andrea della Porta Thanks!